Message ID | lfuu4d$uam$2@ger.gmane.org |
---|---|
State | Superseded |
Headers |
Return-Path: <x14307373@homiemail-mx20.g.dreamhost.com> X-Original-To: siddhesh@wilcox.dreamhost.com Delivered-To: siddhesh@wilcox.dreamhost.com Received: from homiemail-mx20.g.dreamhost.com (caibbdcaaahc.dreamhost.com [208.113.200.72]) by wilcox.dreamhost.com (Postfix) with ESMTP id 00D03360102 for <siddhesh@wilcox.dreamhost.com>; Fri, 14 Mar 2014 05:54:14 -0700 (PDT) Received: by homiemail-mx20.g.dreamhost.com (Postfix, from userid 14307373) id A4BD540857749; Fri, 14 Mar 2014 05:54:14 -0700 (PDT) X-Original-To: glibc@patchwork.siddhesh.in Delivered-To: x14307373@homiemail-mx20.g.dreamhost.com Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by homiemail-mx20.g.dreamhost.com (Postfix) with ESMTPS id 4BA7C40E92DA1 for <glibc@patchwork.siddhesh.in>; Fri, 14 Mar 2014 05:54:14 -0700 (PDT) DomainKey-Signature: a=rsa-sha1; c=nofws; d=sourceware.org; h=list-id :list-unsubscribe:list-subscribe:list-archive:list-post :list-help:sender:to:from:subject:date:message-id:mime-version :content-type; q=dns; s=default; b=QrhuaXSmQUFbdDuPzf8b+XD11dd9U tFOMNvdno36Pq74e+sukgXGxMqMdcnRPr1Qu1LOqJBA/m49etTW2tA0l/67+7n3F NAU0JC/VlujZk0WqOWcSgeuHml/1vFo2F1V2OaUx+WCXJAFpBxKDek10/5f4iMys 0Av5QMbm7vRaEk= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=sourceware.org; h=list-id :list-unsubscribe:list-subscribe:list-archive:list-post :list-help:sender:to:from:subject:date:message-id:mime-version :content-type; s=default; bh=Wu771i+x8s8k05dtDyyiVivdsWc=; b=pc0 Qb4kR0+IsQOC08QdmLtPWjfFkYKSVqEz27P0IbsSYFbfREOn2G4M9dkg3MPcR2wp pICXlv9AWO039OTqs/HeV58XLUENaPVFKs62arKKxWq7cAbaI/iI1vXXShlGSKHi x5+DtxxKn7BtY3fF66GKohDFq8YB9ZASdBIaCzFk= Received: (qmail 20919 invoked by alias); 14 Mar 2014 12:54:11 -0000 Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: <libc-alpha.sourceware.org> List-Unsubscribe: <mailto:libc-alpha-unsubscribe-glibc=patchwork.siddhesh.in@sourceware.org> List-Subscribe: <mailto:libc-alpha-subscribe@sourceware.org> List-Archive: <http://sourceware.org/ml/libc-alpha/> List-Post: <mailto:libc-alpha@sourceware.org> List-Help: <mailto:libc-alpha-help@sourceware.org>, <http://sourceware.org/ml/#faqs> Sender: libc-alpha-owner@sourceware.org Delivered-To: mailing list libc-alpha@sourceware.org Received: (qmail 20907 invoked by uid 89); 14 Mar 2014 12:54:10 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.1 required=5.0 tests=AWL, BAYES_00, RCVD_IN_DNSWL_NONE, SPF_HELO_PASS, SPF_PASS, T_RP_MATCHES_RCVD autolearn=ham version=3.3.2 X-HELO: plane.gmane.org To: libc-alpha@sourceware.org From: Stefan Liebler <stli@linux.vnet.ibm.com> Subject: [PATCH] S/390: xfail test POSIX/signal.h Date: Fri, 14 Mar 2014 13:53:47 +0100 Lines: 46 Message-ID: <lfuu4d$uam$2@ger.gmane.org> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="------------090504040308080204050103" User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.3.0 X-DH-Original-To: glibc@patchwork.siddhesh.in |
Commit Message
Stefan Liebler
March 14, 2014, 12:53 p.m. UTC
Hi, on S390x the conformance test conform/POSIX/signal.h/conform.out is failing, due to incorrect type. The member sa_flags in struct sigaction on s390x is defined as unsigned long instead of int due to the kernel struct. On other platforms, sa_flags is also unsigned long: ia64, sparc, hppa. Bye --- 2014-03-14 Stefan Liebler <stli@linux.vnet.ibm.com> * sysdeps/s390/s390-64/Makefile (test-xfail-POSIX/signal.h/conform): New Variable. ---
Comments
On Fri, 14 Mar 2014, Stefan Liebler wrote: > Hi, > > on S390x the conformance test conform/POSIX/signal.h/conform.out is failing, > due to incorrect type. > The member sa_flags in struct sigaction on s390x is defined > as unsigned long instead of int due to the kernel struct. > On other platforms, sa_flags is also unsigned long: ia64, sparc, hppa. If you need to XFAIL such a test on an architecture-specific basis, the XFAIL should have a comment explaining why the test is expected to fail. However, in this case I don't see the need to XFAIL it. As far as I can tell, the upper bits of sa_flags aren't actually assigned. So you should be able to change the structure so that sa_flags is int, with an adjacent padding field. This would mean random padding is passed to the kernel in what the kernel thinks is the high part of the field, so you should either get kernel agreement that this is OK, or make glibc's sigaction implementation copy the structure and zero the padding. (Again, file a bug in glibc Bugzilla before fixing it.)
diff --git a/sysdeps/s390/s390-64/Makefile b/sysdeps/s390/s390-64/Makefile index 37f021c..66c159e 100644 --- a/sysdeps/s390/s390-64/Makefile +++ b/sysdeps/s390/s390-64/Makefile @@ -10,6 +10,10 @@ CFLAGS-dl-load.c += -Wno-unused CFLAGS-dl-reloc.c += -Wno-unused endif +ifeq ($(subdir),conform) +test-xfail-POSIX/signal.h/conform = yes +endif + ifeq ($(subdir),iconvdata) ISO-8859-1_CP037_Z900-routines := iso-8859-1_cp037_z900 ISO-8859-1_CP037_Z900-map := gconv.map