diff mbox

[1/5] Make common fdim implementation generic.

Message ID fec7157b6b5bb8995fc5fbc49aba635e636494d0.1472599898.git.murphyp@linux.vnet.ibm.com
State Committed
Delegated to: Joseph Myers
Headers

Commit Message

Paul E. Murphy Aug. 30, 2016, 11:39 p.m. UTC 
  The only difference is the usage of math_narrow_eval when
building s_fdiml.c.  This should be harmless for long double,
but I did observe some code generation changes on m68k, but
lack the resources to test it.

Likewise, to more easily support overriding symbol generation,
the aliasing macros are always conditionally defined on their
absence to reduce boilerplate.

I also ran builds for i486, ppc64, sparcv9, aarch64,
s390x and observed no changes to s_fdim* objects.

	 * math/Makefile (gen-libm-calls): Add s_fdim.
	 (libm-calls): Move to above.

	 * math/s_fdim.c: Renamed and refactored into to ...
	 * math/s_fdim_template.c: New file.
	 * math/s_fdiml.c: Removed.
	 * sysdeps/ieee754/ldbl-opt/s_fdim.c: Removed.
	 * sysdeps/ieee754/ldbl-opt/s_fdiml.c: Removed.

	 * sysdeps/generic/math-type-macros-double.h:
	 (declare_mgen_alias): Don't declare if already declared.
	 * sysdeps/ieee754/ldbl-opt/math-type-macros-ldouble.h:
	 Likewise.

	 * sysdeps/ieee754/ldbl-opt/math-type-macros-double.h:
	 (declare_mgen_alias): Don't declare if already declared.
	 (M_LIBM_NEED_COMPAT): Likewise.
	 (declare_mgen_libm_compat): Likewise.
	 (LDOUBLE_fdiml_libm_version): New macro.

	 * sysdeps/sparc/sparc32/sparcv9/fpu/multiarch/s_fdim.c:
	 Include math/s_fdim.c now that ldbl-opt version is not needed.
	 (declare_mgen_alias): New macro to disable aliasing.

	 * sysdeps/sparc/sparc32/sparcv9/fpu/multiarch/s_fdimf-vis3.c:
	 (declare_mgen_alias): Likewise.
	 * sysdeps/sparc/sparc32/sparcv9/fpu/multiarch/s_fdimf.c:
	 (declare_mgen_alias): Likewise.
	 * sysdeps/sparc/sparc32/sparcv9/fpu/multiarch/s_fdim-vis3.c:
	 (declare_mgen_alias): Likewise.
	 (M_LIBM_NEED_COMPAT): Likewise.
---
 math/Makefile                                      |  4 +--
 math/s_fdim.c                                      | 42 ----------------------
 math/s_fdim_template.c                             | 40 +++++++++++++++++++++
 math/s_fdimf.c                                     | 38 --------------------
 math/s_fdiml.c                                     | 35 ------------------
 sysdeps/generic/math-type-macros-double.h          |  4 +--
 sysdeps/ieee754/ldbl-opt/math-type-macros-double.h | 13 ++++---
 .../ieee754/ldbl-opt/math-type-macros-ldouble.h    |  6 ++--
 sysdeps/ieee754/ldbl-opt/s_fdim.c                  |  5 ---
 sysdeps/ieee754/ldbl-opt/s_fdiml.c                 |  5 ---
 .../sparc32/sparcv9/fpu/multiarch/s_fdim-vis3.c    |  2 ++
 .../sparc/sparc32/sparcv9/fpu/multiarch/s_fdim.c   |  3 +-
 .../sparc32/sparcv9/fpu/multiarch/s_fdimf-vis3.c   |  1 +
 .../sparc/sparc32/sparcv9/fpu/multiarch/s_fdimf.c  |  2 ++
 14 files changed, 64 insertions(+), 136 deletions(-)
 delete mode 100644 math/s_fdim.c
 create mode 100644 math/s_fdim_template.c
 delete mode 100644 math/s_fdimf.c
 delete mode 100644 math/s_fdiml.c
 delete mode 100644 sysdeps/ieee754/ldbl-opt/s_fdim.c
 delete mode 100644 sysdeps/ieee754/ldbl-opt/s_fdiml.c

Comments

Joseph Myers Aug. 31, 2016, 4:46 p.m. UTC | #1 
On Tue, 30 Aug 2016, Paul E. Murphy wrote:

>  /* Define compat symbols for long double on platforms
>     where it was not always a distinct type.  */
> -#define M_LIBM_NEED_COMPAT(f) \
> -  LONG_DOUBLE_COMPAT (libm, LDOUBLE_ ## f ## l_libm_version)
> +#if !defined M_LIBM_NEED_COMPAT
> +# define M_LIBM_NEED_COMPAT(f) \
> +   LONG_DOUBLE_COMPAT (libm, LDOUBLE_ ## f ## l_libm_version)

Two-column indentation is still correct for the continuation line; it 
should not be changed.

> -#define declare_mgen_libm_compat(from, to)	      \
> -  compat_symbol (libm, from, to ## l,		      \
> +#if !defined declare_mgen_libm_compat
> +# define declare_mgen_libm_compat(from, to)	      \
> +   compat_symbol (libm, from, to ## l,		      \
>  		 LDOUBLE_ ## to ## l_libm_version);

Likewise here (if a change were correct, the following line would have 
needed reindenting as well to stay aligned with the '(').

> -#define declare_mgen_alias(from, to) \
> -  long_double_symbol (libm, from ## l, to ## l);
> +#if !defined declare_mgen_alias
> +# define declare_mgen_alias(from, to) \
> +   long_double_symbol (libm, from ## l, to ## l);

Likewise here.

OK with those fixes.
Paul E. Murphy Sept. 1, 2016, 3:34 p.m. UTC | #2 
On 08/31/2016 11:46 AM, Joseph Myers wrote:
> On Tue, 30 Aug 2016, Paul E. Murphy wrote:
> 
>>  /* Define compat symbols for long double on platforms
>>     where it was not always a distinct type.  */
>> -#define M_LIBM_NEED_COMPAT(f) \
>> -  LONG_DOUBLE_COMPAT (libm, LDOUBLE_ ## f ## l_libm_version)
>> +#if !defined M_LIBM_NEED_COMPAT
>> +# define M_LIBM_NEED_COMPAT(f) \
>> +   LONG_DOUBLE_COMPAT (libm, LDOUBLE_ ## f ## l_libm_version)
> 
> Two-column indentation is still correct for the continuation line; it 
> should not be changed.
> 
>> -#define declare_mgen_libm_compat(from, to)	      \
>> -  compat_symbol (libm, from, to ## l,		      \
>> +#if !defined declare_mgen_libm_compat
>> +# define declare_mgen_libm_compat(from, to)	      \
>> +   compat_symbol (libm, from, to ## l,		      \
>>  		 LDOUBLE_ ## to ## l_libm_version);
> 
> Likewise here (if a change were correct, the following line would have 
> needed reindenting as well to stay aligned with the '(').
> 
>> -#define declare_mgen_alias(from, to) \
>> -  long_double_symbol (libm, from ## l, to ## l);
>> +#if !defined declare_mgen_alias
>> +# define declare_mgen_alias(from, to) \
>> +   long_double_symbol (libm, from ## l, to ## l);
> 
> Likewise here.
> 
> OK with those fixes.
> 

Fixes made, and committed as 7b7c394.
diff mbox

Patch

diff --git a/math/Makefile b/math/Makefile
index f1b7937..d4b6d98 100644
--- a/math/Makefile
+++ b/math/Makefile
@@ -49,7 +49,7 @@  gen-libm-calls = cargF conjF cimagF crealF cabsF s_cacosF		  \
 	         s_cacoshF s_ccosF s_ccoshF s_casinF s_csinF s_casinhF	  \
 		 k_casinhF s_csinhF k_casinhF s_csinhF s_catanhF s_catanF \
 		 s_ctanF s_ctanhF s_cexpF s_clogF s_cprojF s_csqrtF	  \
-		 s_cpowF s_clog10F
+		 s_cpowF s_clog10F s_fdimF
 
 libm-calls =								  \
 	e_acosF e_acoshF e_asinF e_atan2F e_atanhF e_coshF e_expF e_fmodF \
@@ -65,7 +65,7 @@  libm-calls =								  \
 	w_tgammaF w_hypotF w_j0F w_j1F w_jnF w_lgammaF w_lgammaF_r	  \
 	w_logF w_log10F w_powF w_remainderF w_scalbF w_sinhF w_sqrtF	  \
 	w_ilogbF							  \
-	s_fpclassifyF s_fmaxF s_fminF s_fdimF s_nanF s_truncF		  \
+	s_fpclassifyF s_fmaxF s_fminF s_nanF s_truncF		  	  \
 	s_remquoF e_log2F e_exp2F s_roundF s_nearbyintF s_sincosF	  \
 	s_fmaF s_lrintF s_llrintF s_lroundF s_llroundF e_exp10F w_log2F	  \
 	s_issignalingF $(calls:s_%=m_%) x2y2m1F				  \
diff --git a/math/s_fdim.c b/math/s_fdim.c
deleted file mode 100644
index 1786521..0000000
--- a/math/s_fdim.c
+++ /dev/null
@@ -1,42 +0,0 @@ 
-/* Return positive difference between arguments.
-   Copyright (C) 1997-2016 Free Software Foundation, Inc.
-   This file is part of the GNU C Library.
-   Contributed by Ulrich Drepper <drepper@cygnus.com>, 1997.
-
-   The GNU C Library is free software; you can redistribute it and/or
-   modify it under the terms of the GNU Lesser General Public
-   License as published by the Free Software Foundation; either
-   version 2.1 of the License, or (at your option) any later version.
-
-   The GNU C Library is distributed in the hope that it will be useful,
-   but WITHOUT ANY WARRANTY; without even the implied warranty of
-   MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
-   Lesser General Public License for more details.
-
-   You should have received a copy of the GNU Lesser General Public
-   License along with the GNU C Library; if not, see
-   <http://www.gnu.org/licenses/>.  */
-
-#include <errno.h>
-#include <math.h>
-#include <math_private.h>
-
-double
-__fdim (double x, double y)
-{
-  if (islessequal (x, y))
-    return 0.0;
-
-  double r = math_narrow_eval (x - y);
-  if (isinf (r) && !isinf (x) && !isinf (y))
-    __set_errno (ERANGE);
-
-  return r;
-}
-#ifndef __fdim
-weak_alias (__fdim, fdim)
-# ifdef NO_LONG_DOUBLE
-strong_alias (__fdim, __fdiml)
-weak_alias (__fdim, fdiml)
-# endif
-#endif
diff --git a/math/s_fdim_template.c b/math/s_fdim_template.c
new file mode 100644
index 0000000..d3e7379
--- /dev/null
+++ b/math/s_fdim_template.c
@@ -0,0 +1,40 @@ 
+/* Return positive difference between arguments.
+   Copyright (C) 1997-2016 Free Software Foundation, Inc.
+   This file is part of the GNU C Library.
+   Contributed by Ulrich Drepper <drepper@cygnus.com>, 1997.
+
+   The GNU C Library is free software; you can redistribute it and/or
+   modify it under the terms of the GNU Lesser General Public
+   License as published by the Free Software Foundation; either
+   version 2.1 of the License, or (at your option) any later version.
+
+   The GNU C Library is distributed in the hope that it will be useful,
+   but WITHOUT ANY WARRANTY; without even the implied warranty of
+   MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
+   Lesser General Public License for more details.
+
+   You should have received a copy of the GNU Lesser General Public
+   License along with the GNU C Library; if not, see
+   <http://www.gnu.org/licenses/>.  */
+
+#include <errno.h>
+#include <math.h>
+#include <math_private.h>
+
+FLOAT
+M_DECL_FUNC (__fdim) (FLOAT x, FLOAT y)
+{
+  if (islessequal (x, y))
+    return 0;
+
+  FLOAT r = math_narrow_eval (x - y);
+  if (isinf (r) && !isinf (x) && !isinf (y))
+    __set_errno (ERANGE);
+
+  return r;
+}
+declare_mgen_alias (__fdim, fdim);
+
+#if M_LIBM_NEED_COMPAT (fdim)
+declare_mgen_libm_compat (__fdim, fdim)
+#endif
diff --git a/math/s_fdimf.c b/math/s_fdimf.c
deleted file mode 100644
index e457f9d..0000000
--- a/math/s_fdimf.c
+++ /dev/null
@@ -1,38 +0,0 @@ 
-/* Return positive difference between arguments.
-   Copyright (C) 1997-2016 Free Software Foundation, Inc.
-   This file is part of the GNU C Library.
-   Contributed by Ulrich Drepper <drepper@cygnus.com>, 1997.
-
-   The GNU C Library is free software; you can redistribute it and/or
-   modify it under the terms of the GNU Lesser General Public
-   License as published by the Free Software Foundation; either
-   version 2.1 of the License, or (at your option) any later version.
-
-   The GNU C Library is distributed in the hope that it will be useful,
-   but WITHOUT ANY WARRANTY; without even the implied warranty of
-   MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
-   Lesser General Public License for more details.
-
-   You should have received a copy of the GNU Lesser General Public
-   License along with the GNU C Library; if not, see
-   <http://www.gnu.org/licenses/>.  */
-
-#include <errno.h>
-#include <math.h>
-#include <math_private.h>
-
-float
-__fdimf (float x, float y)
-{
-  if (islessequal (x, y))
-    return 0.0f;
-
-  float r = math_narrow_eval (x - y);
-  if (isinf (r) && !isinf (x) && !isinf (y))
-    __set_errno (ERANGE);
-
-  return r;
-}
-#ifndef __fdimf
-weak_alias (__fdimf, fdimf)
-#endif
diff --git a/math/s_fdiml.c b/math/s_fdiml.c
deleted file mode 100644
index 4a1f672..0000000
--- a/math/s_fdiml.c
+++ /dev/null
@@ -1,35 +0,0 @@ 
-/* Return positive difference between arguments.
-   Copyright (C) 1997-2016 Free Software Foundation, Inc.
-   This file is part of the GNU C Library.
-   Contributed by Ulrich Drepper <drepper@cygnus.com>, 1997.
-
-   The GNU C Library is free software; you can redistribute it and/or
-   modify it under the terms of the GNU Lesser General Public
-   License as published by the Free Software Foundation; either
-   version 2.1 of the License, or (at your option) any later version.
-
-   The GNU C Library is distributed in the hope that it will be useful,
-   but WITHOUT ANY WARRANTY; without even the implied warranty of
-   MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
-   Lesser General Public License for more details.
-
-   You should have received a copy of the GNU Lesser General Public
-   License along with the GNU C Library; if not, see
-   <http://www.gnu.org/licenses/>.  */
-
-#include <errno.h>
-#include <math.h>
-
-long double
-__fdiml (long double x, long double y)
-{
-  if (islessequal (x, y))
-    return 0.0f;
-
-  long double r = x - y;
-  if (isinf (r) && !isinf (x) && !isinf (y))
-    __set_errno (ERANGE);
-
-  return r;
-}
-weak_alias (__fdiml, fdiml)
diff --git a/sysdeps/generic/math-type-macros-double.h b/sysdeps/generic/math-type-macros-double.h
index 4149b39..154f416 100644
--- a/sysdeps/generic/math-type-macros-double.h
+++ b/sysdeps/generic/math-type-macros-double.h
@@ -29,12 +29,12 @@ 
 /* Machines without a distinct long double type
    alias long double functions to their double
    equivalent.  */
-#if defined NO_LONG_DOUBLE
+#if defined NO_LONG_DOUBLE && !defined declare_mgen_alias
 # define declare_mgen_alias(from, to)	    \
    weak_alias (from, to)		    \
    strong_alias (from, from ## l)	    \
    weak_alias (from, to ## l)
-#else
+#elif !defined declare_mgen_alias
 # define declare_mgen_alias(from, to)	    \
    weak_alias (M_SUF (from), M_SUF (to))
 #endif
diff --git a/sysdeps/ieee754/ldbl-opt/math-type-macros-double.h b/sysdeps/ieee754/ldbl-opt/math-type-macros-double.h
index 8cb5694..e9b1508 100644
--- a/sysdeps/ieee754/ldbl-opt/math-type-macros-double.h
+++ b/sysdeps/ieee754/ldbl-opt/math-type-macros-double.h
@@ -44,15 +44,20 @@ 
 #define LDOUBLE_cpowl_libm_version GLIBC_2_1
 #define LDOUBLE_clog10l_libm_version GLIBC_2_1
 #define LDOUBLE___clog10l_libm_version GLIBC_2_1
+#define LDOUBLE_fdiml_libm_version GLIBC_2_1
 
 /* Define compat symbols for long double on platforms
    where it was not always a distinct type.  */
-#define M_LIBM_NEED_COMPAT(f) \
-  LONG_DOUBLE_COMPAT (libm, LDOUBLE_ ## f ## l_libm_version)
+#if !defined M_LIBM_NEED_COMPAT
+# define M_LIBM_NEED_COMPAT(f) \
+   LONG_DOUBLE_COMPAT (libm, LDOUBLE_ ## f ## l_libm_version)
+#endif
 
-#define declare_mgen_libm_compat(from, to)	      \
-  compat_symbol (libm, from, to ## l,		      \
+#if !defined declare_mgen_libm_compat
+# define declare_mgen_libm_compat(from, to)	      \
+   compat_symbol (libm, from, to ## l,		      \
 		 LDOUBLE_ ## to ## l_libm_version);
+#endif
 
 #include_next <math-type-macros-double.h>
 #endif
diff --git a/sysdeps/ieee754/ldbl-opt/math-type-macros-ldouble.h b/sysdeps/ieee754/ldbl-opt/math-type-macros-ldouble.h
index d2af4bb..30cb2fb 100644
--- a/sysdeps/ieee754/ldbl-opt/math-type-macros-ldouble.h
+++ b/sysdeps/ieee754/ldbl-opt/math-type-macros-ldouble.h
@@ -22,8 +22,10 @@ 
 
 /* Use properly versioned symbols for long double on platforms where
    it was not always a distinct type.  */
-#define declare_mgen_alias(from, to) \
-  long_double_symbol (libm, from ## l, to ## l);
+#if !defined declare_mgen_alias
+# define declare_mgen_alias(from, to) \
+   long_double_symbol (libm, from ## l, to ## l);
+#endif
 
 #include_next <math-type-macros-ldouble.h>
 #endif
diff --git a/sysdeps/ieee754/ldbl-opt/s_fdim.c b/sysdeps/ieee754/ldbl-opt/s_fdim.c
deleted file mode 100644
index 02c95bf..0000000
--- a/sysdeps/ieee754/ldbl-opt/s_fdim.c
+++ /dev/null
@@ -1,5 +0,0 @@ 
-#include <math_ldbl_opt.h>
-#include <math/s_fdim.c>
-#if LONG_DOUBLE_COMPAT(libm, GLIBC_2_1)
-compat_symbol (libm, __fdim, fdiml, GLIBC_2_1);
-#endif
diff --git a/sysdeps/ieee754/ldbl-opt/s_fdiml.c b/sysdeps/ieee754/ldbl-opt/s_fdiml.c
deleted file mode 100644
index 06b760b..0000000
--- a/sysdeps/ieee754/ldbl-opt/s_fdiml.c
+++ /dev/null
@@ -1,5 +0,0 @@ 
-#include <math_ldbl_opt.h>
-#undef weak_alias
-#define weak_alias(n,a)
-#include <math/s_fdiml.c>
-long_double_symbol (libm, __fdiml, fdiml);
diff --git a/sysdeps/sparc/sparc32/sparcv9/fpu/multiarch/s_fdim-vis3.c b/sysdeps/sparc/sparc32/sparcv9/fpu/multiarch/s_fdim-vis3.c
index 2973b49..6176517 100644
--- a/sysdeps/sparc/sparc32/sparcv9/fpu/multiarch/s_fdim-vis3.c
+++ b/sysdeps/sparc/sparc32/sparcv9/fpu/multiarch/s_fdim-vis3.c
@@ -19,5 +19,7 @@ 
 #include <math.h>
 
 #define __fdim __fdim_vis3
+#define declare_mgen_alias(t, f)
+#define M_LIBM_NEED_COMPAT(f) 0
 
 #include <math/s_fdim.c>
diff --git a/sysdeps/sparc/sparc32/sparcv9/fpu/multiarch/s_fdim.c b/sysdeps/sparc/sparc32/sparcv9/fpu/multiarch/s_fdim.c
index 9666741..2d07f31 100644
--- a/sysdeps/sparc/sparc32/sparcv9/fpu/multiarch/s_fdim.c
+++ b/sysdeps/sparc/sparc32/sparcv9/fpu/multiarch/s_fdim.c
@@ -27,6 +27,7 @@  sparc_libm_ifunc(__fdim, hwcap & HWCAP_SPARC_VIS3 ? __fdim_vis3 : __fdim_generic
 weak_alias (__fdim, fdim)
 
 # define __fdim __fdim_generic
+# define declare_mgen_alias(t, f)
 #endif
 
-#include <ldbl-opt/s_fdim.c>
+#include <math/s_fdim.c>
diff --git a/sysdeps/sparc/sparc32/sparcv9/fpu/multiarch/s_fdimf-vis3.c b/sysdeps/sparc/sparc32/sparcv9/fpu/multiarch/s_fdimf-vis3.c
index 75997c6..3f35b0d 100644
--- a/sysdeps/sparc/sparc32/sparcv9/fpu/multiarch/s_fdimf-vis3.c
+++ b/sysdeps/sparc/sparc32/sparcv9/fpu/multiarch/s_fdimf-vis3.c
@@ -19,5 +19,6 @@ 
 #include <math.h>
 
 #define __fdimf __fdimf_vis3
+#define declare_mgen_alias(t, f)
 
 #include <math/s_fdimf.c>
diff --git a/sysdeps/sparc/sparc32/sparcv9/fpu/multiarch/s_fdimf.c b/sysdeps/sparc/sparc32/sparcv9/fpu/multiarch/s_fdimf.c
index 767520f..b9add1c 100644
--- a/sysdeps/sparc/sparc32/sparcv9/fpu/multiarch/s_fdimf.c
+++ b/sysdeps/sparc/sparc32/sparcv9/fpu/multiarch/s_fdimf.c
@@ -27,6 +27,8 @@  sparc_libm_ifunc(__fdimf, hwcap & HWCAP_SPARC_VIS3 ? __fdimf_vis3 : __fdimf_gene
 weak_alias (__fdimf, fdimf)
 
 # define __fdimf __fdimf_generic
+# define declare_mgen_alias(t, f)
+
 #endif
 
 #include <math/s_fdimf.c>