diff mbox

[BZ,21075] sparc - Remove unused assignment in __clone

Message ID f9b48072-4341-2ee1-8354-7c1c7b3613fa@oracle.com
State New, archived
Headers

Commit Message

Ivo Raisr Jan. 31, 2017, 4:48 a.m. UTC 
  Any news here?
I.


-------- Forwarded Message --------
Subject: [PATCH][BZ 21075 ] sparc - Remove unused assignment in __clone
Date: Thu, 26 Jan 2017 12:02:26 +0100
From: Ivo Raisr <ivo.raisr@oracle.com>
To: libc-alpha@sourceware.org

The attached patch fixes:
BZ#21075 - unused assigment to %g4 in sparc/sparc{64,32}/clone.S

It is no longer needed to preserve the flags parameter to `clone' since
the commit c579f48edba88380635ab98cb612030e3ed8691e (Remove cached
PID/TID in clone).

Testing was performed successfully on sparcv9/Linux.

See the attached patch and ChangeLog entry.

Kind regards,
I.
2017-01-26  Ivo Raisr  <ivo.raisr@oracle.com>

	[BZ #21075]
	* sysdeps/unix/sysv/linux/sparc/sparc64/clone.S (__clone): Remove
	unused assignment.
	* sysdeps/unix/sysv/linux/sparc/sparc32/clone.S (__clone): Likewise.
2017-01-26  Ivo Raisr  <ivo.raisr@oracle.com>

	[BZ #21075]
	* sysdeps/unix/sysv/linux/sparc/sparc64/clone.S (__clone): Remove
	unused assignment.
	* sysdeps/unix/sysv/linux/sparc/sparc32/clone.S (__clone): Likewise.

Comments

Adhemerval Zanella Netto Jan. 31, 2017, 12:08 p.m. UTC | #1 
https://sourceware.org/ml/libc-alpha/2017-01/msg00510.html

On 31/01/2017 02:48, Ivo Raisr wrote:
> Any news here?
> I.
> 
> 
> -------- Forwarded Message --------
> Subject: [PATCH][BZ 21075 ] sparc - Remove unused assignment in __clone
> Date: Thu, 26 Jan 2017 12:02:26 +0100
> From: Ivo Raisr <ivo.raisr@oracle.com>
> To: libc-alpha@sourceware.org
> 
> The attached patch fixes:
> BZ#21075 - unused assigment to %g4 in sparc/sparc{64,32}/clone.S
> 
> It is no longer needed to preserve the flags parameter to `clone' since
> the commit c579f48edba88380635ab98cb612030e3ed8691e (Remove cached
> PID/TID in clone).
> 
> Testing was performed successfully on sparcv9/Linux.
> 
> See the attached patch and ChangeLog entry.
> 
> Kind regards,
> I.
>
diff mbox

Patch

commit 79273faf7c11a76d6c9cb2b48c700eda772928e6
Author: Ivo Raisr <ivo.raisr@oracle.com>
Date:   Tue Jan 24 10:31:22 2017 +0100

    sparc: Remove unused assignment in __clone [BZ #21075]
    
    ChangeLog:
    
	[BZ #21075]
	* sysdeps/unix/sysv/linux/sparc/sparc64/clone.S (__clone): Remove
	unused assignment.
	* sysdeps/unix/sysv/linux/sparc/sparc32/clone.S (__clone): Likewise.

diff --git a/sysdeps/unix/sysv/linux/sparc/sparc32/clone.S b/sysdeps/unix/sysv/linux/sparc/sparc32/clone.S
index 2e5d09d..6d2f5bd 100644
--- a/sysdeps/unix/sysv/linux/sparc/sparc32/clone.S
+++ b/sysdeps/unix/sysv/linux/sparc/sparc32/clone.S
@@ -48,7 +48,6 @@  ENTRY (__clone)
 	   expects.  */
 	sub	%o1, 96, %o1
 	mov	%i3, %g3
-	mov	%i2, %g4
 
 	/* ptid */
 	mov	%i4,%o2
diff --git a/sysdeps/unix/sysv/linux/sparc/sparc64/clone.S b/sysdeps/unix/sysv/linux/sparc/sparc64/clone.S
index fea6bf7..fc28539 100644
--- a/sysdeps/unix/sysv/linux/sparc/sparc64/clone.S
+++ b/sysdeps/unix/sysv/linux/sparc/sparc64/clone.S
@@ -51,7 +51,6 @@  ENTRY (__clone)
 	   expects.  Also, subtract STACK_BIAS.  */
 	sub	%i1, 192 + 0x7ff, %o1
 	mov	%i3, %g3
-	mov	%i2, %g4
 
 	mov	%i4,%o2			/* PTID */
 	mov	%i5,%o3			/* TLS */