From patchwork Fri May 15 14:40:54 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Szabolcs Nagy X-Patchwork-Id: 39270 Return-Path: X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 83EA03986015; Fri, 15 May 2020 14:41:38 +0000 (GMT) X-Original-To: libc-alpha@sourceware.org Delivered-To: libc-alpha@sourceware.org Received: from EUR01-HE1-obe.outbound.protection.outlook.com (mail-eopbgr130081.outbound.protection.outlook.com [40.107.13.81]) by sourceware.org (Postfix) with ESMTPS id 3B9AB3985824 for ; Fri, 15 May 2020 14:41:16 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 3B9AB3985824 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=arm.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=Szabolcs.Nagy@arm.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=GKQoBgg4c3SHOriWg6bR8RhDgZ/V6mC7nVSg1lU4o3Y=; b=FycQLdX8hKUR3h3ThScYhAeHYCy5NPVcG6HWnWpGvA47WksrzzChl9GoehMuWEvKrYogL7TYHmfHDhb/onnVtfnKdA3NIdQsiw15uOg86WDWuA9o2QMiwd+EyuWFTDSfTPXiMng/99MdS2defzhAcIPGS+v+9Q6P9b9QI2WqwUw= Received: from AM6P193CA0071.EURP193.PROD.OUTLOOK.COM (2603:10a6:209:8e::48) by AM0PR08MB3058.eurprd08.prod.outlook.com (2603:10a6:208:5a::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2979.35; Fri, 15 May 2020 14:41:14 +0000 Received: from AM5EUR03FT028.eop-EUR03.prod.protection.outlook.com (2603:10a6:209:8e:cafe::b9) by AM6P193CA0071.outlook.office365.com (2603:10a6:209:8e::48) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3000.25 via Frontend Transport; Fri, 15 May 2020 14:41:14 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; sourceware.org; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; sourceware.org; dmarc=bestguesspass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by AM5EUR03FT028.mail.protection.outlook.com (10.152.16.118) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3000.19 via Frontend Transport; Fri, 15 May 2020 14:41:13 +0000 Received: ("Tessian outbound b3a67fbfbb1f:v54"); Fri, 15 May 2020 14:41:13 +0000 X-CheckRecipientChecked: true X-CR-MTA-CID: 30d3fe097f58b110 X-CR-MTA-TID: 64aa7808 Received: from eafecf9d9489.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id CCC52C13-7AAF-457F-AEBC-639360ABDCB5.1; Fri, 15 May 2020 14:41:08 +0000 Received: from EUR03-DB5-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id eafecf9d9489.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Fri, 15 May 2020 14:41:08 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=H1aIhm6doRWZwtN8/8HzWgn5xgtsvl1/lFrL1oZRMfu3MFKNKLO40gzi1Ijl/KZI2irgwTaVoV9mQAJhmZQ5wCXsI1UjGHw6c9oDB+yndyZ+l+4gq13763yzAZVWHreIxwPTWiA+yzShngXAY5gFzlXwWrccQzAvuyfvYqZd7FjTYzBVYYC8Ii6T83xbdOfq+2Yw9OEDfQXKmbWm2z+Aeyxd86mXvRll9mg/Eb823K+naOrWpJZjU3xIzELamF+Z82pWiezr3L1aYkp1JOwSTfOVhNjk6LEi6QtNBwA6adU+OyFV85RjkXSvkZamrh/Bio/3awVSx4ChQH5mJY66Qg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=GKQoBgg4c3SHOriWg6bR8RhDgZ/V6mC7nVSg1lU4o3Y=; b=VBwSDPh5QvoyGAXnSV8U/wJY6VhWuiVQKxvxFspgTQkmFNkZaS/K+scqCIHgcXLzK246HJrqFo29DkDHTqlWJ6J684PCb0DaVVwXSHyBU7DuX7GFYzn0OmZz9r+S+ehvTD52M4/T0S/f29B/6jMeZo+cAsH8rdv/wt3eRPVtCBqJHIekrNVoV+JMHk7AX3pE7hGALe+9s8KHHyHf73J3eZNZHFDXa6HHOnDxJTCkTzfaiPk0OY6r1E5HcIeRCsZwEKyC1YM+OaoP6RuN+VKEjq2n0RBJoHQZ/cPnesQGL9qPemzdTNf3qYHLAWIGndWuRqDUrm/4gDdl+pptweCg0g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=GKQoBgg4c3SHOriWg6bR8RhDgZ/V6mC7nVSg1lU4o3Y=; b=FycQLdX8hKUR3h3ThScYhAeHYCy5NPVcG6HWnWpGvA47WksrzzChl9GoehMuWEvKrYogL7TYHmfHDhb/onnVtfnKdA3NIdQsiw15uOg86WDWuA9o2QMiwd+EyuWFTDSfTPXiMng/99MdS2defzhAcIPGS+v+9Q6P9b9QI2WqwUw= Authentication-Results-Original: sourceware.org; dkim=none (message not signed) header.d=none;sourceware.org; dmarc=none action=none header.from=arm.com; Received: from AM6PR08MB3047.eurprd08.prod.outlook.com (2603:10a6:209:4c::23) by AM6PR08MB3528.eurprd08.prod.outlook.com (2603:10a6:20b:4b::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2979.34; Fri, 15 May 2020 14:41:07 +0000 Received: from AM6PR08MB3047.eurprd08.prod.outlook.com ([fe80::49fd:6ded:4da7:8862]) by AM6PR08MB3047.eurprd08.prod.outlook.com ([fe80::49fd:6ded:4da7:8862%7]) with mapi id 15.20.2979.033; Fri, 15 May 2020 14:41:07 +0000 From: Szabolcs Nagy To: libc-alpha@sourceware.org Subject: [PATCH v3 10/13] aarch64: configure check for pac-ret code generation Date: Fri, 15 May 2020 15:40:54 +0100 Message-Id: X-Mailer: git-send-email 2.17.1 In-Reply-To: References: X-ClientProxiedBy: LO2P265CA0309.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:a5::33) To AM6PR08MB3047.eurprd08.prod.outlook.com (2603:10a6:209:4c::23) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 Received: from localhost.localdomain (217.140.106.55) by LO2P265CA0309.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:a5::33) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3000.24 via Frontend Transport; Fri, 15 May 2020 14:41:07 +0000 X-Mailer: git-send-email 2.17.1 X-Originating-IP: [217.140.106.55] X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-HT: Tenant X-MS-Office365-Filtering-Correlation-Id: a588d87b-e607-4bbc-f145-08d7f8de047a X-MS-TrafficTypeDiagnostic: AM6PR08MB3528:|AM0PR08MB3058: X-Microsoft-Antispam-PRVS: x-checkrecipientrouted: true NoDisclaimer: true X-MS-Oob-TLC-OOBClassifiers: OLM:3276;OLM:3276; X-Forefront-PRVS: 04041A2886 X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: oCsEM6aeQxPSb3zV8KlRfXYiJcZWgONixOXQ2SWlrfs/3+NxbVaI8nR0RISKgTDDo9GekIu7jdvowHZIy2gUmxiaTXvTydHDWu9IzDOd7qhQOjUZ0tcOxYABQHw8H3ZDQ4uMr+U+tE6f2ZDBnjR0aiqfPFe/g34Cv8F9mSR7FZg478GscCUFXMpAsUQ/k7Zy+XdcZ7S2IISsHDbXHKHI5PeInFBy66YgGr/yFoXrXgVmGU4HzwyLsn0xSLEHQklfN4BbZ2j9Vu6ctXYyOjeSbIblH5jTgNyxR+TPPnL7jIlQpKotvZSiwzJ4FDW5HoIOBSIn+2JlwBg3DOiCn1tdLMg53GZhmql92faZXex8XSgMSztIY1ukZDkdUoxun+C8rCruRz4kKIwtv/XPxCSlng18PTP70b4AJsd1YsNCpBi8+kQrHJSTitGgHj5eP+5wDj+LK+RRWM1w0SGMYAk0yWou+gEEupNqCClMi7XRf9iZkCnkKckeM8e4ThKzKyljd0uYvw8nCr8HeRPVbTFeQuq6TffYFtfQ3Ea4EX6kYHE= X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:AM6PR08MB3047.eurprd08.prod.outlook.com; PTR:; CAT:NONE; SFTY:; SFS:(4636009)(136003)(376002)(39860400002)(346002)(366004)(396003)(86362001)(6506007)(69590400007)(52116002)(478600001)(316002)(6666004)(6916009)(6486002)(66556008)(44832011)(6512007)(5660300002)(2906002)(956004)(66476007)(8936002)(66946007)(36756003)(186003)(26005)(2616005)(8676002)(16526019)(136400200001); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData: VgvRR2QSzyawjw1q3MYXSUQ9SQUr5umwWp3fX14mjs0xPC0DX2vnsWDdHNu0erh2Zk6F2bPEQ3UxpyQebiPLRgk6+r37kKHX0oWWtbusJVY9FEu0AHrSXbJ8YL3asrqak6ynnspyyoglSxLAWKOYJSo1EVsiS3Kq6u6wD6XsPjFmbU2vSON4hAviT++YDGOXRnDDFPxCHAytZPcD3bU52wT+igzfubI558PPegduhyiPHtAsxZsVq2z08AaIABpkuuBO6MATpJejaZ1kgoQ1e6IOQzLEDw3BTlRcyaDiuf9bLi0fHFXfPKIoTIExZ2l14/NH2SpsGx6YVsNLIUg28BFXXoiWpMe/RTwI5Md+TFybd9Q/4MF8N5xlThAGSVkObf7JszUG1pnYhoQxxZQ7F/5xLfrkLpg11blXR7zRr3UrrnDY48Ic2E36SIK3FQY86GVug9/JQ3hGMhAoVMj2jkhGdZlFmvdoR9GVZe/bLqs= X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM6PR08MB3528 Original-Authentication-Results: sourceware.org; dkim=none (message not signed) header.d=none; sourceware.org; dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: AM5EUR03FT028.eop-EUR03.prod.protection.outlook.com X-Forefront-Antispam-Report: CIP:63.35.35.123; CTRY:IE; LANG:en; SCL:1; SRV:; IPV:CAL; SFV:NSPM; H:64aa7808-outbound-1.mta.getcheckrecipient.com; PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com; CAT:NONE; SFTY:; SFS:(4636009)(376002)(136003)(39860400002)(346002)(396003)(46966005)(956004)(2616005)(336012)(16526019)(82740400003)(316002)(6506007)(6486002)(81166007)(26005)(5660300002)(82310400002)(186003)(44832011)(36756003)(47076004)(2906002)(8936002)(36906005)(86362001)(6916009)(478600001)(356005)(8676002)(70206006)(6666004)(6512007)(70586007)(69590400007)(136400200001); DIR:OUT; SFP:1101; X-MS-Office365-Filtering-Correlation-Id-Prvs: ace79884-ad77-4de2-5a47-08d7f8de007c X-Forefront-PRVS: 04041A2886 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: /pQHtttTjSgDVkS1u30O0wigm2A9sVJnYXk5f/8EPrfHn4AGABWJcVUnxzsXR8s07WRg/jIlt7U5UxNUaed1ACKn9pI7ENihP5EC1q1DzIQw+iLcjpU9K2foj1SxEqyqCA2DgBaZQwtY+6S6yJtQsrs+yVN3m0a36HiPSsxecttNsfFaWxboUOx2sacevgZKOawPtrqcHd+rkF13vCRCfS2FxLrvUfx3kbJvOzPa52NgbomxQJ9xqeoVmUCdUAwerIKiVSvmrAsD1UG/lWZBVZYBRHm44ppX6Kun7JfocHQfK4I/w/SvFfrW9Tln+xhEJAlmqFM5DQhx8ITfFMV9gik4uPxQSKdtNDSR6IPYTPDq7qI9B7ia86nzQDCIIv+B8zAmwfEPW0iBS2qMmlwXBBdAy+8xQ2LPKvZEx96FgESJ898jdmV2I/RMnxEEb6+zbxqFAq45ohZlZhAOLuGgTLv/t1hAmnQuVUSvNGsJSNTPPEeL7MGNA/StskzIE3BkVbMLl0BZzUM7y9RgcaUeqtp1HKErhk09/03NLS16pX3gCZlFPdXh12xCHLkiBp4vOFcmw4MLEIl1bv8LhZ++mw== X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 May 2020 14:41:13.7189 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: a588d87b-e607-4bbc-f145-08d7f8de047a X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d; Ip=[63.35.35.123]; Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR08MB3058 X-Spam-Status: No, score=-19.5 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, GIT_PATCH_0, MSGID_FROM_MTA_HEADER, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H2, SPF_HELO_PASS, SPF_PASS, TXREP, UNPARSEABLE_RELAY autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libc-alpha-bounces@sourceware.org Sender: "Libc-alpha" Return address signing requires unwinder support, which is present in libgcc since >=gcc-7, however due to bugs the support may be broken in --- config.h.in | 3 +++ sysdeps/aarch64/configure | 39 ++++++++++++++++++++++++++++++++++++ sysdeps/aarch64/configure.ac | 21 +++++++++++++++++++ 3 files changed, 63 insertions(+) diff --git a/config.h.in b/config.h.in index 506b0c416c..f441470385 100644 --- a/config.h.in +++ b/config.h.in @@ -112,6 +112,9 @@ /* AArch64 BTI support enabled. */ #undef HAVE_AARCH64_BTI +/* AArch64 PAC-RET code generation is enabled. */ +#undef HAVE_AARCH64_PAC_RET + /* C-SKY ABI version. */ #undef CSKYABI diff --git a/sysdeps/aarch64/configure b/sysdeps/aarch64/configure index 70477a7fa5..5f1cdf5d9b 100644 --- a/sysdeps/aarch64/configure +++ b/sysdeps/aarch64/configure @@ -214,3 +214,42 @@ if test $libc_cv_aarch64_bti = yes; then $as_echo "#define HAVE_AARCH64_BTI 1" >>confdefs.h fi + +# Check if glibc is built with return address signing, i.e. +# if -mbranch-protection=pac-ret is on. We need this because +# pac-ret relies on unwinder support so it's not safe to use +# it in assembly code unconditionally, but there is no +# feature test macro for it in gcc. +{ $as_echo "$as_me:${as_lineno-$LINENO}: checking if pac-ret is enabled" >&5 +$as_echo_n "checking if pac-ret is enabled... " >&6; } +if ${libc_cv_aarch64_pac_ret+:} false; then : + $as_echo_n "(cached) " >&6 +else + cat > conftest.c <&5 + (eval $ac_try) 2>&5 + ac_status=$? + $as_echo "$as_me:${as_lineno-$LINENO}: \$? = $ac_status" >&5 + test $ac_status = 0; }; } \ + && { ac_try='grep -q -E '\''(hint( | )+25|paciasp)'\'' conftest.s' + { { eval echo "\"\$as_me\":${as_lineno-$LINENO}: \"$ac_try\""; } >&5 + (eval $ac_try) 2>&5 + ac_status=$? + $as_echo "$as_me:${as_lineno-$LINENO}: \$? = $ac_status" >&5 + test $ac_status = 0; }; } + then + libc_cv_aarch64_pac_ret=yes + fi + rm -rf conftest.* +fi +{ $as_echo "$as_me:${as_lineno-$LINENO}: result: $libc_cv_aarch64_pac_ret" >&5 +$as_echo "$libc_cv_aarch64_pac_ret" >&6; } +if test $libc_cv_aarch64_pac_ret = yes; then + $as_echo "#define HAVE_AARCH64_PAC_RET 1" >>confdefs.h + +fi diff --git a/sysdeps/aarch64/configure.ac b/sysdeps/aarch64/configure.ac index 798f494740..8248ecf2ed 100644 --- a/sysdeps/aarch64/configure.ac +++ b/sysdeps/aarch64/configure.ac @@ -39,3 +39,24 @@ EOF if test $libc_cv_aarch64_bti = yes; then AC_DEFINE(HAVE_AARCH64_BTI) fi + +# Check if glibc is built with return address signing, i.e. +# if -mbranch-protection=pac-ret is on. We need this because +# pac-ret relies on unwinder support so it's not safe to use +# it in assembly code unconditionally, but there is no +# feature test macro for it in gcc. +AC_CACHE_CHECK([if pac-ret is enabled], [libc_cv_aarch64_pac_ret], [dnl + cat > conftest.c <