diff mbox series

[nios2,committed] Delete sysdeps/unix/sysv/linux/nios2/kernel-features.h

Message ID d2e84142-6f97-59a9-c917-872365e6566b@mentor.com
State New
Headers show
Series [nios2,committed] Delete sysdeps/unix/sysv/linux/nios2/kernel-features.h | expand

Commit Message

Chung-Lin Tang May 4, 2020, 1:43 p.m. UTC
In commit 06436acf819d9e6ada7be3ca977d5c0a23d3f138, a kernel-features.h
file for nios2 was created to undef __ASSUME_SYSVIPC_DEFAULT_IPC_64,
which was wrong for Nios II.

This patch removes the file again. Fixed on master and 2.31, credits to Paul Carroll.

Thanks,
Chung-Lin
From 38c67888183db1b6ac21f2f9681b8a384987dfe8 Mon Sep 17 00:00:00 2001
From: Chung-Lin Tang <cltang@codesourcery.com>
Date: Mon, 4 May 2020 20:23:25 +0800
Subject: [PATCH] nios2: delete sysdeps/unix/sysv/linux/nios2/kernel-features.h

Commit 06436acf819d9e6ada7be3ca977d5c0a23d3f138	created a kernel-features.h
file with '#undef __ASSUME_SYSVIPC_DEFAULT_IPC_64', which is wrong for Nios II.
Deleting the header.
---
 .../unix/sysv/linux/nios2/kernel-features.h   | 22 -------------------
 1 file changed, 22 deletions(-)
 delete mode 100644 sysdeps/unix/sysv/linux/nios2/kernel-features.h

Comments

Adhemerval Zanella May 4, 2020, 1:52 p.m. UTC | #1
On 04/05/2020 10:43, Chung-Lin Tang wrote:
> In commit 06436acf819d9e6ada7be3ca977d5c0a23d3f138, a kernel-features.h
> file for nios2 was created to undef __ASSUME_SYSVIPC_DEFAULT_IPC_64,
> which was wrong for Nios II.
> 
> This patch removes the file again. Fixed on master and 2.31, credits to Paul Carroll.
> 
> Thanks,
> Chung-Lin

LGTM, thanks.

As a side note, is there an easy way to get a qemu system for nios2 to check
for such regressions (an system emulation would be better to rule out qemu
user issue)?
Chung-Lin Tang May 5, 2020, 10:20 a.m. UTC | #2
On 2020/5/4 9:52 PM, Adhemerval Zanella via Libc-alpha wrote:
> 
> 
> On 04/05/2020 10:43, Chung-Lin Tang wrote:
>> In commit 06436acf819d9e6ada7be3ca977d5c0a23d3f138, a kernel-features.h
>> file for nios2 was created to undef __ASSUME_SYSVIPC_DEFAULT_IPC_64,
>> which was wrong for Nios II.
>>
>> This patch removes the file again. Fixed on master and 2.31, credits to Paul Carroll.
>>
>> Thanks,
>> Chung-Lin
> 
> LGTM, thanks.
> 
> As a side note, is there an easy way to get a qemu system for nios2 to check
> for such regressions (an system emulation would be better to rule out qemu
> user issue)?
> 

We've been doing testing using hardware so far. A QEMU setup is something that's nice
to have, but still TBD here.

Thanks,
Chung-Lin
diff mbox series

Patch

diff --git a/sysdeps/unix/sysv/linux/nios2/kernel-features.h b/sysdeps/unix/sysv/linux/nios2/kernel-features.h
deleted file mode 100644
index d68d114981..0000000000
--- a/sysdeps/unix/sysv/linux/nios2/kernel-features.h
+++ /dev/null
@@ -1,22 +0,0 @@ 
-/* Set flags signalling availability of kernel features based on given
-   kernel version number.  NIOS2 version.
-   Copyright (C) 2019-2020 Free Software Foundation, Inc.
-   This file is part of the GNU C Library.
-
-   The GNU C Library is free software; you can redistribute it and/or
-   modify it under the terms of the GNU Lesser General Public
-   License as published by the Free Software Foundation; either
-   version 2.1 of the License, or (at your option) any later version.
-
-   The GNU C Library is distributed in the hope that it will be useful,
-   but WITHOUT ANY WARRANTY; without even the implied warranty of
-   MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
-   Lesser General Public License for more details.
-
-   You should have received a copy of the GNU Lesser General Public
-   License along with the GNU C Library; if not, see
-   <https://www.gnu.org/licenses/>.  */
-
-#include_next <kernel-features.h>
-
-#undef __ASSUME_SYSVIPC_DEFAULT_IPC_64