diff mbox

Bug 20686: Add el_GR@euro/ISO-8859-7 to SUPPORTED.

Message ID d291e93a-2bde-f66d-3e87-5b1988147a6f@redhat.com
State Committed
Headers show

Commit Message

Carlos O'Donell Oct. 13, 2016, 1:44 p.m. UTC
Despite the fact that el_GR is ISO-8859-7:2003 which contains the euro 
symobl, it is not possible to know this apriori to selecting the el_GR 
locale. Therefore you don't know if el_GR can possibly have the 2003 
ammendments which include the euro symbol. This is resolved by creating
an el_GR@euro locale similar to all the other @euro locales for non-UTF8
charsets. The el_GR@euro locale already exists but is not in SUPPORTED.

In this particular case we've Red Hat has had user demand for creating
an el_GR@euro locale for the ISO-8859-7 charset used in Greece.

Therefore I'd propose we move el_GR@euro to SUPPORTED upstream and
maintain it as an official way to select ISO-8859-7:2003.

Another alternative, though more complex, would be to try work out a way
to have nl_langinfo return ISO-8859-7:2003 for a CODESET, such that a user
could setlocale for el_GR.iso88597 and then use nl_langinfo to determine
if the codeset was new enough. This has the added complexity that you have
to load and check the locale, rather than just expecting the new charset
for el_GR@euro.

Tested by installing and using the locale to print the euro symbol.

If nobody objects I'll check this in late next week.

2016-10-13  Carlos O'Donell  <carlos@redhat.com>

	* localedata/SUPPORTED: Add el_GR@euro/ISO-8859-7.

--

Comments

Florian Weimer Nov. 4, 2016, 3:06 p.m. UTC | #1
On 10/13/2016 03:44 PM, Carlos O'Donell wrote:
> 2016-10-13  Carlos O'Donell  <carlos@redhat.com>
>
> 	* localedata/SUPPORTED: Add el_GR@euro/ISO-8859-7.

Looks good to me.

Thanks,
Florian
Carlos O'Donell May 3, 2017, 7:39 p.m. UTC | #2
On 11/04/2016 11:06 AM, Florian Weimer wrote:
> On 10/13/2016 03:44 PM, Carlos O'Donell wrote:
>> 2016-10-13  Carlos O'Donell  <carlos@redhat.com>
>>
>>     * localedata/SUPPORTED: Add el_GR@euro/ISO-8859-7.
> 
> Looks good to me.

Commited.

Tested again with `make localedata/install-locales` and the
resulting locale inspected and used.
diff mbox

Patch

diff --git a/localedata/SUPPORTED b/localedata/SUPPORTED
index 843ce78..4ade055 100644
--- a/localedata/SUPPORTED
+++ b/localedata/SUPPORTED
@@ -118,6 +118,7 @@  dv_MV/UTF-8 \
 dz_BT/UTF-8 \
 el_GR.UTF-8/UTF-8 \
 el_GR/ISO-8859-7 \
+el_GR@euro/ISO-8859-7 \
 el_CY.UTF-8/UTF-8 \
 el_CY/ISO-8859-7 \
 en_AG/UTF-8 \