From patchwork Sat Jun 22 04:37:52 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Alistair Francis X-Patchwork-Id: 33274 Received: (qmail 95735 invoked by alias); 22 Jun 2019 04:47:04 -0000 Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libc-alpha-owner@sourceware.org Delivered-To: mailing list libc-alpha@sourceware.org Received: (qmail 95676 invoked by uid 89); 22 Jun 2019 04:47:03 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-25.9 required=5.0 tests=AWL, BAYES_00, GIT_PATCH_0, GIT_PATCH_1, GIT_PATCH_2, GIT_PATCH_3, KAM_NUMSUBJECT, KAM_SHORT autolearn=ham version=3.3.1 spammy=HX-Languages-Length:3399 X-HELO: esa5.hgst.iphmx.com DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=wdc.com; i=@wdc.com; q=dns/txt; s=dkim.wdc.com; t=1561178822; x=1592714822; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=3PnivESkf7iIxSpbFv92r6NdD4etaDIPF6hFhs/6o5Q=; b=lq0Y1njogLtW2Zttq5rBelzDEo/6mfGMRSK/w89wgbr4JXTvFDWiQnJO +i78BsxX/oNKqN0dFcAyGRfwAK440Fm/LMkcqbSGg6DgR+M63gbu3U3R1 eTRFd2OyMT6UAYIX75ZHlToq+BuL4mheEjJqUA3vc052IzZX3u9bHbPpb gueBILFBPeY3W3nlQCLcxSoht2IYJliBN8lrPfiDYnox/eZgGxCwpRG5W NR5RPs0YXLAbj22baGvFFYg3Tyz5U4O2i3utz+TWPxJvIxYA9eejCGIOV /e/B76QU5ler+G5ugY/J+MHpgpbgj0c3NqaptcvJrOoLBdDTfmdSvg/7j w==; X-URL-LookUp-ScanningError: 1 IronPort-SDR: 2W8EeuhgSVMJxX9IWGzY1VhpRNTcmsvBIrQTojAHDrmoDxleH+Gd0HtZhqphhBGG2EfVpf9tqw hK3rUS5OEnmY4JlKPVPxmsSp8lXJ8NI8TEIdtfxC3EBN9cTpgotqFIJXaDUZVE0yrkzYhQzot9 ISLj1MKlq2MDgLNQ7F1ctnY1bNcXmCUNs5H5x5fzs7T6IAVnFfqvvBxLV3n+Z7hnuPY/sbSCqD fSdewWjr9mIig3vDZhm5eksxDwjqrrFX46wkgAkUZOnbnEou3MNYyhBiYUX+cruJbmQV0b4MA8 zU4WfpqWyZCk3aoEpTRUPXm9 IronPort-SDR: 5dkXxgP0m1b+mg0kDJGddlm08lYuE2jxN5tB3a5fLoT77BXIXpMSNCW85LSlXF/RdsnYZOnfyA TWuaBRo4SRthDfwD3NsvOtC4hMymsXFu20IEdFrFTjRpwqaJPiQvy1ZPnwA6chJLqJgYpwAMpx wuYFUuUlyqAMZGELuKXfXSNiCKDeILW1bQw7bA62dZ79WnLa8I00hp+6N22NqxJk1poZpddiGr mhCNnPnAJnzbFgoofMOPll7DtuCo+Ss/ZjqJFgXpyVsCyEBEC6VUEqIPZPKLtNJ0Jkav1aQ2uG 9Yc= From: Alistair Francis To: libc-alpha@sourceware.org Cc: alistair.francis@wdc.com, alistair23@gmail.com Subject: [RFC v1 15/16] RISC-V: Fix llrint and llround missing exceptions on RV32 Date: Fri, 21 Jun 2019 21:37:52 -0700 Message-Id: In-Reply-To: References: MIME-Version: 1.0 From: Zong Li Similar to the recent fix for MIPS, ARM and S/390, RV32 is missing correct exception on overflow from llrint and llround functions because cast from floating-point types to long long do not result in correct exceptions on overflow. 2018-11-29 Zong Li * sysdeps/riscv/rv32/fix-fp-int-convert-overflow.h: New file. --- ChangeLog | 10 +++++ .../riscv/rv32/fix-fp-int-convert-overflow.h | 38 +++++++++++++++++++ 2 files changed, 48 insertions(+) create mode 100644 sysdeps/riscv/rv32/fix-fp-int-convert-overflow.h diff --git a/ChangeLog b/ChangeLog index 770dda5373..61984154e0 100644 --- a/ChangeLog +++ b/ChangeLog @@ -92,6 +92,16 @@ * sysdeps/unix/sysv/linux/riscv/configure.ac: Likewise. * sysdeps/unix/sysv/linux/riscv/shlib-versions: Likewise. * sysdeps/riscv/preconfigure: Likewise. + * sysdeps/riscv/rv32/Implies-after: New file. + * sysdeps/riscv/rv32/rvd/Implies: Likewise. + * sysdeps/riscv/rv32/rvf/Implies: Likewise. + * sysdeps/unix/sysv/linux/riscv/rv32/Implies: Likewise. + * sysdeps/unix/sysv/linux/riscv/Makefile: Support rv32. + * sysdeps/unix/sysv/linux/riscv/configure: Likewise. + * sysdeps/unix/sysv/linux/riscv/configure.ac: Likewise. + * sysdeps/unix/sysv/linux/riscv/shlib-versions: Likewise. + * sysdeps/riscv/preconfigure: Likewise. + * sysdeps/riscv/rv32/fix-fp-int-convert-overflow.h: New file. 2019-06-20 Dmitry V. Levin Florian Weimer diff --git a/sysdeps/riscv/rv32/fix-fp-int-convert-overflow.h b/sysdeps/riscv/rv32/fix-fp-int-convert-overflow.h new file mode 100644 index 0000000000..6b34a8415e --- /dev/null +++ b/sysdeps/riscv/rv32/fix-fp-int-convert-overflow.h @@ -0,0 +1,38 @@ +/* Fix for conversion of floating point to integer overflow. ARM version. + Copyright (C) 2015-2018 Free Software Foundation, Inc. + This file is part of the GNU C Library. + + The GNU C Library is free software; you can redistribute it and/or + modify it under the terms of the GNU Lesser General Public + License as published by the Free Software Foundation; either + version 2.1 of the License, or (at your option) any later version. + + The GNU C Library is distributed in the hope that it will be useful, + but WITHOUT ANY WARRANTY; without even the implied warranty of + MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU + Lesser General Public License for more details. + + You should have received a copy of the GNU Lesser General Public + License along with the GNU C Library; if not, see + . */ + +#ifndef FIX_FP_INT_CONVERT_OVERFLOW_H +#define FIX_FP_INT_CONVERT_OVERFLOW_H 1 + +/* As of GCC 5, the generic libgcc2.c conversions from floating point + to long long may not raise the correct exceptions on overflow (and + may raise spurious "inexact" exceptions even in non-overflow cases, + see ). */ +#define FIX_FLT_LONG_CONVERT_OVERFLOW 0 +#define FIX_FLT_LLONG_CONVERT_OVERFLOW 1 + +#define FIX_DBL_LONG_CONVERT_OVERFLOW 0 +#define FIX_DBL_LLONG_CONVERT_OVERFLOW 1 + +#define FIX_LDBL_LONG_CONVERT_OVERFLOW 0 +#define FIX_LDBL_LLONG_CONVERT_OVERFLOW 0 + +#define FIX_FLT128_LONG_CONVERT_OVERFLOW 0 +#define FIX_FLT128_LLONG_CONVERT_OVERFLOW 0 + +#endif /* fix-fp-int-convert-overflow.h */