[5/6] ldbl-128ibm-compat: Provide ieee128 symbols to narrow functions

Message ID c9343ff90ac419c23914592dccbe9a8d59d72312.1580757509.git.murphyp@linux.vnet.ibm.com
State Committed
Headers

Commit Message

Paul E. Murphy Feb. 3, 2020, 9:10 p.m. UTC
  From: Tulio Magno Quites Machado Filho <tuliom@linux.ibm.com>

Move the narrow math aliasing macros into a new sysdep header file
math-narrow-alias-float128.h.  Then, provide an override header
to supply the necessary changes to supply the *ieee128 aliases of
these symbols.

This adds ieee128 aliases for faddl, fdivl, fmull, fsubl, daddl, ddivl,
dmull, dsubl.
---
 math/math-narrow.h                            | 15 +-------
 sysdeps/generic/math-narrow-alias-float128.h  | 32 +++++++++++++++++
 sysdeps/ieee754/ldbl-128ibm-compat/Versions   |  8 +++++
 .../math-narrow-alias-float128.h              | 34 +++++++++++++++++++
 4 files changed, 75 insertions(+), 14 deletions(-)
 create mode 100644 sysdeps/generic/math-narrow-alias-float128.h
 create mode 100644 sysdeps/ieee754/ldbl-128ibm-compat/math-narrow-alias-float128.h
  

Comments

Paul E Murphy Feb. 18, 2020, 10:23 p.m. UTC | #1
Ping.  I will commit this Friday with Patch 2 hearing no requests for 
improvement or objections.

On 2/3/20 3:10 PM, Paul E. Murphy wrote:
> From: Tulio Magno Quites Machado Filho <tuliom@linux.ibm.com>
> 
> Move the narrow math aliasing macros into a new sysdep header file
> math-narrow-alias-float128.h.  Then, provide an override header
> to supply the necessary changes to supply the *ieee128 aliases of
> these symbols.
> 
> This adds ieee128 aliases for faddl, fdivl, fmull, fsubl, daddl, ddivl,
> dmull, dsubl.
> ---
>   math/math-narrow.h                            | 15 +-------
>   sysdeps/generic/math-narrow-alias-float128.h  | 32 +++++++++++++++++
>   sysdeps/ieee754/ldbl-128ibm-compat/Versions   |  8 +++++
>   .../math-narrow-alias-float128.h              | 34 +++++++++++++++++++
>   4 files changed, 75 insertions(+), 14 deletions(-)
>   create mode 100644 sysdeps/generic/math-narrow-alias-float128.h
>   create mode 100644 sysdeps/ieee754/ldbl-128ibm-compat/math-narrow-alias-float128.h
>
  
Paul E Murphy Feb. 21, 2020, 2:29 p.m. UTC | #2
Pushed after verification against build-many-glibcs.py.

On 2/18/20 4:23 PM, Paul E Murphy wrote:
> Ping.  I will commit this Friday with Patch 2 hearing no requests for 
> improvement or objections.
> 
> On 2/3/20 3:10 PM, Paul E. Murphy wrote:
>> From: Tulio Magno Quites Machado Filho <tuliom@linux.ibm.com>
>>
>> Move the narrow math aliasing macros into a new sysdep header file
>> math-narrow-alias-float128.h.  Then, provide an override header
>> to supply the necessary changes to supply the *ieee128 aliases of
>> these symbols.
>>
>> This adds ieee128 aliases for faddl, fdivl, fmull, fsubl, daddl, ddivl,
>> dmull, dsubl.
>> ---
>>   math/math-narrow.h                            | 15 +-------
>>   sysdeps/generic/math-narrow-alias-float128.h  | 32 +++++++++++++++++
>>   sysdeps/ieee754/ldbl-128ibm-compat/Versions   |  8 +++++
>>   .../math-narrow-alias-float128.h              | 34 +++++++++++++++++++
>>   4 files changed, 75 insertions(+), 14 deletions(-)
>>   create mode 100644 sysdeps/generic/math-narrow-alias-float128.h
>>   create mode 100644 
>> sysdeps/ieee754/ldbl-128ibm-compat/math-narrow-alias-float128.h
>>
  

Patch

diff --git a/math/math-narrow.h b/math/math-narrow.h
index ec22913710..d8092c287e 100644
--- a/math/math-narrow.h
+++ b/math/math-narrow.h
@@ -352,19 +352,6 @@ 
   weak_alias (__f64 ## func ## f128, f64 ## func ## f128)	\
   weak_alias (__f64 ## func ## f128, f32x ## func ## f128)
 
-#if __HAVE_FLOAT64X_LONG_DOUBLE
-# define libm_alias_float32_float128(func)	\
-  libm_alias_float32_float128_main (func)
-# define libm_alias_float64_float128(func)	\
-  libm_alias_float64_float128_main (func)
-#else
-# define libm_alias_float32_float128(func)			\
-  libm_alias_float32_float128_main (func)			\
-  weak_alias (__f32 ## func ## f128, f32 ## func ## f64x)
-# define libm_alias_float64_float128(func)			\
-  libm_alias_float64_float128_main (func)			\
-  weak_alias (__f64 ## func ## f128, f64 ## func ## f64x)	\
-  weak_alias (__f64 ## func ## f128, f32x ## func ## f64x)
-#endif
+#include <math-narrow-alias-float128.h>
 
 #endif /* math-narrow.h.  */
diff --git a/sysdeps/generic/math-narrow-alias-float128.h b/sysdeps/generic/math-narrow-alias-float128.h
new file mode 100644
index 0000000000..4788708c78
--- /dev/null
+++ b/sysdeps/generic/math-narrow-alias-float128.h
@@ -0,0 +1,32 @@ 
+/* Helper macros for functions returning a narrower type.  F128-specific.
+   Copyright (C) 2018 Free Software Foundation, Inc.
+   This file is part of the GNU C Library.
+
+   The GNU C Library is free software; you can redistribute it and/or
+   modify it under the terms of the GNU Lesser General Public
+   License as published by the Free Software Foundation; either
+   version 2.1 of the License, or (at your option) any later version.
+
+   The GNU C Library is distributed in the hope that it will be useful,
+   but WITHOUT ANY WARRANTY; without even the implied warranty of
+   MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
+   Lesser General Public License for more details.
+
+   You should have received a copy of the GNU Lesser General Public
+   License along with the GNU C Library; if not, see
+   <http://www.gnu.org/licenses/>.  */
+
+#if __HAVE_FLOAT64X_LONG_DOUBLE
+# define libm_alias_float32_float128(func)	\
+  libm_alias_float32_float128_main (func)
+# define libm_alias_float64_float128(func)	\
+  libm_alias_float64_float128_main (func)
+#else
+# define libm_alias_float32_float128(func)			\
+  libm_alias_float32_float128_main (func)			\
+  weak_alias (__f32 ## func ## f128, f32 ## func ## f64x)
+# define libm_alias_float64_float128(func)			\
+  libm_alias_float64_float128_main (func)			\
+  weak_alias (__f64 ## func ## f128, f64 ## func ## f64x)	\
+  weak_alias (__f64 ## func ## f128, f32x ## func ## f64x)
+#endif
diff --git a/sysdeps/ieee754/ldbl-128ibm-compat/Versions b/sysdeps/ieee754/ldbl-128ibm-compat/Versions
index b4609c99f7..83a0a36e62 100644
--- a/sysdeps/ieee754/ldbl-128ibm-compat/Versions
+++ b/sysdeps/ieee754/ldbl-128ibm-compat/Versions
@@ -47,6 +47,14 @@  libm {
     __exp2ieee128;
     __expieee128;
     __expm1ieee128;
+    __f32addieee128;
+    __f32divieee128;
+    __f32mulieee128;
+    __f32subieee128;
+    __f64addieee128;
+    __f64divieee128;
+    __f64mulieee128;
+    __f64subieee128;
     __fabsieee128;
     __fdimieee128;
     __floorieee128;
diff --git a/sysdeps/ieee754/ldbl-128ibm-compat/math-narrow-alias-float128.h b/sysdeps/ieee754/ldbl-128ibm-compat/math-narrow-alias-float128.h
new file mode 100644
index 0000000000..5353b539d7
--- /dev/null
+++ b/sysdeps/ieee754/ldbl-128ibm-compat/math-narrow-alias-float128.h
@@ -0,0 +1,34 @@ 
+/* Helper macros for functions returning a narrower type.  F128-specific.
+   Copyright (C) 2018 Free Software Foundation, Inc.
+   This file is part of the GNU C Library.
+
+   The GNU C Library is free software; you can redistribute it and/or
+   modify it under the terms of the GNU Lesser General Public
+   License as published by the Free Software Foundation; either
+   version 2.1 of the License, or (at your option) any later version.
+
+   The GNU C Library is distributed in the hope that it will be useful,
+   but WITHOUT ANY WARRANTY; without even the implied warranty of
+   MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
+   Lesser General Public License for more details.
+
+   You should have received a copy of the GNU Lesser General Public
+   License along with the GNU C Library; if not, see
+   <http://www.gnu.org/licenses/>.  */
+
+#if __HAVE_FLOAT64X_LONG_DOUBLE
+# define libm_alias_float32_float128(func)	\
+  libm_alias_float32_float128_main (func)
+# define libm_alias_float64_float128(func)	\
+  libm_alias_float64_float128_main (func)
+#else
+# define libm_alias_float32_float128(func)				\
+  libm_alias_float32_float128_main (func)				\
+  weak_alias (__f32 ## func ## f128, f32 ## func ## f64x)		\
+  weak_alias (__f32 ## func ## f128, __ ## f32 ## func ## ieee128)
+# define libm_alias_float64_float128(func)				\
+  libm_alias_float64_float128_main (func)				\
+  weak_alias (__f64 ## func ## f128, f64 ## func ## f64x)		\
+  weak_alias (__f64 ## func ## f128, f32x ## func ## f64x)		\
+  weak_alias (__f64 ## func ## f128, __ ## f64 ## func ## ieee128)
+#endif