[v3,4/6] powerpc64le: bump binutils version requirement to >= 2.26
Commit Message
This is a small step up from 2.25 which brings in support for
rewriting the .gnu.attributes section of libc/libm.so.
Reviewed-by: Tulio Magno Quites Machado Filho <tuliom@linux.ibm.com>
---
INSTALL | 4 ++
manual/install.texi | 4 ++
sysdeps/powerpc/powerpc64/le/configure | 65 +++++++++++++++++++++++
sysdeps/powerpc/powerpc64/le/configure.ac | 6 +++
4 files changed, 79 insertions(+)
Comments
* Paul E. Murphy via Libc-alpha:
> diff --git a/manual/install.texi b/manual/install.texi
> index 66de8ea59b..acbcc8c091 100644
> --- a/manual/install.texi
> +++ b/manual/install.texi
> @@ -533,6 +533,10 @@ No other assembler or linker has the necessary functionality at the
> moment. As of release time, GNU @code{binutils} 2.32 is the newest
> verified to work to build @theglibc{}.
>
> +For PowerPC 64-bits little-endian (powerpc64le), binutils is required
> +to support the @option{--update-section}. This option requires binutils
> +2.26 or newer.
I think it's @command{objcopy} that needs to support the option,
right? So perhaps replace the first “binutils” with that?
@@ -495,6 +495,10 @@ build the GNU C Library:
moment. As of release time, GNU 'binutils' 2.32 is the newest
verified to work to build the GNU C Library.
+ For PowerPC 64-bits little-endian (powerpc64le), binutils is
+ required to support the '--update-section'. This option requires
+ binutils 2.26 or newer.
+
* GNU 'texinfo' 4.7 or later
To correctly translate and install the Texinfo documentation you
@@ -533,6 +533,10 @@ No other assembler or linker has the necessary functionality at the
moment. As of release time, GNU @code{binutils} 2.32 is the newest
verified to work to build @theglibc{}.
+For PowerPC 64-bits little-endian (powerpc64le), binutils is required
+to support the @option{--update-section}. This option requires binutils
+2.26 or newer.
+
@item
GNU @code{texinfo} 4.7 or later
@@ -90,5 +90,70 @@ if test "$libc_cv_compiler_powerpc64le_ice" != "yes"; then :
critic_missing="$critic_missing __builtin_signbit is broken. GCC 7.4 or newer is required to resolve (BZ 83862)."
fi
+# Binutils (objcopy) 2.26 or newer required to support the --update-section
+# feature for fixing up .gnu.attribute section with IEEE ldbl.
+for ac_prog in $OBJCOPY
+do
+ # Extract the first word of "$ac_prog", so it can be a program name with args.
+set dummy $ac_prog; ac_word=$2
+{ $as_echo "$as_me:${as_lineno-$LINENO}: checking for $ac_word" >&5
+$as_echo_n "checking for $ac_word... " >&6; }
+if ${ac_cv_prog_OBJCOPY+:} false; then :
+ $as_echo_n "(cached) " >&6
+else
+ if test -n "$OBJCOPY"; then
+ ac_cv_prog_OBJCOPY="$OBJCOPY" # Let the user override the test.
+else
+as_save_IFS=$IFS; IFS=$PATH_SEPARATOR
+for as_dir in $PATH
+do
+ IFS=$as_save_IFS
+ test -z "$as_dir" && as_dir=.
+ for ac_exec_ext in '' $ac_executable_extensions; do
+ if as_fn_executable_p "$as_dir/$ac_word$ac_exec_ext"; then
+ ac_cv_prog_OBJCOPY="$ac_prog"
+ $as_echo "$as_me:${as_lineno-$LINENO}: found $as_dir/$ac_word$ac_exec_ext" >&5
+ break 2
+ fi
+done
+ done
+IFS=$as_save_IFS
+
+fi
+fi
+OBJCOPY=$ac_cv_prog_OBJCOPY
+if test -n "$OBJCOPY"; then
+ { $as_echo "$as_me:${as_lineno-$LINENO}: result: $OBJCOPY" >&5
+$as_echo "$OBJCOPY" >&6; }
+else
+ { $as_echo "$as_me:${as_lineno-$LINENO}: result: no" >&5
+$as_echo "no" >&6; }
+fi
+
+
+ test -n "$OBJCOPY" && break
+done
+
+if test -z "$OBJCOPY"; then
+ ac_verc_fail=yes
+else
+ # Found it, now check the version.
+ { $as_echo "$as_me:${as_lineno-$LINENO}: checking version of $OBJCOPY" >&5
+$as_echo_n "checking version of $OBJCOPY... " >&6; }
+ ac_prog_version=`$OBJCOPY --version 2>&1 | sed -n 's/^.*GNU objcopy.* \([0-9]*\.[0-9.]*\).*$/\1/p'`
+ case $ac_prog_version in
+ '') ac_prog_version="v. ?.??, bad"; ac_verc_fail=yes;;
+ 2.1[0-9][0-9]*|2.2[6-9]*|2.[3-9][0-9]*|[3-9].*|[1-9][0-9]*)
+ ac_prog_version="$ac_prog_version, ok"; ac_verc_fail=no;;
+ *) ac_prog_version="$ac_prog_version, bad"; ac_verc_fail=yes;;
+
+ esac
+ { $as_echo "$as_me:${as_lineno-$LINENO}: result: $ac_prog_version" >&5
+$as_echo "$ac_prog_version" >&6; }
+fi
+if test $ac_verc_fail = yes; then
+ AS=: critic_missing="$critic_missing objcopy >= 2.26 is required on powerpc64le"
+fi
+
test -n "$critic_missing" && as_fn_error $? "*** $critic_missing" "$LINENO" 5
@@ -51,5 +51,11 @@ CFLAGS="$save_CFLAGS"])
AS_IF([test "$libc_cv_compiler_powerpc64le_ice" != "yes"],
[critic_missing="$critic_missing __builtin_signbit is broken. GCC 7.4 or newer is required to resolve (BZ 83862)."])
+# Binutils (objcopy) 2.26 or newer required to support the --update-section
+# feature for fixing up .gnu.attribute section with IEEE ldbl.
+AC_CHECK_PROG_VER(OBJCOPY, $OBJCOPY, --version,
+ [GNU objcopy.* \([0-9]*\.[0-9.]*\)],
+ [2.1[0-9][0-9]*|2.2[6-9]*|2.[3-9][0-9]*|[3-9].*|[1-9][0-9]*],
+ AS=: critic_missing="$critic_missing objcopy >= 2.26 is required on powerpc64le")
test -n "$critic_missing" && AC_MSG_ERROR([*** $critic_missing])