[Makefile] Exit if provided an incorrect argument
Commit Message
On 15/01/19 10:03, Florian Weimer wrote:
> * Matthew Malcomson:
>
>> --- a/Makefile
>> +++ b/Makefile
>> @@ -148,6 +148,7 @@ while test $$# -gt 0 ; do
>> ;;
>> --*)
>> usage
>> + exit 1
>> ;;
>> *)
>> break
> I think you should add the exit to the usage function.
>
> Thanks,
> Florian
Makes sense -- thanks!
Fixed patch attached.
ChangeLog:
2019-01-15 Matthew Malcomson <matthew.malcomson@arm.com>
* Makefile (testrun.sh): Exit if provided incorrect arg.
--- Patch Inlined for ease of reply ----
Comments
* Matthew Malcomson:
> On 15/01/19 10:03, Florian Weimer wrote:
>> * Matthew Malcomson:
>>
>>> --- a/Makefile
>>> +++ b/Makefile
>>> @@ -148,6 +148,7 @@ while test $$# -gt 0 ; do
>>> ;;
>>> --*)
>>> usage
>>> + exit 1
>>> ;;
>>> *)
>>> break
>> I think you should add the exit to the usage function.
>>
>> Thanks,
>> Florian
>
> Makes sense -- thanks!
> Fixed patch attached.
Thanks, pushed.
Florian
@@ -137,6 +137,7 @@ GCONV_PATH="$${builddir}/iconvdata"
usage () {
echo "usage: $$0 [--tool=strace] PROGRAM [ARGUMENTS...]" 2>&1
echo " $$0 --tool=valgrind PROGRAM [ARGUMENTS...]" 2>&1
+ exit 1
}
toolname=default