Message ID | bd7ec4292a698ad867c64673c2f17049e2fb070b.1601569371.git.fweimer@redhat.com |
---|---|
State | Committed |
Headers |
Return-Path: <libc-alpha-bounces@sourceware.org> X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id AB038398B846; Thu, 1 Oct 2020 16:32:14 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org AB038398B846 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1601569934; bh=aqzr1mKdrgHImGcyjXFPua6C/qHlAJTJrusgls3R0eM=; h=To:Subject:In-Reply-To:References:Date:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To: From; b=Lelb7rPpnFkkSHs6SZUZmzyxvILEWUHUm/7eCop0iIFP7zjBv6fB+jpF9QHpNvuus JRhrmNLfgJTdVEv/L8Az6LpelpXJGuGXsXyrnt4tPSShwZW8Xtt2hcQnzHkjt4xGdD EquT1OoL81VunPksS+cITtB0/S7X//uqxJLSQL18= X-Original-To: libc-alpha@sourceware.org Delivered-To: libc-alpha@sourceware.org Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by sourceware.org (Postfix) with ESMTP id 38EBE398B837 for <libc-alpha@sourceware.org>; Thu, 1 Oct 2020 16:32:12 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 38EBE398B837 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-321-aNQtV2hdOF-DxWhjCPCopg-1; Thu, 01 Oct 2020 12:31:56 -0400 X-MC-Unique: aNQtV2hdOF-DxWhjCPCopg-1 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id B653E393BA for <libc-alpha@sourceware.org>; Thu, 1 Oct 2020 16:31:44 +0000 (UTC) Received: from oldenburg2.str.redhat.com (ovpn-114-84.ams2.redhat.com [10.36.114.84]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 347115D9DD for <libc-alpha@sourceware.org>; Thu, 1 Oct 2020 16:31:44 +0000 (UTC) To: libc-alpha@sourceware.org Subject: [PATCH 02/28] elf: Implement __rtld_malloc_is_full In-Reply-To: <cover.1601569371.git.fweimer@redhat.com> References: <cover.1601569371.git.fweimer@redhat.com> Message-Id: <bd7ec4292a698ad867c64673c2f17049e2fb070b.1601569371.git.fweimer@redhat.com> Date: Thu, 01 Oct 2020 18:31:42 +0200 User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain X-Spam-Status: No, score=-10.7 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H5, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_PASS, TXREP, URIBL_BLACK autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list <libc-alpha.sourceware.org> List-Unsubscribe: <https://sourceware.org/mailman/options/libc-alpha>, <mailto:libc-alpha-request@sourceware.org?subject=unsubscribe> List-Archive: <https://sourceware.org/pipermail/libc-alpha/> List-Post: <mailto:libc-alpha@sourceware.org> List-Help: <mailto:libc-alpha-request@sourceware.org?subject=help> List-Subscribe: <https://sourceware.org/mailman/listinfo/libc-alpha>, <mailto:libc-alpha-request@sourceware.org?subject=subscribe> From: Florian Weimer via Libc-alpha <libc-alpha@sourceware.org> Reply-To: Florian Weimer <fweimer@redhat.com> Errors-To: libc-alpha-bounces@sourceware.org Sender: "Libc-alpha" <libc-alpha-bounces@sourceware.org> |
Series |
glibc-hwcaps support
|
|
Commit Message
Florian Weimer
Oct. 1, 2020, 4:31 p.m. UTC
In some cases, it is difficult to determine the kind of malloc based on the execution context, so a function to determine that is helpful. --- elf/dl-minimal.c | 8 ++++++++ include/rtld-malloc.h | 4 ++++ 2 files changed, 12 insertions(+)
Comments
On 01/10/2020 13:31, Florian Weimer via Libc-alpha wrote: > In some cases, it is difficult to determine the kind of malloc > based on the execution context, so a function to determine that > is helpful. LGTM, thanks. Reviewed-by: Adhemerval Zanella <adhemerval.zanella@linaro.org> > --- > elf/dl-minimal.c | 8 ++++++++ > include/rtld-malloc.h | 4 ++++ > 2 files changed, 12 insertions(+) > > diff --git a/elf/dl-minimal.c b/elf/dl-minimal.c > index 7c64e24c87..dc79f02458 100644 > --- a/elf/dl-minimal.c > +++ b/elf/dl-minimal.c > @@ -59,6 +59,14 @@ __rtld_malloc_init_stubs (void) > __rtld_realloc = &rtld_realloc; > } > > +bool > +__rtld_malloc_is_full (void) > +{ > + /* The caller assumes that there is an active malloc. */ > + assert (__rtld_malloc != NULL); > + return __rtld_malloc != &rtld_malloc; > +} > + The 'full' is somewhat confusing, maybe 'complete'? > /* Lookup NAME at VERSION in the scope of MATCH. */ > static void * > lookup_malloc_symbol (struct link_map *main_map, const char *name, > diff --git a/include/rtld-malloc.h b/include/rtld-malloc.h > index b026a3270c..54f53f7888 100644 > --- a/include/rtld-malloc.h > +++ b/include/rtld-malloc.h > @@ -66,6 +66,10 @@ realloc (void *ptr, size_t size) > implementation. */ > void __rtld_malloc_init_stubs (void) attribute_hidden; > > +/* Return false if the active malloc is the ld.so minimal malloc, true > + if it is the full implementation from libc.so. */ > +_Bool __rtld_malloc_is_full (void) attribute_hidden; > + > /* Called shortly before the final self-relocation (when RELRO > variables are still writable) to activate the real malloc > implementation. MAIN_MAP is the link map of the executable. */ >
* Adhemerval Zanella via Libc-alpha: > On 01/10/2020 13:31, Florian Weimer via Libc-alpha wrote: >> In some cases, it is difficult to determine the kind of malloc >> based on the execution context, so a function to determine that >> is helpful. > > LGTM, thanks. > > Reviewed-by: Adhemerval Zanella <adhemerval.zanella@linaro.org> Thanks, pushed as: commit 72d36ffd7db55ae599f4c77feb0eae25a0f3714e Author: Florian Weimer <fweimer@redhat.com> Date: Thu Oct 8 10:57:09 2020 +0200 elf: Implement __rtld_malloc_is_complete In some cases, it is difficult to determine the kind of malloc based on the execution context, so a function to determine that is helpful. Reviewed-by: Adhemerval Zanella <adhemerval.zanella@linaro.org> Florian
diff --git a/elf/dl-minimal.c b/elf/dl-minimal.c index 7c64e24c87..dc79f02458 100644 --- a/elf/dl-minimal.c +++ b/elf/dl-minimal.c @@ -59,6 +59,14 @@ __rtld_malloc_init_stubs (void) __rtld_realloc = &rtld_realloc; } +bool +__rtld_malloc_is_full (void) +{ + /* The caller assumes that there is an active malloc. */ + assert (__rtld_malloc != NULL); + return __rtld_malloc != &rtld_malloc; +} + /* Lookup NAME at VERSION in the scope of MATCH. */ static void * lookup_malloc_symbol (struct link_map *main_map, const char *name, diff --git a/include/rtld-malloc.h b/include/rtld-malloc.h index b026a3270c..54f53f7888 100644 --- a/include/rtld-malloc.h +++ b/include/rtld-malloc.h @@ -66,6 +66,10 @@ realloc (void *ptr, size_t size) implementation. */ void __rtld_malloc_init_stubs (void) attribute_hidden; +/* Return false if the active malloc is the ld.so minimal malloc, true + if it is the full implementation from libc.so. */ +_Bool __rtld_malloc_is_full (void) attribute_hidden; + /* Called shortly before the final self-relocation (when RELRO variables are still writable) to activate the real malloc implementation. MAIN_MAP is the link map of the executable. */