From patchwork Wed Aug 31 18:27:34 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Paul E. Murphy" X-Patchwork-Id: 15135 X-Patchwork-Delegate: joseph@codesourcery.com Received: (qmail 112905 invoked by alias); 31 Aug 2016 18:27:44 -0000 Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libc-alpha-owner@sourceware.org Delivered-To: mailing list libc-alpha@sourceware.org Received: (qmail 112888 invoked by uid 89); 31 Aug 2016 18:27:44 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=1.4 required=5.0 tests=AWL, BAYES_50, KAM_LAZY_DOMAIN_SECURITY, RCVD_IN_DNSWL_LOW, RCVD_IN_SEMBACKSCATTER autolearn=no version=3.3.2 spammy=2.4.11, 05l, x_adj2, 0.25L X-HELO: mx0a-001b2d01.pphosted.com X-IBM-Helo: d03dlp03.boulder.ibm.com X-IBM-MailFrom: murphyp@linux.vnet.ibm.com Subject: Re: [PATCHv3 1/4] ldbl-128: Rename 'long double' to '_Float128' To: Joseph Myers References: <4334e328-d6ed-5efe-0dc2-832bb54e5498@linux.vnet.ibm.com> <9870db45-594e-c5df-a0fd-750b4ca11ec8@linux.vnet.ibm.com> Cc: libc-alpha@sourceware.org From: "Paul E. Murphy" Date: Wed, 31 Aug 2016 13:27:34 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.0 MIME-Version: 1.0 In-Reply-To: X-TM-AS-GCONF: 00 X-Content-Scanned: Fidelis XPS MAILER x-cbid: 16083118-0008-0000-0000-00000570A521 X-IBM-SpamModules-Scores: X-IBM-SpamModules-Versions: BY=3.00005687; HX=3.00000240; KW=3.00000007; PH=3.00000004; SC=3.00000184; SDB=6.00752197; UDB=6.00355614; IPR=6.00525007; BA=6.00004683; NDR=6.00000001; ZLA=6.00000005; ZF=6.00000009; ZB=6.00000000; ZP=6.00000000; ZH=6.00000000; ZU=6.00000002; MB=3.00012537; XFM=3.00000011; UTC=2016-08-31 18:27:38 X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 16083118-0009-0000-0000-00003ABEE5EE Message-Id: X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:, , definitions=2016-08-31_04:, , signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 suspectscore=0 malwarescore=0 phishscore=0 adultscore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1604210000 definitions=main-1608310223 On 08/31/2016 12:02 PM, Joseph Myers wrote: > On Wed, 31 Aug 2016, Paul E. Murphy wrote: > >> On 08/30/2016 12:16 PM, Joseph Myers wrote: >>> On Tue, 30 Aug 2016, Paul E. Murphy wrote: >>> >>>> Is there any objection to committing patches 1 and >>>> 2 once approved? >>> >>> I don't intend to review patch 2 until patch 1 is in. >>> >> >> For my clarity, is the revised v3 patch 1 OK for commit? > > Yes, given a followup to fix indentation in cases where we have > > long double var = (expression > continued); > > and so changing long double to _Float128 requires the following lines in > the continued expression to be reindented (that appears twice in > e_gammal_r.c, at least). Attached is a patch to cleanup e_gammal_r.c. I didn't come across any others. OK too? From 25113f286be4ac32a124404b178f244c9508c954 Mon Sep 17 00:00:00 2001 From: "Paul E. Murphy" Date: Wed, 31 Aug 2016 13:17:35 -0500 Subject: [PATCH] ldbl-128: Cleanup e_gammal_r.c after _Float128 rename * sysdeps/ieee754/ldbl-128/e_gammal_r.c: (gammal_positive): Fix spacing. (__ieee754_gammal_r): Likewise. --- sysdeps/ieee754/ldbl-128/e_gammal_r.c | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/sysdeps/ieee754/ldbl-128/e_gammal_r.c b/sysdeps/ieee754/ldbl-128/e_gammal_r.c index 43282fe..ac68b31 100644 --- a/sysdeps/ieee754/ldbl-128/e_gammal_r.c +++ b/sysdeps/ieee754/ldbl-128/e_gammal_r.c @@ -105,10 +105,10 @@ gammal_positive (_Float128 x, int *exp2_adj) } *exp2_adj = x_adj_log2 * (int) x_adj_int; _Float128 ret = (__ieee754_powl (x_adj_mant, x_adj) - * __ieee754_exp2l (x_adj_log2 * x_adj_frac) - * __ieee754_expl (-x_adj) - * __ieee754_sqrtl (2 * M_PIl / x_adj) - / prod); + * __ieee754_exp2l (x_adj_log2 * x_adj_frac) + * __ieee754_expl (-x_adj) + * __ieee754_sqrtl (2 * M_PIl / x_adj) + / prod); exp_adj += x_eps * __ieee754_logl (x_adj); _Float128 bsum = gamma_coeff[NCOEFF - 1]; _Float128 x_adj2 = x_adj * x_adj; @@ -188,8 +188,8 @@ __ieee754_gammal_r (_Float128 x, int *signgamp) if (frac > 0.5L) frac = 1.0L - frac; _Float128 sinpix = (frac <= 0.25L - ? __sinl (M_PIl * frac) - : __cosl (M_PIl * (0.5L - frac))); + ? __sinl (M_PIl * frac) + : __cosl (M_PIl * (0.5L - frac))); int exp2_adj; ret = M_PIl / (-x * sinpix * gammal_positive (-x, &exp2_adj)); -- 2.4.11