diff mbox series

linux: Fix syscall list generation instructions

Message ID alpine.LFD.2.21.2007090520150.24175@redsun52.ssa.fujisawa.hgst.com
State Committed
Headers show
Series linux: Fix syscall list generation instructions | expand

Commit Message

Maciej W. Rozycki July 9, 2020, 4:40 a.m. UTC
Make the instructions for syscall list generation match Makefile and 
refer to `update-syscall-lists'; there has been no `update-arch-syscall' 
target.  Also use single quotes around the command to stick to the ASCII 
character set.

Fixes 4cf0d223052d ("Linux: Add tables with system call numbers").
---
 As a fix to a Makefile comment only I trust it is fine to apply even in 
the freeze period.  OK to push then?

  Maciej
---
 sysdeps/unix/sysv/linux/Makefile |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

glibc-update-syscall-lists.diff

Comments

Alistair Francis July 9, 2020, 1:42 p.m. UTC | #1
On Wed, Jul 8, 2020 at 9:40 PM Maciej W. Rozycki via Libc-alpha
<libc-alpha@sourceware.org> wrote:
>
> Make the instructions for syscall list generation match Makefile and
> refer to `update-syscall-lists'; there has been no `update-arch-syscall'
> target.  Also use single quotes around the command to stick to the ASCII
> character set.
>
> Fixes 4cf0d223052d ("Linux: Add tables with system call numbers").

Reviewed-by: Alistair Francis <alistair.francis@wdc.com>

Alistair

> ---
>  As a fix to a Makefile comment only I trust it is fine to apply even in
> the freeze period.  OK to push then?
>
>   Maciej
> ---
>  sysdeps/unix/sysv/linux/Makefile |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> glibc-update-syscall-lists.diff
> Index: glibc/sysdeps/unix/sysv/linux/Makefile
> ===================================================================
> --- glibc.orig/sysdeps/unix/sysv/linux/Makefile
> +++ glibc/sysdeps/unix/sysv/linux/Makefile
> @@ -26,7 +26,7 @@ ifndef subdir
>  # architecture-specific system call names.
>  #
>  # To bootstrap a new architecture, create an empty file in the right
> -# place and run ?make update-arch-syscall? from the top-level of a
> +# place and run `make update-syscall-lists' from the top-level of a
>  # configured, but not-yet-built glibc tree.
>  #
>  # --lock points to a file not replaced during the update operation, so
Carlos O'Donell July 9, 2020, 3:08 p.m. UTC | #2
On 7/9/20 12:40 AM, Maciej W. Rozycki wrote:
> Make the instructions for syscall list generation match Makefile and 
> refer to `update-syscall-lists'; there has been no `update-arch-syscall' 
> target.  Also use single quotes around the command to stick to the ASCII 
> character set.
> 
> Fixes 4cf0d223052d ("Linux: Add tables with system call numbers").
> ---
>  As a fix to a Makefile comment only I trust it is fine to apply even in 
> the freeze period.  OK to push then?
> 
>   Maciej
> ---
>  sysdeps/unix/sysv/linux/Makefile |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> glibc-update-syscall-lists.diff
> Index: glibc/sysdeps/unix/sysv/linux/Makefile
> ===================================================================
> --- glibc.orig/sysdeps/unix/sysv/linux/Makefile
> +++ glibc/sysdeps/unix/sysv/linux/Makefile
> @@ -26,7 +26,7 @@ ifndef subdir
>  # architecture-specific system call names.
>  #
>  # To bootstrap a new architecture, create an empty file in the right
> -# place and run ?make update-arch-syscall? from the top-level of a
> +# place and run `make update-syscall-lists' from the top-level of a
>  # configured, but not-yet-built glibc tree.
>  #
>  # --lock points to a file not replaced during the update operation, so
> 

This is trivial and Allistair gave a reivew. Please commit if you haven't
already.
Maciej W. Rozycki July 9, 2020, 4:47 p.m. UTC | #3
On Thu, 9 Jul 2020, Carlos O'Donell wrote:

> > Index: glibc/sysdeps/unix/sysv/linux/Makefile
> > ===================================================================
> > --- glibc.orig/sysdeps/unix/sysv/linux/Makefile
> > +++ glibc/sysdeps/unix/sysv/linux/Makefile
> > @@ -26,7 +26,7 @@ ifndef subdir
> >  # architecture-specific system call names.
> >  #
> >  # To bootstrap a new architecture, create an empty file in the right
> > -# place and run ?make update-arch-syscall? from the top-level of a
> > +# place and run `make update-syscall-lists' from the top-level of a
> >  # configured, but not-yet-built glibc tree.
> >  #
> >  # --lock points to a file not replaced during the update operation, so
> > 
> 
> This is trivial and Allistair gave a reivew. Please commit if you haven't
> already.

 Applied now; thank you both for the go-ahead!

  Maciej
diff mbox series

Patch

Index: glibc/sysdeps/unix/sysv/linux/Makefile
===================================================================
--- glibc.orig/sysdeps/unix/sysv/linux/Makefile
+++ glibc/sysdeps/unix/sysv/linux/Makefile
@@ -26,7 +26,7 @@  ifndef subdir
 # architecture-specific system call names.
 #
 # To bootstrap a new architecture, create an empty file in the right
-# place and run ?make update-arch-syscall? from the top-level of a
+# place and run `make update-syscall-lists' from the top-level of a
 # configured, but not-yet-built glibc tree.
 #
 # --lock points to a file not replaced during the update operation, so