From patchwork Thu Dec 13 18:09:21 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Joseph Myers X-Patchwork-Id: 30662 Received: (qmail 38151 invoked by alias); 13 Dec 2018 18:09:31 -0000 Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libc-alpha-owner@sourceware.org Delivered-To: mailing list libc-alpha@sourceware.org Received: (qmail 38052 invoked by uid 89); 13 Dec 2018 18:09:30 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-26.9 required=5.0 tests=BAYES_00, GIT_PATCH_0, GIT_PATCH_1, GIT_PATCH_2, GIT_PATCH_3, KAM_SHORT, RCVD_IN_DNSWL_NONE, SPF_PASS autolearn=ham version=3.3.2 spammy=clobbers, Hx-languages-length:1013 X-HELO: relay1.mentorg.com Date: Thu, 13 Dec 2018 18:09:21 +0000 From: Joseph Myers To: CC: Subject: Do not clobber sp in _hurd_stack_setup Message-ID: User-Agent: Alpine 2.21 (DEB 202 2017-01-01) MIME-Version: 1.0 GCC mainline now gives errors for an asm that clobbers the stack pointer. According to GCC previously ignored such a clobber; thus, this patch removes it from _hurd_stack_setup. Tested with build-many-glibcs.py for i686-gnu. 2018-12-13 Joseph Myers * sysdeps/mach/hurd/i386/init-first.c (_hurd_stack_setup): Do not clobber sp. diff --git a/sysdeps/mach/hurd/i386/init-first.c b/sysdeps/mach/hurd/i386/init-first.c index f8ad2ceb8e..e3d5797266 100644 --- a/sysdeps/mach/hurd/i386/init-first.c +++ b/sysdeps/mach/hurd/i386/init-first.c @@ -361,7 +361,7 @@ _hurd_stack_setup (void) *--data = caller; asm volatile ("movl %0, %%esp\n" /* Switch to new outermost stack. */ "movl $0, %%ebp\n" /* Clear outermost frame pointer. */ - "jmp *%1" : : "r" (data), "r" (&doinit1) : "sp"); + "jmp *%1" : : "r" (data), "r" (&doinit1)); /* NOTREACHED */ }