diff mbox

Include most of elf/ modules-names in modules-names-tests

Message ID alpine.DEB.2.21.1809121214530.28943@digraph.polyomino.org.uk
State New, archived
Headers show

Commit Message

Joseph Myers Sept. 12, 2018, 12:15 p.m. UTC
Here is a revised version, also excluding tst-tlsmod% from 
modules-names-tests because build-many-glibcs.py showed that those need 
internal headers on some architectures.


Include most of elf/ modules-names in modules-names-tests.

I'm testing a patch to let the compiler expand calls to floor in libm
as built-in function calls as much as possible, instead of calling
__floor, so that no architecture-specific __floor inlines are needed,
and then to arrange for non-inlined calls to end up calling __floor,
as done with sqrt and __ieee754_sqrt.

This shows up elf/tst-relsort1mod2.c calling floor, which must not be
converted to a call to __floor.  Now, while an IS_IN (libm)
conditional could be added to the existing conditionals on such
redirections in include/math.h, the _ISOMAC conditional ought to
suffice (code in other glibc libraries shouldn't be calling floor or
sqrt anyway, as they aren't provided in libc and the other libraries
don't link with libm).  But while tests are mostly now built with
_ISOMAC defined, test modules in modules-names aren't unless also
listed in modules-names-tests.

As far as I can see, all the modules in modules-names in elf/ are in
fact parts of tests and so listing them in modules-names-tests is
appropriate, so they get built with something closer to the headers
used for user code, except in a few cases that actually rely on
something from internal headers.  This patch duly sets
modules-names-tests there accordingly (filtering out those tests that
fail to build without internal headers).

Tested for x86_64, and with build-many-glibcs.py.

2018-09-12  Joseph Myers  <joseph@codesourcery.com>

	* elf/Makefile (modules-names-tests): New variable.

Comments

Florian Weimer Sept. 12, 2018, 12:38 p.m. UTC | #1
On 09/12/2018 02:15 PM, Joseph Myers wrote:
> +modules-names-tests = $(filter-out ifuncmod% tst-libc_dlvsym-dso tst-tlsmod%,\
> +				   $(modules-names))

Perhaps add a comment that the reliance on internal headers is the 
reason for filtering out these module names?

Patch looks fine to me otherwise.

Thanks,
Florian
diff mbox

Patch

diff --git a/elf/Makefile b/elf/Makefile
index cd0771307f..dd0fd83b57 100644
--- a/elf/Makefile
+++ b/elf/Makefile
@@ -274,6 +274,8 @@  modules-names = testobj1 testobj2 testobj3 testobj4 testobj5 testobj6 \
 		tst-nodelete-dlclose-dso tst-nodelete-dlclose-plugin \
 		tst-main1mod tst-libc_dlvsym-dso tst-absolute-sym-lib \
 		tst-absolute-zero-lib tst-big-note-lib
+modules-names-tests = $(filter-out ifuncmod% tst-libc_dlvsym-dso tst-tlsmod%,\
+				   $(modules-names))
 
 ifeq (yes,$(have-mtls-dialect-gnu2))
 tests += tst-gnu2-tls1