From patchwork Fri Mar 29 00:42:26 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Maciej W. Rozycki" X-Patchwork-Id: 32057 Received: (qmail 123012 invoked by alias); 29 Mar 2019 00:42:41 -0000 Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libc-alpha-owner@sourceware.org Delivered-To: mailing list libc-alpha@sourceware.org Received: (qmail 122991 invoked by uid 89); 29 Mar 2019 00:42:40 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-11.8 required=5.0 tests=BAYES_00, GIT_PATCH_2, GIT_PATCH_3, KAM_ASCII_DIVIDERS, RCVD_IN_DNSWL_LOW autolearn=ham version=3.3.1 spammy=shortly, HX-Languages-Length:2125, FSF, fsf X-HELO: esa2.hgst.iphmx.com DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=wdc.com; i=@wdc.com; q=dns/txt; s=dkim.wdc.com; t=1553820226; x=1585356226; h=from:to:cc:subject:date:message-id:content-id: content-transfer-encoding:mime-version; bh=7FcvwYfT2Q6TRH2A/mJ5mHsxDIJQQF6wqAfGD0V9moo=; b=AZWYJeY/VcZTq3vZdIiI0uVz1L2AN28bpxQeYOqhuOZ6f57SQHLy71rr yPC4YnzTHn8GtPe4T7+ubi9MyfDsbYtZjuBFPt+bFN3eyfa+C/17Ttrjp jcnOpTbt7kvwje4wcjY4l/4quWUmkwH6nXpkiZUvsdDth4USRZ/F0SO1e sjJkqPIZM5M2PoAH1tbec5hNuRctNnm7D9IzPdTsCWuppNPTuHz+1fGYQ UKeY0XkzoiiplmcEwi6P2ORtVnh+KqPi6+z0SBnAsr+xV2SMIrbMEfQIM uDcx8b5sBfA+2rHLyG0HBgJeINEF3+HOpoonJoaf+3Xb/lNbYTaqE4FMa w==; DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sharedspace.onmicrosoft.com; s=selector1-wdc-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=2z1GQu1OyqK591MszXCgIZgvYLtcAInVuTa+e2jblOQ=; b=aBiIsK255vK+ibnOocIngxX8pYqcoyBMPZE+ps2L+6EOpNQZ13Zdocgcmn6wlok5CBV80DGXG/LZ0KMDG2GEBbE2rc6y/TEcPUFq0URQiBsXNrhAfTMumLbgv4P/YQFpZaawYDJWkO9xpwZjPSb75y5i5jxtRimVGxsYw/B20bQ= From: Maciej Rozycki To: "libc-alpha@sourceware.org" CC: Palmer Dabbelt Subject: [PATCH] RISC-V: Fix `test' operand error with soft-float ABI being configured Date: Fri, 29 Mar 2019 00:42:26 +0000 Message-ID: authentication-results: spf=none (sender IP is ) smtp.mailfrom=macro@wdc.com; wdcipoutbound: EOP-TRUE x-ms-exchange-senderadcheck: 1 Content-ID: MIME-Version: 1.0 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED From: Maciej W. Rozycki Fix a: .../sysdeps/unix/sysv/linux/riscv/configure: line 181: test: =: unary operator expected message produced by the RISC-V configure fragment with the soft-float ABI selected, caused by $libc_cv_riscv_float_abi evaluating to nil in the invocation of `test $libc_cv_riscv_float_abi = no'. * sysdeps/unix/sysv/linux/riscv/configure.ac: Quote $libc_cv_riscv_float_abi in `test' invocation. * sysdeps/unix/sysv/linux/riscv/configure: Regenerate. --- Hi, NB my WDC copyright assignment with FSF hasn't been sorted yet, however this change, being under 15 lines, falls into the legally-insignificant category I believe, and therefore should be OK to apply right away. I believe it is obviously correct as well, and therefore I will commit it shortly. The change has been verified by reconfiguring glibc and ensuring that the message has gone away. Maciej --- sysdeps/unix/sysv/linux/riscv/configure | 2 +- sysdeps/unix/sysv/linux/riscv/configure.ac | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) glibc-riscv-configure-float-abi.diff Index: glibc/sysdeps/unix/sysv/linux/riscv/configure =================================================================== --- glibc.orig/sysdeps/unix/sysv/linux/riscv/configure +++ glibc/sysdeps/unix/sysv/linux/riscv/configure @@ -178,7 +178,7 @@ if (eval "$ac_cpp conftest.$ac_ext") 2>& fi rm -f conftest* -if test $libc_cv_riscv_float_abi = no; then +if test "$libc_cv_riscv_float_abi" = no; then as_fn_error $? "Unable to determine floating-point ABI" "$LINENO" 5 fi Index: glibc/sysdeps/unix/sysv/linux/riscv/configure.ac =================================================================== --- glibc.orig/sysdeps/unix/sysv/linux/riscv/configure.ac +++ glibc/sysdeps/unix/sysv/linux/riscv/configure.ac @@ -20,7 +20,7 @@ AC_EGREP_CPP(yes, [#ifdef __riscv_float_ yes #endif ],libc_cv_riscv_float_abi=) -if test $libc_cv_riscv_float_abi = no; then +if test "$libc_cv_riscv_float_abi" = no; then AC_MSG_ERROR([Unable to determine floating-point ABI]) fi