diff mbox

Avoid signed shift overflow in pow (bug 21309) [committed]

Message ID alpine.DEB.2.20.1712191841250.27055@digraph.polyomino.org.uk
State Committed
Headers

Commit Message

Joseph Myers Dec. 19, 2017, 6:41 p.m. UTC 
  As noted in bug 21309, dbl-64/e_pow.c contains signed int shifts that,
although the shift count is in the range [0, 31], shift bits into and
beyond the sign bit and so are undefined in ISO C.  Although this is
defined in GNU C, this patch from the bug cleans up the code to avoid
those shifts.

Tested for x86_64.  Committed.

2017-12-19  Bernd Edlinger  <bernd.edlinger@hotmail.de>

	[BZ #21309]
	* sysdeps/ieee754/dbl-64/e_pow.c (checkint): Make m and n
	unsigned.
diff mbox

Patch

diff --git a/sysdeps/ieee754/dbl-64/e_pow.c b/sysdeps/ieee754/dbl-64/e_pow.c
index 2eb8dbf..d3cb42d 100644
--- a/sysdeps/ieee754/dbl-64/e_pow.c
+++ b/sysdeps/ieee754/dbl-64/e_pow.c
@@ -452,7 +452,8 @@  checkint (double x)
     int4 i[2];
     double x;
   } u;
-  int k, m, n;
+  int k;
+  unsigned int m, n;
   u.x = x;
   m = u.i[HIGH_HALF] & 0x7fffffff;	/* no sign */
   if (m >= 0x7ff00000)