diff mbox

Remove old po/ code for copying .po files from shared directory

Message ID alpine.DEB.2.20.1712142111530.5909@digraph.polyomino.org.uk
State New, archived
Headers

Commit Message

Joseph Myers Dec. 14, 2017, 9:12 p.m. UTC 
  po/Makefile has both old code for copying .po files from a shared
directory /com/share/ftp/gnu/po/maint/glibc (presumably once present
on some GNU server), and new code for downloading them from the
Translation Project.  This patch removes the old code, leading only
the new code.

Tested for x86_64.

2017-12-14  Joseph Myers  <joseph@codesourcery.com>

	* po/Makefile (linguas): Remove rule and dependencies.
	(linguas.mo): Likewise.
	(.PHONY): Do not depend on linguas and linguas.mo.
	(podir): Remove variable.
	(pofiles): Likewise.
	[$(pofiles)] (%.po): Remove rule.

Comments

Carlos O'Donell Dec. 15, 2017, 4:20 a.m. UTC | #1 
On 12/14/2017 01:12 PM, Joseph Myers wrote:
> po/Makefile has both old code for copying .po files from a shared
> directory /com/share/ftp/gnu/po/maint/glibc (presumably once present
> on some GNU server), and new code for downloading them from the
> Translation Project.  This patch removes the old code, leading only
> the new code.
> 
> Tested for x86_64.
> 
> 2017-12-14  Joseph Myers  <joseph@codesourcery.com>
> 
> 	* po/Makefile (linguas): Remove rule and dependencies.
> 	(linguas.mo): Likewise.
> 	(.PHONY): Do not depend on linguas and linguas.mo.
> 	(podir): Remove variable.
> 	(pofiles): Likewise.
> 	[$(pofiles)] (%.po): Remove rule.

LGTM.
Chris Leonard Dec. 16, 2017, 10:29 p.m. UTC | #2 
On Thu, Dec 14, 2017 at 4:12 PM, Joseph Myers <joseph@codesourcery.com> wrote:
>
> po/Makefile has both old code for copying .po files from a shared
> directory /com/share/ftp/gnu/po/maint/glibc (presumably once present
> on some GNU server), and new code for downloading them from the
> Translation Project.  This patch removes the old code, leading only
> the new code.


Why is the glibc PO file hosted on the Translation Project instead of
DamnedLies?

TP has only 90-odd languages (and only 35 with glibc projects) and
DamendLies has 190-odd languages.

Is it a re-licensing / copyright waiver collection thing?

cjl
Joseph Myers Dec. 18, 2017, 5:19 p.m. UTC | #3 
On Sat, 16 Dec 2017, Chris Leonard wrote:

> Why is the glibc PO file hosted on the Translation Project instead of
> DamnedLies?

The Translation Project is the normal place used by GNU tools such as gcc, 
binutils, make, coreutils, sed, gawk, etc.; I don't see why glibc would do 
anything different.
  
glibc does indeed require translation disclaimers filed at the FSF, as      
stated at <https://translationproject.org/domain/libc.html>.
diff mbox

Patch

diff --git a/po/Makefile b/po/Makefile
index 122db23..1fdce17 100644
--- a/po/Makefile
+++ b/po/Makefile
@@ -86,30 +86,9 @@  libc.pot.files: FORCE
 # Install the message object files as libc.po in the language directory.
 $(mo-installed): %.mo $(+force); $(do-install) || exit 0
 
-.PHONY: linguas linguas.mo
-linguas: $(ALL_LINGUAS:=.po)
-linguas.mo: $(ALL_LINGUAS:=.mo)
-
 realclean:
 	rm -f $(ALL_LINGUAS:=.mo)
 
-# Copy the PO files from the translation coordinator's repository.
-
-podir = /com/share/ftp/gnu/po/maint/glibc
-
-pofiles := $(wildcard $(podir)/*.po)
-
-ifneq (,$(pofiles))
-
-%.po: $(podir)/%.po
-	cp -f $< $@
-	chmod 444 $@
-
-linguas: $(pofiles:$(podir)/%=%)
-linguas.mo: $(pofiles:$(podir)/%.po=%.mo)
-
-endif
-
 # Update translations from the translation project.
 TRANSLATIONS_URL = https://translationproject.org/latest/libc
 WGET = wget