diff mbox

Do not build .mo files in source directory (bug 14121)

Message ID alpine.DEB.2.20.1712141812540.22274@digraph.polyomino.org.uk
State New
Headers show

Commit Message

Joseph Myers Dec. 14, 2017, 6:13 p.m. UTC
Building and installing glibc leaves .mo files (compiled message
translations) behind in the source directory.  Building those files in
the source directory may once have made sense, if they were included
in release tarballs; now that release tarballs are just the output of
"git archive", building any non-checked-in files in the source
directory does not make sense.  This patch changes these files to be
built in the build directory instead.

This is necessary but not sufficient to avoid build-many-glibcs.py
needing to copy the glibc source directory.  Its list of files to
touch on checkout to avoid subsequent regeneration (configure,
preconfigure, *-kw.h) is incomplete (missing at least INSTALL,
sysdeps/gnu/errlist.c, posix/testcases.h, posix/ptestcases.h,
locale/C-translit.h, (only regenerated for Hurd builds)
sysdeps/mach/hurd/bits/errno.h) - the existing list may be sufficient
to prevent regeneration that actually changes the file contents
depending on the installed build tools, but not to ensure there is no
regeneration at all - and there might well be other things writing
into the source directory in the course of building and testing (so
needing appropriate testing with read-only source directories with
different timestamp orderings to find and eliminate all such cases).

Tested for x86_64.

2017-12-14  Joseph Myers  <joseph@codesourcery.com>

	[BZ #14121]
	* po/Makefile (%.mo): Change to $(objpfx)%.mo.  Use
	$(make-target-directory).
	($(mo-installed)): Use $(objpfx)%.mo.

Comments

Florian Weimer Dec. 14, 2017, 6:42 p.m. UTC | #1
On 12/14/2017 07:13 PM, Joseph Myers wrote:
> 2017-12-14  Joseph Myers<joseph@codesourcery.com>
> 
> 	[BZ #14121]
> 	* po/Makefile (%.mo): Change to $(objpfx)%.mo.  Use
> 	$(make-target-directory).
> 	($(mo-installed)): Use $(objpfx)%.mo.

I think the realclean and linguas.mo targets should be changed for 
consistency.

Thanks,
Florian
diff mbox

Patch

diff --git a/po/Makefile b/po/Makefile
index 122db23..d72f652 100644
--- a/po/Makefile
+++ b/po/Makefile
@@ -80,11 +80,12 @@  libc.pot.files: FORCE
 
 # Compile the binary message object files from the portable object source
 # files of translations for each language.
-%.mo: %.po
+$(objpfx)%.mo: %.po
+	$(make-target-directory)
 	$(MSGFMT) -o $@ $<
 
 # Install the message object files as libc.po in the language directory.
-$(mo-installed): %.mo $(+force); $(do-install) || exit 0
+$(mo-installed): $(objpfx)%.mo $(+force); $(do-install) || exit 0
 
 .PHONY: linguas linguas.mo
 linguas: $(ALL_LINGUAS:=.po)