From patchwork Fri Oct 13 16:39:21 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Joseph Myers X-Patchwork-Id: 23550 Received: (qmail 36667 invoked by alias); 13 Oct 2017 16:39:31 -0000 Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libc-alpha-owner@sourceware.org Delivered-To: mailing list libc-alpha@sourceware.org Received: (qmail 36657 invoked by uid 89); 13 Oct 2017 16:39:30 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-24.5 required=5.0 tests=AWL, BAYES_00, GIT_PATCH_0, GIT_PATCH_1, GIT_PATCH_2, GIT_PATCH_3, RCVD_IN_DNSWL_NONE, SPF_PASS, URIBL_RED autolearn=ham version=3.3.2 spammy= X-HELO: relay1.mentorg.com Date: Fri, 13 Oct 2017 16:39:21 +0000 From: Joseph Myers To: Subject: Fix ldbl-opt/w_lgamma_compatl.c libm_alias_ldouble_other usage [committed] Message-ID: User-Agent: Alpine 2.20 (DEB 67 2015-01-07) MIME-Version: 1.0 X-ClientProxiedBy: svr-ies-mbx-01.mgc.mentorg.com (139.181.222.1) To svr-ies-mbx-01.mgc.mentorg.com (139.181.222.1) Testing with changes to enable _Float128 function aliases shows that the libm_alias_ldouble_other usage in ldbl-opt/w_lgamma_compatl.c does not in fact work. Furthermore, it is unnecessary; the relevant aliases get created through w_lgammal_compat2.c. This patch removes the problem code. Tested with build-many-glibcs.py that installed stripped shared libraries are unchanged by the patch. Also tested in conjunction with patches to enable _Float128 function aliases. Committed. 2017-10-13 Joseph Myers * sysdeps/ieee754/ldbl-opt/w_lgamma_compatl.c [BUILD_LGAMMA]: Remove conditional code. diff --git a/sysdeps/ieee754/ldbl-opt/w_lgamma_compatl.c b/sysdeps/ieee754/ldbl-opt/w_lgamma_compatl.c index 003a253..f60b3d7 100644 --- a/sysdeps/ieee754/ldbl-opt/w_lgamma_compatl.c +++ b/sysdeps/ieee754/ldbl-opt/w_lgamma_compatl.c @@ -9,8 +9,3 @@ #if GAMMA_ALIAS long_double_symbol (libm, __gammal, gammal); #endif -#if BUILD_LGAMMA -# undef weak_alias -# define weak_alias(name, aliasname) _weak_alias (name, aliasname) -libm_alias_ldouble_other (__lgamma, lgamma) -#endif