nios2 sys/cachectl.h includes nonexistent asm/cachectl.h
Commit Message
On Tue, 15 Nov 2016, Mike Frysinger wrote:
> On 04 Nov 2016 21:37, Joseph Myers wrote:
> > nios2 glibc compile-only test results include:
> >
> > FAIL: misc/check-installed-headers-c
> > FAIL: misc/check-installed-headers-cxx
> >
> > This is because sys/cachectl.h includes asm/cachectl.h, and the Linux
> > kernel has no such header. How is this meant to work? Should that
> > #include just be removed?
>
> delete it for now. looks like they speced it out for future usage,
> but haven't yet gotten around to it. the kernel will explicitly
> throw an error if the |op| field is non-zero.
This patch does that.
Do not include asm/cachectl.h in nios2 sys/cachectl.h.
The nios2 sys/cachectl.h includes a kernel header asm/cachectl.h,
which does not exist, so causing the check-installed-headers tests to
fail. This patch removes the include of a nonexistent header.
Tested (compilation only) for nios2.
2016-11-16 Joseph Myers <joseph@codesourcery.com>
* sysdeps/unix/sysv/linux/nios2/sys/cachectl.h: Do not include
<asm/cachectl.h>.
Comments
Ping. This patch
<https://sourceware.org/ml/libc-alpha/2016-11/msg00584.html> is pending
review.
On 16 Nov 2016 18:45, Joseph Myers wrote:
> On Tue, 15 Nov 2016, Mike Frysinger wrote:
> > On 04 Nov 2016 21:37, Joseph Myers wrote:
> > > nios2 glibc compile-only test results include:
> > >
> > > FAIL: misc/check-installed-headers-c
> > > FAIL: misc/check-installed-headers-cxx
> > >
> > > This is because sys/cachectl.h includes asm/cachectl.h, and the Linux
> > > kernel has no such header. How is this meant to work? Should that
> > > #include just be removed?
> >
> > delete it for now. looks like they speced it out for future usage,
> > but haven't yet gotten around to it. the kernel will explicitly
> > throw an error if the |op| field is non-zero.
>
> This patch does that.
>
> Do not include asm/cachectl.h in nios2 sys/cachectl.h.
>
> The nios2 sys/cachectl.h includes a kernel header asm/cachectl.h,
> which does not exist, so causing the check-installed-headers tests to
> fail. This patch removes the include of a nonexistent header.
lgtm
-mike
@@ -21,9 +21,6 @@
#include <features.h>
-/* Get the kernel definition for the op bits. */
-#include <asm/cachectl.h>
-
__BEGIN_DECLS
#ifdef __USE_MISC