From patchwork Wed Nov 26 16:34:50 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Joseph Myers X-Patchwork-Id: 3949 Received: (qmail 525 invoked by alias); 26 Nov 2014 16:34:56 -0000 Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libc-alpha-owner@sourceware.org Delivered-To: mailing list libc-alpha@sourceware.org Received: (qmail 512 invoked by uid 89); 26 Nov 2014 16:34:56 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=AWL, BAYES_00, RCVD_IN_DNSWL_NONE autolearn=ham version=3.3.2 X-HELO: relay1.mentorg.com Date: Wed, 26 Nov 2014 16:34:50 +0000 From: Joseph Myers To: Subject: Fix sysdeps/mips/__longjmp.c warning Message-ID: User-Agent: Alpine 2.10 (DEB 1266 2009-07-14) MIME-Version: 1.0 This patch fixes ../sysdeps/mips/__longjmp.c:27:1: warning: function declaration isn't a prototype [-Wstrict-prototypes] which arose I think from the MIPS16 changes (renaming the function to ____longjmp with an alias __longjmp, so a prior header prototype for __longjmp no longer sufficed to prevent a warning). I've made the function use a prototype definition, which is what we want for all function definitions in glibc anyway. Tested for MIPS and committed. 2014-11-26 Joseph Myers * sysdeps/mips/__longjmp.c (____longjmp): Use prototype definition. diff --git a/sysdeps/mips/__longjmp.c b/sysdeps/mips/__longjmp.c index 5e6a353..c2498c3 100644 --- a/sysdeps/mips/__longjmp.c +++ b/sysdeps/mips/__longjmp.c @@ -24,9 +24,7 @@ #endif static void __attribute__ ((nomips16)) -____longjmp (env_arg, val_arg) - __jmp_buf env_arg; - int val_arg; +____longjmp (__jmp_buf env_arg, int val_arg) { /* gcc 1.39.19 miscompiled the longjmp routine (as it did setjmp before the hack around it); force it to use $a1 for the longjmp value.