diff mbox

Fix warning in posix/bug-regex31.c

Message ID alpine.DEB.2.10.1411251752310.18401@digraph.polyomino.org.uk
State Committed
Headers

Commit Message

Joseph Myers Nov. 25, 2014, 5:53 p.m. UTC 
  This patch fixes a "set but not used" warning in posix/bug-regex31.c.
A variable res stored an indication of whether the test behaved as
expected, but was then ignored and the test returned 0 unconditionally
(as an mtrace test, the auxiliary test for leaks could still have
failed if that bug was present).  This patch makes the test return
res.

Tested for x86_64.

2014-11-25  Joseph Myers  <joseph@codesourcery.com>

	* posix/bug-regex31.c (main): Return RES not 0.

Comments

Ondrej Bilka Nov. 25, 2014, 6:01 p.m. UTC | #1 
On Tue, Nov 25, 2014 at 05:53:38PM +0000, Joseph Myers wrote:
> This patch fixes a "set but not used" warning in posix/bug-regex31.c.
> A variable res stored an indication of whether the test behaved as
> expected, but was then ignored and the test returned 0 unconditionally
> (as an mtrace test, the auxiliary test for leaks could still have
> failed if that bug was present).  This patch makes the test return
> res.
> 
> Tested for x86_64.
> 
looks ok.
diff mbox

Patch

diff --git a/posix/bug-regex31.c b/posix/bug-regex31.c
index fc48581..fd7e0c5 100644
--- a/posix/bug-regex31.c
+++ b/posix/bug-regex31.c
@@ -33,5 +33,5 @@  main (void)
 
   free (buf);
 
-  return 0;
+  return res;
 }