PLEASE FIX NOW! make check-abi exits zero on failure
Commit Message
Since you want a quick fix, I've applied this patch. (Really the
subdirectory check-abi targets should generate .sum files and then
toplevel combine those, just like the tests and xtests targets.)
Comments
> Since you want a quick fix, I've applied this patch. (Really the
> subdirectory check-abi targets should generate .sum files and then
> toplevel combine those, just like the tests and xtests targets.)
That suffices for the moment, yes. I am all for cleanups in the
organization of testing targets and appreciative of work toward that,
though I have not at all followed the details of what you and others have
been doing in that regard. But I am wholly intolerant of regressions in
the top-level behavior or common developer practices (including things like
'make check subdirs=foo'). Please take care to avoid introducing more, and
double-check for any more like this that you may have introduced. If you
change any such behavior intentionally and think that the change is
preferable, please be sure to make clear announcements about what you
propose in obvious RFC or PSA messages that are concise and not just
mention it buried in verbiage about some particular change's review or
other such things that are easily missed by those of us not reading every
word of every post.
Thanks,
Roland
@@ -1,3 +1,8 @@
+2014-03-18 Joseph Myers <joseph@codesourcery.com>
+
+ * Makerules [!subdir] (check-abi): Exit with error status if a
+ test failed.
+
2014-03-17 Joseph Myers <joseph@codesourcery.com>
* math/libm-test.inc (nearbyint_test_data): Include all tests used
@@ -1257,6 +1257,7 @@ subdir_check-abi: check-abi
subdir_update-abi: update-abi
else
check-abi: subdir_check-abi
+ if grep -q '^FAIL:' $(objpfx)*/check-abi*.test-result; then exit 1; fi
update-abi: subdir_update-abi
endif