From patchwork Fri Mar 16 14:36:12 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Wilco Dijkstra X-Patchwork-Id: 26339 Received: (qmail 105959 invoked by alias); 16 Mar 2018 14:36:18 -0000 Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libc-alpha-owner@sourceware.org Delivered-To: mailing list libc-alpha@sourceware.org Received: (qmail 105927 invoked by uid 89); 16 Mar 2018 14:36:18 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-25.3 required=5.0 tests=AWL, BAYES_00, GIT_PATCH_0, GIT_PATCH_1, GIT_PATCH_2, GIT_PATCH_3, RCVD_IN_DNSWL_NONE, SPF_HELO_PASS, SPF_PASS autolearn=ham version=3.3.2 spammy=Hx-languages-length:1130 X-HELO: EUR01-DB5-obe.outbound.protection.outlook.com From: Wilco Dijkstra To: Joseph Myers CC: "libc-alpha@sourceware.org" , nd Subject: Re: [PATCH v4 3/3] Cleanup __ieee754_sqrt(f/l) Date: Fri, 16 Mar 2018 14:36:12 +0000 Message-ID: References: , In-Reply-To: authentication-results: spf=none (sender IP is ) smtp.mailfrom=Wilco.Dijkstra@arm.com; x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1; DB6PR0801MB1384; 6:G8+rQisrSLgsxRxCDJut+uo37AknRGrzzn+bwaO8q8YPWfoQL+Z/m5jSUuFruKlkEgkm/L8FdAKBL35uK8XD0i3oZWNkbsPX/AR7q8tbbM5vqNCRXdawKrYqfUino+TqwmLWCkJBA8U4klri5LXXY07c5U6oACeQLEy+NLfPGbRx51IV9bR1jOA1+ZTyTnMBeyxHUZpcXb5xA2gwojhZ3/M0FM7iihAGZAcZEPID0MS9WEc31CCx5mcFUBelifYSnUuTWqtwpAJzPM8ozQfizSqMxpNyT3EXzPhC3/NrBKz+7vair09WV42dUbtN+d4Ud2oNyKltsIutXuNIdOYvqEyYLKDqd1Ohn39tM/FG3DBwbcNruvgbdK5geSN/9ouF; 5:ybhRX8xgkAgmvff46fdVmYLTTtt/turEgn43IMic6y11EOYgwdKEo7kP89nF9Wbicxus+nZQc5ZJfVWvoOYT6xAcAQWWukDYZWY1jlsyt2/umYX2fZbuxDlQJBLy8zbk00ZGfhJ3kmndf7gd9DEj30Jp24MEse/9pAWqLRZURPg=; 24:Lso31yWMKg3jcjUsynLE91X+sV5e2BirxSWQejRYkChNjgsLk3ysuTXrO433kLCSQEBCuJY9l23L925TeQ8q8q4xCvFJ/nwuHJBYQiDjR6g=; 7:eCwDWpAdP9gJcTTUDRSMgdFqGmk3uFs2eR3MfR1k8NB6WctHSYN04BulnNayak7xewhDVo5Tsbe3DazFvAx7TWeLeF8JDN7MN0u7yPpBH9U0ETNXDkTtwt1NfYcA97d+QoQWe9y+EKMX42ZPokh8goxyZh1lgxWLlTCrN4HbIM31jo+2HQUzgeZMbcovEB1Ep/OKfwuhUnACzBtNsG/Tt2okocWfLOQLfKLGTlVcsb15aTpXyoZYhfkI4gkvFJaN x-ms-exchange-antispam-srfa-diagnostics: SOS; x-ms-office365-filtering-ht: Tenant x-ms-office365-filtering-correlation-id: ad22674d-85e9-457d-5116-08d58b4b444a x-microsoft-antispam: UriScan:; BCL:0; PCL:0; RULEID:(7020095)(4652020)(48565401081)(5600026)(4604075)(3008032)(4534165)(4627221)(201703031133081)(201702281549075)(2017052603328)(7153060)(7193020); SRVR:DB6PR0801MB1384; x-ms-traffictypediagnostic: DB6PR0801MB1384: nodisclaimer: True x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:(180628864354917); x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(8211001083)(6040522)(2401047)(8121501046)(5005006)(3231221)(944501244)(52105095)(3002001)(93006095)(93001095)(10201501046)(6055026)(6041310)(20161123560045)(20161123564045)(20161123562045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123558120)(6072148)(201708071742011); SRVR:DB6PR0801MB1384; BCL:0; PCL:0; RULEID:; SRVR:DB6PR0801MB1384; x-forefront-prvs: 0613912E23 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(39860400002)(39380400002)(366004)(396003)(346002)(376002)(377424004)(54534003)(199004)(189003)(99286004)(54906003)(76176011)(186003)(53936002)(2900100001)(59450400001)(6506007)(102836004)(6246003)(2950100002)(8936002)(6916009)(81156014)(81166006)(8676002)(25786009)(74316002)(68736007)(33656002)(14454004)(7736002)(26005)(55016002)(229853002)(305945005)(7696005)(9686003)(4326008)(72206003)(97736004)(5250100002)(6436002)(6116002)(106356001)(3846002)(86362001)(3660700001)(2906002)(105586002)(66066001)(478600001)(316002)(5660300001)(3280700002); DIR:OUT; SFP:1101; SCL:1; SRVR:DB6PR0801MB1384; H:DB6PR0801MB2053.eurprd08.prod.outlook.com; FPR:; SPF:None; PTR:InfoNoRecords; A:1; MX:1; LANG:en; received-spf: None (protection.outlook.com: arm.com does not designate permitted sender hosts) x-microsoft-antispam-message-info: XNcqTaTcnFckTGszh4Zfw/N9K6Zd/TD2LXUhOC1U0B0tD9G9XkTuD2XlmpFT1EL20ob8bUJbmwRMe1LZAFxV16HthvpiS69fq6y1rWklnCaTwhuajro88urf6MkY0Az+oi+DZZL1VQSDLvswegrKOOMG6p6nfNQUWtJlfcrF8k1naepJ89HMidoEIEi4OICtvPvbEEvr+Jk6QjkpcIGAqaMoXossRF/xTivCcc05LUDuFSNFAgXE2deD/7fUCiYqggUkX74XTl7DG76eglo8mAaRjkQnPUkjEKAJH4RGLFhqt2AqN6DGkeWpsccp44RW4ZKqE4xX/+hqZtRpD1IqWg== spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM MIME-Version: 1.0 X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-Network-Message-Id: ad22674d-85e9-457d-5116-08d58b4b444a X-MS-Exchange-CrossTenant-originalarrivaltime: 16 Mar 2018 14:36:12.6853 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB6PR0801MB1384 Joseph Myers wrote:   > This appears to have broken the build of sqrtl for m68k, at least with GCC > 6. Yes it seems like it still needs the __inline_mathop for some complex macro manupulations. I've committed this: Revert m68k __ieee754_sqrt change as it causes a build failure in one m68k configuration. m68k-linux-gnu now passes again. ChangeLog: 2018-03-16 Wilco Dijkstra * sysdeps/m68k/m680x0/fpu/mathimpl.h (__ieee754_sqrt): Revert previous commit. diff --git a/sysdeps/m68k/m680x0/fpu/mathimpl.h b/sysdeps/m68k/m680x0/fpu/mathimpl.h index d39094cccbd3712dfae4601967ee695722b446a0..848f9cffaadad09443cd539ceb68da5712a93b39 100644 --- a/sysdeps/m68k/m680x0/fpu/mathimpl.h +++ b/sysdeps/m68k/m680x0/fpu/mathimpl.h @@ -30,6 +30,7 @@ __inline_mathop (__ieee754_exp10, tentox,) __inline_mathop (__ieee754_log10, log10,) __inline_mathop (__ieee754_log2, log2,) __inline_mathop (__ieee754_log, logn,) +__inline_mathop (__ieee754_sqrt, sqrt,) __inline_mathop (__ieee754_atanh, atanh,) __m81_defun (double, __ieee754_remainder, (double __x, double __y),)