From patchwork Fri Jan 27 17:57:03 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "H.J. Lu" X-Patchwork-Id: 19048 Received: (qmail 88157 invoked by alias); 27 Jan 2017 17:57:16 -0000 Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libc-alpha-owner@sourceware.org Delivered-To: mailing list libc-alpha@sourceware.org Received: (qmail 88141 invoked by uid 89); 27 Jan 2017 17:57:16 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.4 required=5.0 tests=AWL, BAYES_00, FREEMAIL_FROM, RCVD_IN_DNSWL_NONE, RCVD_IN_SORBS_SPAM, SPF_PASS autolearn=no version=3.3.2 spammy=hjltoolsgmailcom, sk:hjltoo, sk:hjl.too, U*hjl.tools X-HELO: mail-yw0-f176.google.com X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=hPNp9prpCjjQE7tc+sW+rtKB8Iaf2Y6ljFuGthlBMTg=; b=Z4jUh07IQpAdscFcZYBwc4cxjd4/HuAg/VuBkjIKSDwyHn2IYxrJwoqNcnGposQdKo Ab9HSgU6PcKnMZq/xy/ThLaUwMSfZpCsUzwTqWazAcdpDWIMIuj/JF1th31SDxlXPEUr x10qD6aWfuCDlVlg7BMciDY30WH4bwgnQAjqALNnTMTRQeLEop58VmiKpkkHDiTyeqii gsXpccdQXCCJ7Mgz70/XXR+vsN0pjmpxmdb5PG8oTqwZ9VqOM5yQ8n5MHMRc9/zlsHzm +K8QvAGECPmWnBD+Aer5/cSlAiHNHPYAlsacX8CIfICJABPpS8M+2Nozr4Yi/hxJFE7k GY4A== X-Gm-Message-State: AIkVDXK6rMfcNU6PJWlgbB5Et0asc/TPFbOFpcrqvfA1K6mlzOKrsVxDPhOKrOA7Ij7WSiGiteO/DotVoICBGg== X-Received: by 10.55.197.148 with SMTP id k20mr9095708qkl.34.1485539824308; Fri, 27 Jan 2017 09:57:04 -0800 (PST) MIME-Version: 1.0 In-Reply-To: References: From: "H.J. Lu" Date: Fri, 27 Jan 2017 09:57:03 -0800 Message-ID: Subject: Re: 2.25 freeze status To: Siddhesh Poyarekar Cc: "libc-alpha@sourceware.org" On Thu, Jan 26, 2017 at 8:06 PM, Siddhesh Poyarekar wrote: > Hi, > > The release date of 1 Feb is upon us and there are 3 release blockers > that haven't been resolved yet: > > - global-dynamic TLS broken on aarch64 and others > - Fix for bug 20019 causes linker errors for shared libraries using > longjmp > - tunables: insecure environment variables passed to subprocesses with > AT_SECURE > > I've got the tunables one and I hope to post a patch by tonight, latest > by tomorrow morning. What is the status on the other two? > > Also, assuming that these fixes go in next week, would arch maintainers > like another week to run a final set of tests before I cut the release > branch? If not then I'll simply cut the release 2 days after the > release blockers are resolved. If yes then I'll cut the release 7 days > after the current release blockers are resolved. > > Does that sound good? > > Siddhesh I am testing this patch for https://sourceware.org/bugzilla/show_bug.cgi?id=21081 I'd like to check it in before code freeze. From 9097edb85e04c137f226f3d371afff34a4ab17b7 Mon Sep 17 00:00:00 2001 From: "H.J. Lu" Date: Tue, 24 Jan 2017 15:58:49 -0800 Subject: [PATCH] Add VZEROUPPER to memset-vec-unaligned-erms.S [BZ #21081] Since memset-vec-unaligned-erms.S has VDUP_TO_VEC0_AND_SET_RETURN at function entry, memset optimized for AVX2 and AVX512 will always use ymm/zmm register. VZEROUPPER should be placed before ret in L(stosb): movq %rdx, %rcx movzbl %sil, %eax movq %rdi, %rdx rep stosb movq %rdx, %rax ret since it can be reached from L(stosb_more_2x_vec): cmpq $REP_STOSB_THRESHOLD, %rdx ja L(stosb) [BZ #21081] * sysdeps/x86_64/multiarch/memset-vec-unaligned-erms.S (L(stosb)): Add VZEROUPPER before ret. --- sysdeps/x86_64/multiarch/memset-vec-unaligned-erms.S | 2 ++ 1 file changed, 2 insertions(+) diff --git a/sysdeps/x86_64/multiarch/memset-vec-unaligned-erms.S b/sysdeps/x86_64/multiarch/memset-vec-unaligned-erms.S index ff214f0..704eed9 100644 --- a/sysdeps/x86_64/multiarch/memset-vec-unaligned-erms.S +++ b/sysdeps/x86_64/multiarch/memset-vec-unaligned-erms.S @@ -110,6 +110,8 @@ ENTRY (__memset_erms) ENTRY (MEMSET_SYMBOL (__memset, erms)) # endif L(stosb): + /* Issue vzeroupper before rep stosb. */ + VZEROUPPER movq %rdx, %rcx movzbl %sil, %eax movq %rdi, %rdx -- 2.9.3