From patchwork Thu Sep 28 00:21:40 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: "H.J. Lu" X-Patchwork-Id: 23188 Received: (qmail 74131 invoked by alias); 28 Sep 2017 00:21:45 -0000 Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libc-alpha-owner@sourceware.org Delivered-To: mailing list libc-alpha@sourceware.org Received: (qmail 74119 invoked by uid 89); 28 Sep 2017 00:21:44 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-25.0 required=5.0 tests=AWL, BAYES_00, FREEMAIL_FROM, GIT_PATCH_0, GIT_PATCH_1, GIT_PATCH_2, GIT_PATCH_3, RCVD_IN_DNSWL_NONE, RCVD_IN_SORBS_SPAM, SPF_PASS autolearn=ham version=3.3.2 spammy= X-HELO: mail-oi0-f67.google.com X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=ylywmR4cXsHbE8hNtQS3RH6C86VMsdl55UI73vCkleY=; b=UgkEmuPQzYuStEdr3elAzU4UhC+J4PGHf6ttiBAbING7HtnsLhkxR0PAY8YDZf6Ahx HulQ42X5TGNxY4NiiOl2bCoE1JuiooetvC4s+DjdrMAW9GxGrbzV/OOlMFqfWTZF5bli 9Wlt8qvhNxVARUv9dx3YkLDJF9Ym3skjeVzdKPbOVZdyJJROiPtTDqC/yfl2mdQei5oK 8QORol2Ixsd6hQA4zdAlTOQSit1SaRh4kAomqGi6exV5Xbg1/wRAm4DpxYfVDbVdQGLP e7Kwr4vJQzZL2UQxnNiaIhUN0yi45WIn0nip/0uh3YZ/AOdgYjzUoAeo/J/ciquYvzjj XxIA== X-Gm-Message-State: AHPjjUjb2aONFBKj/YCi8Ci+RIXQQbn9wwIZdJCtuhK10nfhraF0B9Fv Jbp6r8ZnmYgixuWKWoaGcvNkC9n6PMq9zVKBRUg= X-Google-Smtp-Source: AOwi7QDvS4fvuiI7hqpS1S3cPpLmyd0e9HeWiuHjmZyyatJV4+kjXQz+m+QSjMfhXnT5uDozDte2Iq3YC8Q56jB7SSg= X-Received: by 10.202.75.137 with SMTP id y131mr632440oia.430.1506558101103; Wed, 27 Sep 2017 17:21:41 -0700 (PDT) MIME-Version: 1.0 In-Reply-To: <20170927231742.9050-5-samuel.thibault@ens-lyon.org> References: <20170927231742.9050-1-samuel.thibault@ens-lyon.org> <20170927231742.9050-5-samuel.thibault@ens-lyon.org> From: "H.J. Lu" Date: Wed, 27 Sep 2017 17:21:40 -0700 Message-ID: Subject: Re: [hurd,commited 4/4] hurd: Fix `getifaddrs' and `freeifaddrs' symbol exposition To: Samuel Thibault Cc: libc-alpha@sourceware.org On 9/27/17, Samuel Thibault wrote: > from `freeaddrinfo'. > > `getifaddrs' and `freeifaddrs' are not in POSIX, they should not be > exposed along `freeaddrinfo' (through `__check_pf') which is POSIX. > > * include/ifaddrs.h (__getifaddrs, __freeifaddrs): New declarations, > and use libc_hidden_def on them. > * inet/ifaddrs.c (__getifaddrs, __freeifaddrs): Use libc_hidden_def on > them. > * sysdeps/gnu/ifaddrs.c (__getifaddrs, __freeifaddrs): Likewise. > * inet/check_pf.c (__check_pf): Use __getifaddrs and __freeifaddrs > instead of getifaddrs and freeifaddrs. > I checked in this patch to fix Linux build. From 7edd06916d0f18714f323b180b890f1fea39e1ff Mon Sep 17 00:00:00 2001 From: "H.J. Lu" Date: Wed, 27 Sep 2017 17:18:32 -0700 Subject: [PATCH] Update sysdeps/unix/sysv/linux/ifaddrs.c MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Fix ../sysdeps/unix/sysv/linux/ifaddrs.c:835:27: error: ‘getifaddrs’ aliased to undefined symbol ‘__getifaddrs’ weak_alias (__getifaddrs, getifaddrs) ^ ../sysdeps/unix/sysv/linux/ifaddrs.c:844:28: error: ‘freeifaddrs’ aliased to undefined symbol ‘__freeifaddrs’ weak_alias (__freeifaddrs, freeifaddrs) caused by commit 4009ddc69225d571772aaea597615a0c032e14ab Author: Samuel Thibault Date: Thu Sep 28 00:19:18 2017 +0200 hurd: Fix `getifaddrs' and `freeifaddrs' symbol exposition * sysdeps/unix/sysv/linux/ifaddrs.c (__getifaddrs): Add libc_hidden_def. (__freeifaddrs): Likewise. --- ChangeLog | 6 ++++++ sysdeps/unix/sysv/linux/ifaddrs.c | 2 ++ 2 files changed, 8 insertions(+) diff --git a/ChangeLog b/ChangeLog index 8e26c003a8..2e29752af7 100644 --- a/ChangeLog +++ b/ChangeLog @@ -1,3 +1,9 @@ +2017-09-27 H.J. Lu + + * sysdeps/unix/sysv/linux/ifaddrs.c (__getifaddrs): Add + libc_hidden_def. + (__freeifaddrs): Likewise. + 2017-09-27 Samuel Thibault * include/dirent.h (__dirfd): New declaration. diff --git a/sysdeps/unix/sysv/linux/ifaddrs.c b/sysdeps/unix/sysv/linux/ifaddrs.c index f25f67a129..0594afeecf 100644 --- a/sysdeps/unix/sysv/linux/ifaddrs.c +++ b/sysdeps/unix/sysv/linux/ifaddrs.c @@ -833,6 +833,7 @@ __getifaddrs (struct ifaddrs **ifap) return res; } weak_alias (__getifaddrs, getifaddrs) +libc_hidden_def (__getifaddrs) libc_hidden_weak (getifaddrs) @@ -842,4 +843,5 @@ __freeifaddrs (struct ifaddrs *ifa) free (ifa); } weak_alias (__freeifaddrs, freeifaddrs) +libc_hidden_def (__freeifaddrs) libc_hidden_weak (freeifaddrs) -- 2.13.5