From patchwork Tue Jan 6 16:25:50 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "H.J. Lu" X-Patchwork-Id: 4528 Received: (qmail 5640 invoked by alias); 6 Jan 2015 16:25:56 -0000 Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libc-alpha-owner@sourceware.org Delivered-To: mailing list libc-alpha@sourceware.org Received: (qmail 5630 invoked by uid 89); 6 Jan 2015 16:25:55 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=0.4 required=5.0 tests=AWL, BAYES_99, FREEMAIL_FROM, RCVD_IN_DNSWL_LOW, SPF_PASS autolearn=no version=3.3.2 X-HELO: mail-oi0-f47.google.com MIME-Version: 1.0 X-Received: by 10.202.198.133 with SMTP id w127mr53262439oif.74.1420561550840; Tue, 06 Jan 2015 08:25:50 -0800 (PST) In-Reply-To: <20141009171455.CB1F12C3AD1@topped-with-meat.com> References: <5435AD75.1060405@linux.vnet.ibm.com> <20141008215213.8B44D2C3AC5@topped-with-meat.com> <54369E9D.5020201@linux.vnet.ibm.com> <20141009171455.CB1F12C3AD1@topped-with-meat.com> Date: Tue, 6 Jan 2015 08:25:50 -0800 Message-ID: Subject: Re: [PATCH 2/8] Function declaration cleanup From: "H.J. Lu" To: Roland McGrath Cc: Adhemerval Zanella , GNU C Library On Thu, Oct 9, 2014 at 10:14 AM, Roland McGrath wrote: >> On 08-10-2014 18:52, Roland McGrath wrote: >> > This sort of change should get the "no disassembly of compiled code >> > changed" test rather than the vanilla "no regressions" test. With that >> > testing, changes like this can count as "obvious enough". >> > >> Thanks, I compared the dissassembly of compiled code and it shows no change. >> Is that ok to apply? > > Yes. What I meant to communicate is that whenever you have a > prototypification change, just verifying that it doesn't change the > compiled code is enough to commit it without explicit approval from > another person. (Of course it never hurts to let people look it over for > typos or bad indentation or whatever, but when you're confident you got > those trivia correct, you can just commit without waiting for replies.) > I am cleaning up patchwork queue. I checked in this patch. From 14bb4e57c094849228ad8524693ab9432c38396c Mon Sep 17 00:00:00 2001 From: Adhemerval Zanella Date: Tue, 6 Jan 2015 08:22:41 -0800 Subject: [PATCH] Function declaration cleanup This patch changes the some function declaration from K&R style to default ANSI C. * nptl/pthread_cancel.c (pthread_cancel): Use ANSI prototype. * nptl/pthread_cond_timedwait.c (__pthread_cond_timedwait): Likewise. * nptl/pthread_cond_wait.c (__pthread_cond_wait): Likewise. * nptl/pthread_exit.c (__pthread_exit): Likewise. * nptl/pthread_join.c (pthread_join): Likewise. * nptl/pthread_timedjoin.c (pthread_timedjoin_np): Likewise. * sysdeps/posix/waitid.c (__waitid): Likewise. * sysdeps/unix/sysv/linux/arm/pread.c (__libc_pread): Likewise. * sysdeps/unix/sysv/linux/arm/pread64.c (__libc_pread64): Likewise. * sysdeps/unix/sysv/linux/arm/pwrite.c (__libc_pwrite): Likewise. * sysdeps/unix/sysv/linux/arm/pwrite64.c (__libc_pwrite64): Likewise. * sysdeps/unix/sysv/linux/generic/wordsize-32/pread.c (__libc_pread): Likewise. * sysdeps/unix/sysv/linux/generic/wordsize-32/pread64.c (__libc_pread64): Likewise. * sysdeps/unix/sysv/linux/generic/wordsize-32/pwrite.c (__libc_pwrite): Likewise. * sysdeps/unix/sysv/linux/generic/wordsize-32/pwrite64.c (__libc_pwrite64): Likewsie. * sysdeps/unix/sysv/linux/mips/pread.c (__libc_pread): Likewise. * sysdeps/unix/sysv/linux/mips/pread64.c (__libc_pread64): Likewise. * sysdeps/unix/sysv/linux/mips/pwrite.c (__libc_pwrite): Likewise. * sysdeps/unix/sysv/linux/mips/pwrite64.c (__libc_pwrite64): Likewise. * sysdeps/unix/sysv/linux/msgrcv.c (__libc_msgrcv): Likewise. * sysdeps/unix/sysv/linux/msgsnd.c (__libc_msgsnd): Likewise. * sysdeps/unix/sysv/linux/openat.c (OPENAT_NOT_CANCEL): Likewise. * sysdeps/unix/sysv/linux/powerpc/powerpc32/pread.c (__libc_pread): Likewise. * sysdeps/unix/sysv/linux/powerpc/powerpc32/pread64.c (__libc_pread64): Likewise. * sysdeps/unix/sysv/linux/powerpc/powerpc32/pwrite.c (__libc_pwrite): Likewise. * sysdeps/unix/sysv/linux/powerpc/powerpc32/pwrite64.c (__libc_pwrite64): Likewise. * sysdeps/unix/sysv/linux/pread.c (__libc_pread): Likewise. * sysdeps/unix/sysv/linux/pread64.c (__libc_pread64): Likewise. * sysdeps/unix/sysv/linux/preadv.c (PREADV): Likewise. * sysdeps/unix/sysv/linux/pthread_kill.c (__pthread_kill): Likewise. * sysdeps/unix/sysv/linux/pwrite.c (__libc_pwrite): Likewise. * sysdeps/unix/sysv/linux/pwrite64.c (__libc_pwrite64): Likewise. * sysdeps/unix/sysv/linux/pwritev.c (__libc_pwritev): Likewise. * sysdeps/unix/sysv/linux/sh/pread.c (__libc_pread): Likewise. * sysdeps/unix/sysv/linux/sh/pread64.c (__libc_pread64): Likewise. * sysdeps/unix/sysv/linux/sh/pwrite.c (__libc_pwrite): Likewise. * sysdeps/unix/sysv/linux/sh/pwrite64.c (__libc_write64): Likewise. * sysdeps/unix/sysv/linux/sigsuspend.c (__sigsuspend): Likewise. * sysdeps/unix/sysv/linux/sigtimedwait.c (__sigtimedwait): Likewise. * sysdeps/unix/sysv/linux/sigwait.c (__sigwait): Likewise. * sysdeps/unix/sysv/linux/sigwaitinfo.c (__sigwaitinfo): Likewise. * sysdeps/unix/sysv/linux/sparc/sparc64/msgrcv.c (__libc_msgrcv): Likewise. --- ChangeLog | 54 ++++++++++++++++++++++ nptl/pthread_cancel.c | 3 +- nptl/pthread_cond_timedwait.c | 6 +-- nptl/pthread_cond_wait.c | 4 +- nptl/pthread_exit.c | 3 +- nptl/pthread_join.c | 4 +- nptl/pthread_timedjoin.c | 6 +-- sysdeps/posix/waitid.c | 6 +-- sysdeps/unix/sysv/linux/arm/pread.c | 6 +-- sysdeps/unix/sysv/linux/arm/pread64.c | 6 +-- sysdeps/unix/sysv/linux/arm/pwrite.c | 6 +-- sysdeps/unix/sysv/linux/arm/pwrite64.c | 6 +-- .../unix/sysv/linux/generic/wordsize-32/pread.c | 6 +-- .../unix/sysv/linux/generic/wordsize-32/pread64.c | 6 +-- .../unix/sysv/linux/generic/wordsize-32/pwrite.c | 6 +-- .../unix/sysv/linux/generic/wordsize-32/pwrite64.c | 6 +-- sysdeps/unix/sysv/linux/mips/pread.c | 6 +-- sysdeps/unix/sysv/linux/mips/pread64.c | 6 +-- sysdeps/unix/sysv/linux/mips/pwrite.c | 6 +-- sysdeps/unix/sysv/linux/mips/pwrite64.c | 6 +-- sysdeps/unix/sysv/linux/msgrcv.c | 8 +--- sysdeps/unix/sysv/linux/msgsnd.c | 6 +-- sysdeps/unix/sysv/linux/openat.c | 11 +---- sysdeps/unix/sysv/linux/powerpc/powerpc32/pread.c | 6 +-- .../unix/sysv/linux/powerpc/powerpc32/pread64.c | 6 +-- sysdeps/unix/sysv/linux/powerpc/powerpc32/pwrite.c | 6 +-- .../unix/sysv/linux/powerpc/powerpc32/pwrite64.c | 6 +-- sysdeps/unix/sysv/linux/pread.c | 6 +-- sysdeps/unix/sysv/linux/pread64.c | 6 +-- sysdeps/unix/sysv/linux/preadv.c | 6 +-- sysdeps/unix/sysv/linux/pthread_kill.c | 4 +- sysdeps/unix/sysv/linux/pwrite.c | 6 +-- sysdeps/unix/sysv/linux/pwrite64.c | 6 +-- sysdeps/unix/sysv/linux/pwritev.c | 6 +-- sysdeps/unix/sysv/linux/sh/pread.c | 6 +-- sysdeps/unix/sysv/linux/sh/pread64.c | 6 +-- sysdeps/unix/sysv/linux/sh/pwrite.c | 6 +-- sysdeps/unix/sysv/linux/sh/pwrite64.c | 6 +-- sysdeps/unix/sysv/linux/sigsuspend.c | 3 +- sysdeps/unix/sysv/linux/sigtimedwait.c | 6 +-- sysdeps/unix/sysv/linux/sigwait.c | 4 +- sysdeps/unix/sysv/linux/sigwaitinfo.c | 4 +- sysdeps/unix/sysv/linux/sparc/sparc64/msgrcv.c | 8 +--- 43 files changed, 102 insertions(+), 194 deletions(-) diff --git a/ChangeLog b/ChangeLog index 3e2e176..bcaf007 100644 --- a/ChangeLog +++ b/ChangeLog @@ -1,3 +1,57 @@ +2015-01-06 Adhemerval Zanella + + * nptl/pthread_cancel.c (pthread_cancel): Use ANSI prototype. + * nptl/pthread_cond_timedwait.c (__pthread_cond_timedwait): Likewise. + * nptl/pthread_cond_wait.c (__pthread_cond_wait): Likewise. + * nptl/pthread_exit.c (__pthread_exit): Likewise. + * nptl/pthread_join.c (pthread_join): Likewise. + * nptl/pthread_timedjoin.c (pthread_timedjoin_np): Likewise. + * sysdeps/posix/waitid.c (__waitid): Likewise. + * sysdeps/unix/sysv/linux/arm/pread.c (__libc_pread): Likewise. + * sysdeps/unix/sysv/linux/arm/pread64.c (__libc_pread64): Likewise. + * sysdeps/unix/sysv/linux/arm/pwrite.c (__libc_pwrite): Likewise. + * sysdeps/unix/sysv/linux/arm/pwrite64.c (__libc_pwrite64): Likewise. + * sysdeps/unix/sysv/linux/generic/wordsize-32/pread.c (__libc_pread): + Likewise. + * sysdeps/unix/sysv/linux/generic/wordsize-32/pread64.c + (__libc_pread64): Likewise. + * sysdeps/unix/sysv/linux/generic/wordsize-32/pwrite.c + (__libc_pwrite): Likewise. + * sysdeps/unix/sysv/linux/generic/wordsize-32/pwrite64.c + (__libc_pwrite64): Likewsie. + * sysdeps/unix/sysv/linux/mips/pread.c (__libc_pread): Likewise. + * sysdeps/unix/sysv/linux/mips/pread64.c (__libc_pread64): Likewise. + * sysdeps/unix/sysv/linux/mips/pwrite.c (__libc_pwrite): Likewise. + * sysdeps/unix/sysv/linux/mips/pwrite64.c (__libc_pwrite64): Likewise. + * sysdeps/unix/sysv/linux/msgrcv.c (__libc_msgrcv): Likewise. + * sysdeps/unix/sysv/linux/msgsnd.c (__libc_msgsnd): Likewise. + * sysdeps/unix/sysv/linux/openat.c (OPENAT_NOT_CANCEL): Likewise. + * sysdeps/unix/sysv/linux/powerpc/powerpc32/pread.c (__libc_pread): + Likewise. + * sysdeps/unix/sysv/linux/powerpc/powerpc32/pread64.c + (__libc_pread64): Likewise. + * sysdeps/unix/sysv/linux/powerpc/powerpc32/pwrite.c (__libc_pwrite): + Likewise. + * sysdeps/unix/sysv/linux/powerpc/powerpc32/pwrite64.c + (__libc_pwrite64): Likewise. + * sysdeps/unix/sysv/linux/pread.c (__libc_pread): Likewise. + * sysdeps/unix/sysv/linux/pread64.c (__libc_pread64): Likewise. + * sysdeps/unix/sysv/linux/preadv.c (PREADV): Likewise. + * sysdeps/unix/sysv/linux/pthread_kill.c (__pthread_kill): Likewise. + * sysdeps/unix/sysv/linux/pwrite.c (__libc_pwrite): Likewise. + * sysdeps/unix/sysv/linux/pwrite64.c (__libc_pwrite64): Likewise. + * sysdeps/unix/sysv/linux/pwritev.c (__libc_pwritev): Likewise. + * sysdeps/unix/sysv/linux/sh/pread.c (__libc_pread): Likewise. + * sysdeps/unix/sysv/linux/sh/pread64.c (__libc_pread64): Likewise. + * sysdeps/unix/sysv/linux/sh/pwrite.c (__libc_pwrite): Likewise. + * sysdeps/unix/sysv/linux/sh/pwrite64.c (__libc_write64): Likewise. + * sysdeps/unix/sysv/linux/sigsuspend.c (__sigsuspend): Likewise. + * sysdeps/unix/sysv/linux/sigtimedwait.c (__sigtimedwait): Likewise. + * sysdeps/unix/sysv/linux/sigwait.c (__sigwait): Likewise. + * sysdeps/unix/sysv/linux/sigwaitinfo.c (__sigwaitinfo): Likewise. + * sysdeps/unix/sysv/linux/sparc/sparc64/msgrcv.c (__libc_msgrcv): + Likewise. + 2015-01-06 Andrew Senkevich * math/Makefile (CFLAGS-test-float.c): Remove -frounding-math. diff --git a/nptl/pthread_cancel.c b/nptl/pthread_cancel.c index 0691eda..981e4bc 100644 --- a/nptl/pthread_cancel.c +++ b/nptl/pthread_cancel.c @@ -25,8 +25,7 @@ int -pthread_cancel (th) - pthread_t th; +pthread_cancel (pthread_t th) { volatile struct pthread *pd = (volatile struct pthread *) th; diff --git a/nptl/pthread_cond_timedwait.c b/nptl/pthread_cond_timedwait.c index 7c1d35d..bf80467 100644 --- a/nptl/pthread_cond_timedwait.c +++ b/nptl/pthread_cond_timedwait.c @@ -49,10 +49,8 @@ struct _condvar_cleanup_buffer }; int -__pthread_cond_timedwait (cond, mutex, abstime) - pthread_cond_t *cond; - pthread_mutex_t *mutex; - const struct timespec *abstime; +__pthread_cond_timedwait (pthread_cond_t *cond, pthread_mutex_t *mutex, + const struct timespec *abstime) { struct _pthread_cleanup_buffer buffer; struct _condvar_cleanup_buffer cbuffer; diff --git a/nptl/pthread_cond_wait.c b/nptl/pthread_cond_wait.c index 63dcd5e..0d6558b 100644 --- a/nptl/pthread_cond_wait.c +++ b/nptl/pthread_cond_wait.c @@ -98,9 +98,7 @@ __condvar_cleanup (void *arg) int -__pthread_cond_wait (cond, mutex) - pthread_cond_t *cond; - pthread_mutex_t *mutex; +__pthread_cond_wait (pthread_cond_t *cond, pthread_mutex_t *mutex) { struct _pthread_cleanup_buffer buffer; struct _condvar_cleanup_buffer cbuffer; diff --git a/nptl/pthread_exit.c b/nptl/pthread_exit.c index 83a9ff7..a60adbd 100644 --- a/nptl/pthread_exit.c +++ b/nptl/pthread_exit.c @@ -21,8 +21,7 @@ void -__pthread_exit (value) - void *value; +__pthread_exit (void *value) { THREAD_SETMEM (THREAD_SELF, result, value); diff --git a/nptl/pthread_join.c b/nptl/pthread_join.c index fde1862..c841ff9 100644 --- a/nptl/pthread_join.c +++ b/nptl/pthread_join.c @@ -37,9 +37,7 @@ cleanup (void *arg) int -pthread_join (threadid, thread_return) - pthread_t threadid; - void **thread_return; +pthread_join (pthread_t threadid, void **thread_return) { struct pthread *pd = (struct pthread *) threadid; diff --git a/nptl/pthread_timedjoin.c b/nptl/pthread_timedjoin.c index 5cd516b..10567e6 100644 --- a/nptl/pthread_timedjoin.c +++ b/nptl/pthread_timedjoin.c @@ -30,10 +30,8 @@ cleanup (void *arg) int -pthread_timedjoin_np (threadid, thread_return, abstime) - pthread_t threadid; - void **thread_return; - const struct timespec *abstime; +pthread_timedjoin_np (pthread_t threadid, void **thread_return, + const struct timespec *abstime) { struct pthread *self; struct pthread *pd = (struct pthread *) threadid; diff --git a/sysdeps/posix/waitid.c b/sysdeps/posix/waitid.c index 508c8c7..de41227 100644 --- a/sysdeps/posix/waitid.c +++ b/sysdeps/posix/waitid.c @@ -149,11 +149,7 @@ OUR_WAITID (idtype_t idtype, id_t id, siginfo_t *infop, int options) int -__waitid (idtype, id, infop, options) - idtype_t idtype; - id_t id; - siginfo_t *infop; - int options; +__waitid (idtype_t idtype, id_t id, siginfo_t *infop, int options) { if (SINGLE_THREAD_P) return do_waitid (idtype, id, infop, options); diff --git a/sysdeps/unix/sysv/linux/arm/pread.c b/sysdeps/unix/sysv/linux/arm/pread.c index 5ae8f45..64bc0a1 100644 --- a/sysdeps/unix/sysv/linux/arm/pread.c +++ b/sysdeps/unix/sysv/linux/arm/pread.c @@ -24,11 +24,7 @@ #include ssize_t -__libc_pread (fd, buf, count, offset) - int fd; - void *buf; - size_t count; - off_t offset; +__libc_pread (int fd, void *buf, size_t count, off_t offset) { ssize_t result; diff --git a/sysdeps/unix/sysv/linux/arm/pread64.c b/sysdeps/unix/sysv/linux/arm/pread64.c index 8de750a..7860699 100644 --- a/sysdeps/unix/sysv/linux/arm/pread64.c +++ b/sysdeps/unix/sysv/linux/arm/pread64.c @@ -24,11 +24,7 @@ #include ssize_t -__libc_pread64 (fd, buf, count, offset) - int fd; - void *buf; - size_t count; - off64_t offset; +__libc_pread64 (int fd, void *buf, size_t count, off64_t offset) { ssize_t result; diff --git a/sysdeps/unix/sysv/linux/arm/pwrite.c b/sysdeps/unix/sysv/linux/arm/pwrite.c index b0b8755..11a963c 100644 --- a/sysdeps/unix/sysv/linux/arm/pwrite.c +++ b/sysdeps/unix/sysv/linux/arm/pwrite.c @@ -24,11 +24,7 @@ #include ssize_t -__libc_pwrite (fd, buf, count, offset) - int fd; - const void *buf; - size_t count; - off_t offset; +__libc_pwrite (int fd, const void *buf, size_t count, off_t offset) { ssize_t result; diff --git a/sysdeps/unix/sysv/linux/arm/pwrite64.c b/sysdeps/unix/sysv/linux/arm/pwrite64.c index ffa84df..9cb67ff 100644 --- a/sysdeps/unix/sysv/linux/arm/pwrite64.c +++ b/sysdeps/unix/sysv/linux/arm/pwrite64.c @@ -24,11 +24,7 @@ #include ssize_t -__libc_pwrite64 (fd, buf, count, offset) - int fd; - const void *buf; - size_t count; - off64_t offset; +__libc_pwrite64 (int fd, const void *buf, size_t count, off64_t offset) { ssize_t result; diff --git a/sysdeps/unix/sysv/linux/generic/wordsize-32/pread.c b/sysdeps/unix/sysv/linux/generic/wordsize-32/pread.c index 3e8dbd6..ad97e97 100644 --- a/sysdeps/unix/sysv/linux/generic/wordsize-32/pread.c +++ b/sysdeps/unix/sysv/linux/generic/wordsize-32/pread.c @@ -35,11 +35,7 @@ do_pread (int fd, void *buf, size_t count, off_t offset) } ssize_t -__libc_pread (fd, buf, count, offset) - int fd; - void *buf; - size_t count; - off_t offset; +__libc_pread (int fd, void *buf, size_t count, off_t offset) { if (SINGLE_THREAD_P) return do_pread (fd, buf, count, offset); diff --git a/sysdeps/unix/sysv/linux/generic/wordsize-32/pread64.c b/sysdeps/unix/sysv/linux/generic/wordsize-32/pread64.c index 9241b32..7250893 100644 --- a/sysdeps/unix/sysv/linux/generic/wordsize-32/pread64.c +++ b/sysdeps/unix/sysv/linux/generic/wordsize-32/pread64.c @@ -35,11 +35,7 @@ do_pread64 (int fd, void *buf, size_t count, off64_t offset) ssize_t -__libc_pread64 (fd, buf, count, offset) - int fd; - void *buf; - size_t count; - off64_t offset; +__libc_pread64 (int fd, void *buf, size_t count, off64_t offset) { if (SINGLE_THREAD_P) return do_pread64 (fd, buf, count, offset); diff --git a/sysdeps/unix/sysv/linux/generic/wordsize-32/pwrite.c b/sysdeps/unix/sysv/linux/generic/wordsize-32/pwrite.c index c4c7a76..e897c7d 100644 --- a/sysdeps/unix/sysv/linux/generic/wordsize-32/pwrite.c +++ b/sysdeps/unix/sysv/linux/generic/wordsize-32/pwrite.c @@ -36,11 +36,7 @@ do_pwrite (int fd, const void *buf, size_t count, off_t offset) ssize_t -__libc_pwrite (fd, buf, count, offset) - int fd; - const void *buf; - size_t count; - off_t offset; +__libc_pwrite (int fd, const void *buf, size_t count, off_t offset) { if (SINGLE_THREAD_P) return do_pwrite (fd, buf, count, offset); diff --git a/sysdeps/unix/sysv/linux/generic/wordsize-32/pwrite64.c b/sysdeps/unix/sysv/linux/generic/wordsize-32/pwrite64.c index 8ffc6b5..3ac1339 100644 --- a/sysdeps/unix/sysv/linux/generic/wordsize-32/pwrite64.c +++ b/sysdeps/unix/sysv/linux/generic/wordsize-32/pwrite64.c @@ -35,11 +35,7 @@ do_pwrite64 (int fd, const void *buf, size_t count, off64_t offset) ssize_t -__libc_pwrite64 (fd, buf, count, offset) - int fd; - const void *buf; - size_t count; - off64_t offset; +__libc_pwrite64 (int fd, const void *buf, size_t count, off64_t offset) { if (SINGLE_THREAD_P) return do_pwrite64 (fd, buf, count, offset); diff --git a/sysdeps/unix/sysv/linux/mips/pread.c b/sysdeps/unix/sysv/linux/mips/pread.c index 50247be..c301067 100644 --- a/sysdeps/unix/sysv/linux/mips/pread.c +++ b/sysdeps/unix/sysv/linux/mips/pread.c @@ -36,11 +36,7 @@ ssize_t -__libc_pread (fd, buf, count, offset) - int fd; - void *buf; - size_t count; - off_t offset; +__libc_pread (int fd, void *buf, size_t count, off_t offset): { ssize_t result; diff --git a/sysdeps/unix/sysv/linux/mips/pread64.c b/sysdeps/unix/sysv/linux/mips/pread64.c index 42e52da..ad948aa 100644 --- a/sysdeps/unix/sysv/linux/mips/pread64.c +++ b/sysdeps/unix/sysv/linux/mips/pread64.c @@ -35,11 +35,7 @@ ssize_t -__libc_pread64 (fd, buf, count, offset) - int fd; - void *buf; - size_t count; - off64_t offset; +__libc_pread64 (int fd, void *buf, size_t count, off64_t offset) { ssize_t result; diff --git a/sysdeps/unix/sysv/linux/mips/pwrite.c b/sysdeps/unix/sysv/linux/mips/pwrite.c index 4dd9690..2c38e04 100644 --- a/sysdeps/unix/sysv/linux/mips/pwrite.c +++ b/sysdeps/unix/sysv/linux/mips/pwrite.c @@ -36,11 +36,7 @@ ssize_t -__libc_pwrite (fd, buf, count, offset) - int fd; - const void *buf; - size_t count; - off_t offset; +__libc_pwrite (int fd, const void *buf, size_t count, off_t offset) { ssize_t result; diff --git a/sysdeps/unix/sysv/linux/mips/pwrite64.c b/sysdeps/unix/sysv/linux/mips/pwrite64.c index 1c548b9..504c88a 100644 --- a/sysdeps/unix/sysv/linux/mips/pwrite64.c +++ b/sysdeps/unix/sysv/linux/mips/pwrite64.c @@ -35,11 +35,7 @@ ssize_t -__libc_pwrite64 (fd, buf, count, offset) - int fd; - const void *buf; - size_t count; - off64_t offset; +__libc_pwrite64 (int fd, const void *buf, size_t count, off64_t offset) { ssize_t result; diff --git a/sysdeps/unix/sysv/linux/msgrcv.c b/sysdeps/unix/sysv/linux/msgrcv.c index 8acaa89..1c3698c 100644 --- a/sysdeps/unix/sysv/linux/msgrcv.c +++ b/sysdeps/unix/sysv/linux/msgrcv.c @@ -33,12 +33,8 @@ struct ipc_kludge ssize_t -__libc_msgrcv (msqid, msgp, msgsz, msgtyp, msgflg) - int msqid; - void *msgp; - size_t msgsz; - long int msgtyp; - int msgflg; +__libc_msgrcv (int msqid, void *msgp, size_t msgsz, long int msgtyp, + int msgflg) { /* The problem here is that Linux' calling convention only allows up to fives parameters to a system call. */ diff --git a/sysdeps/unix/sysv/linux/msgsnd.c b/sysdeps/unix/sysv/linux/msgsnd.c index 2c354d8..d548aab 100644 --- a/sysdeps/unix/sysv/linux/msgsnd.c +++ b/sysdeps/unix/sysv/linux/msgsnd.c @@ -24,11 +24,7 @@ #include int -__libc_msgsnd (msqid, msgp, msgsz, msgflg) - int msqid; - const void *msgp; - size_t msgsz; - int msgflg; +__libc_msgsnd (int msqid, const void *msgp, size_t msgsz, int msgflg) { if (SINGLE_THREAD_P) return INLINE_SYSCALL (ipc, 5, IPCOP_msgsnd, msqid, msgsz, diff --git a/sysdeps/unix/sysv/linux/openat.c b/sysdeps/unix/sysv/linux/openat.c index 95c9808..5145823 100644 --- a/sysdeps/unix/sysv/linux/openat.c +++ b/sysdeps/unix/sysv/linux/openat.c @@ -37,11 +37,7 @@ int -OPENAT_NOT_CANCEL (fd, file, oflag, mode) - int fd; - const char *file; - int oflag; - mode_t mode; +OPENAT_NOT_CANCEL (int fd, const char *file, int oflag, mode_t mode) { /* We have to add the O_LARGEFILE flag for openat64. */ @@ -61,10 +57,7 @@ OPENAT_NOT_CANCEL (fd, file, oflag, mode) the directory associated with FD. If OFLAG includes O_CREAT, a third argument is the file protection. */ int -__OPENAT (fd, file, oflag) - int fd; - const char *file; - int oflag; +__OPENAT (int fd, const char *file, int oflag, ...) { mode_t mode = 0; if (oflag & O_CREAT) diff --git a/sysdeps/unix/sysv/linux/powerpc/powerpc32/pread.c b/sysdeps/unix/sysv/linux/powerpc/powerpc32/pread.c index 6b7d712..10763f5 100644 --- a/sysdeps/unix/sysv/linux/powerpc/powerpc32/pread.c +++ b/sysdeps/unix/sysv/linux/powerpc/powerpc32/pread.c @@ -24,11 +24,7 @@ #include ssize_t -__libc_pread (fd, buf, count, offset) - int fd; - void *buf; - size_t count; - off_t offset; +__libc_pread (int fd, void *buf, size_t count, off_t offset) { ssize_t result; diff --git a/sysdeps/unix/sysv/linux/powerpc/powerpc32/pread64.c b/sysdeps/unix/sysv/linux/powerpc/powerpc32/pread64.c index 6229d48..f3dc7e5 100644 --- a/sysdeps/unix/sysv/linux/powerpc/powerpc32/pread64.c +++ b/sysdeps/unix/sysv/linux/powerpc/powerpc32/pread64.c @@ -24,11 +24,7 @@ ssize_t -__libc_pread64 (fd, buf, count, offset) - int fd; - void *buf; - size_t count; - off64_t offset; +__libc_pread64 (int fd, void *buf, size_t count, off64_t offset) { ssize_t result; diff --git a/sysdeps/unix/sysv/linux/powerpc/powerpc32/pwrite.c b/sysdeps/unix/sysv/linux/powerpc/powerpc32/pwrite.c index e70d507..65109ed 100644 --- a/sysdeps/unix/sysv/linux/powerpc/powerpc32/pwrite.c +++ b/sysdeps/unix/sysv/linux/powerpc/powerpc32/pwrite.c @@ -25,11 +25,7 @@ ssize_t -__libc_pwrite (fd, buf, count, offset) - int fd; - const void *buf; - size_t count; - off_t offset; +__libc_pwrite (int fd, const void *buf, size_t count, off_t offset) { ssize_t result; diff --git a/sysdeps/unix/sysv/linux/powerpc/powerpc32/pwrite64.c b/sysdeps/unix/sysv/linux/powerpc/powerpc32/pwrite64.c index 080645d..77749c9 100644 --- a/sysdeps/unix/sysv/linux/powerpc/powerpc32/pwrite64.c +++ b/sysdeps/unix/sysv/linux/powerpc/powerpc32/pwrite64.c @@ -24,11 +24,7 @@ ssize_t -__libc_pwrite64 (fd, buf, count, offset) - int fd; - const void *buf; - size_t count; - off64_t offset; +__libc_pwrite64 (int fd, const void *buf, size_t count, off64_t offset) { ssize_t result; diff --git a/sysdeps/unix/sysv/linux/pread.c b/sysdeps/unix/sysv/linux/pread.c index 3c60bfb..5c1b174 100644 --- a/sysdeps/unix/sysv/linux/pread.c +++ b/sysdeps/unix/sysv/linux/pread.c @@ -49,11 +49,7 @@ do_pread (int fd, void *buf, size_t count, off_t offset) ssize_t -__libc_pread (fd, buf, count, offset) - int fd; - void *buf; - size_t count; - off_t offset; +__libc_pread (int fd, void *buf, size_t count, off_t offset) { if (SINGLE_THREAD_P) return do_pread (fd, buf, count, offset); diff --git a/sysdeps/unix/sysv/linux/pread64.c b/sysdeps/unix/sysv/linux/pread64.c index 137b402..a8cfb5d 100644 --- a/sysdeps/unix/sysv/linux/pread64.c +++ b/sysdeps/unix/sysv/linux/pread64.c @@ -45,11 +45,7 @@ do_pread64 (int fd, void *buf, size_t count, off64_t offset) ssize_t -__libc_pread64 (fd, buf, count, offset) - int fd; - void *buf; - size_t count; - off64_t offset; +__libc_pread64 (int fd, void *buf, size_t count, off64_t offset) { if (SINGLE_THREAD_P) return do_pread64 (fd, buf, count, offset); diff --git a/sysdeps/unix/sysv/linux/preadv.c b/sysdeps/unix/sysv/linux/preadv.c index c9b7df9..091f9a7 100644 --- a/sysdeps/unix/sysv/linux/preadv.c +++ b/sysdeps/unix/sysv/linux/preadv.c @@ -48,11 +48,7 @@ static ssize_t PREADV_REPLACEMENT (int, const struct iovec *, ssize_t -PREADV (fd, vector, count, offset) - int fd; - const struct iovec *vector; - int count; - OFF_T offset; +PREADV (int fd, const struct iovec *vector, int count, OFF_T offset) { #ifdef __NR_preadv ssize_t result; diff --git a/sysdeps/unix/sysv/linux/pthread_kill.c b/sysdeps/unix/sysv/linux/pthread_kill.c index 7951fa7..8e8996a 100644 --- a/sysdeps/unix/sysv/linux/pthread_kill.c +++ b/sysdeps/unix/sysv/linux/pthread_kill.c @@ -24,9 +24,7 @@ int -__pthread_kill (threadid, signo) - pthread_t threadid; - int signo; +__pthread_kill (pthread_t threadid, int signo) { struct pthread *pd = (struct pthread *) threadid; diff --git a/sysdeps/unix/sysv/linux/pwrite.c b/sysdeps/unix/sysv/linux/pwrite.c index 678aeb9..80c2e22 100644 --- a/sysdeps/unix/sysv/linux/pwrite.c +++ b/sysdeps/unix/sysv/linux/pwrite.c @@ -49,11 +49,7 @@ do_pwrite (int fd, const void *buf, size_t count, off_t offset) ssize_t -__libc_pwrite (fd, buf, count, offset) - int fd; - const void *buf; - size_t count; - off_t offset; +__libc_pwrite (int fd, const void *buf, size_t count, off_t offset) { if (SINGLE_THREAD_P) return do_pwrite (fd, buf, count, offset); diff --git a/sysdeps/unix/sysv/linux/pwrite64.c b/sysdeps/unix/sysv/linux/pwrite64.c index 2c133ab..7fce75a 100644 --- a/sysdeps/unix/sysv/linux/pwrite64.c +++ b/sysdeps/unix/sysv/linux/pwrite64.c @@ -45,11 +45,7 @@ do_pwrite64 (int fd, const void *buf, size_t count, off64_t offset) ssize_t -__libc_pwrite64 (fd, buf, count, offset) - int fd; - const void *buf; - size_t count; - off64_t offset; +__libc_pwrite64 (int fd, const void *buf, size_t count, off64_t offset) { if (SINGLE_THREAD_P) return do_pwrite64 (fd, buf, count, offset); diff --git a/sysdeps/unix/sysv/linux/pwritev.c b/sysdeps/unix/sysv/linux/pwritev.c index 847a0ed..91e58b5 100644 --- a/sysdeps/unix/sysv/linux/pwritev.c +++ b/sysdeps/unix/sysv/linux/pwritev.c @@ -48,11 +48,7 @@ static ssize_t PWRITEV_REPLACEMENT (int, const struct iovec *, ssize_t -PWRITEV (fd, vector, count, offset) - int fd; - const struct iovec *vector; - int count; - OFF_T offset; +PWRITEV (int fd, const struct iovec *vector, int count, OFF_T offset) { #ifdef __NR_pwritev ssize_t result; diff --git a/sysdeps/unix/sysv/linux/sh/pread.c b/sysdeps/unix/sysv/linux/sh/pread.c index 9135212..9d4b5de 100644 --- a/sysdeps/unix/sysv/linux/sh/pread.c +++ b/sysdeps/unix/sysv/linux/sh/pread.c @@ -33,11 +33,7 @@ ssize_t -__libc_pread (fd, buf, count, offset) - int fd; - void *buf; - size_t count; - off_t offset; +__libc_pread (int fd, void *buf, size_t count, off_t offset) { ssize_t result; diff --git a/sysdeps/unix/sysv/linux/sh/pread64.c b/sysdeps/unix/sysv/linux/sh/pread64.c index 185b514..195eacc 100644 --- a/sysdeps/unix/sysv/linux/sh/pread64.c +++ b/sysdeps/unix/sysv/linux/sh/pread64.c @@ -32,11 +32,7 @@ ssize_t -__libc_pread64 (fd, buf, count, offset) - int fd; - void *buf; - size_t count; - off64_t offset; +__libc_pread64 (int fd, void *buf, size_t count, off64_t offset) { ssize_t result; diff --git a/sysdeps/unix/sysv/linux/sh/pwrite.c b/sysdeps/unix/sysv/linux/sh/pwrite.c index bc22ee1..c187d0a 100644 --- a/sysdeps/unix/sysv/linux/sh/pwrite.c +++ b/sysdeps/unix/sysv/linux/sh/pwrite.c @@ -33,11 +33,7 @@ ssize_t -__libc_pwrite (fd, buf, count, offset) - int fd; - const void *buf; - size_t count; - off_t offset; +__libc_pwrite (int fd, const void *buf, size_t count, off_t offset) { ssize_t result; diff --git a/sysdeps/unix/sysv/linux/sh/pwrite64.c b/sysdeps/unix/sysv/linux/sh/pwrite64.c index 7d04f22..0d15ca2 100644 --- a/sysdeps/unix/sysv/linux/sh/pwrite64.c +++ b/sysdeps/unix/sysv/linux/sh/pwrite64.c @@ -32,11 +32,7 @@ ssize_t -__libc_pwrite64 (fd, buf, count, offset) - int fd; - const void *buf; - size_t count; - off64_t offset; +__libc_pwrite64 (int fd, const void *buf, size_t count, off64_t offset) { ssize_t result; diff --git a/sysdeps/unix/sysv/linux/sigsuspend.c b/sysdeps/unix/sysv/linux/sigsuspend.c index c44455b..89c5d65 100644 --- a/sysdeps/unix/sysv/linux/sigsuspend.c +++ b/sysdeps/unix/sysv/linux/sigsuspend.c @@ -32,8 +32,7 @@ do_sigsuspend (const sigset_t *set) /* Change the set of blocked signals to SET, wait until a signal arrives, and restore the set of blocked signals. */ int -__sigsuspend (set) - const sigset_t *set; +__sigsuspend (const sigset_t *set) { if (SINGLE_THREAD_P) return do_sigsuspend (set); diff --git a/sysdeps/unix/sysv/linux/sigtimedwait.c b/sysdeps/unix/sysv/linux/sigtimedwait.c index 9b2d934..209198e 100644 --- a/sysdeps/unix/sysv/linux/sigtimedwait.c +++ b/sysdeps/unix/sysv/linux/sigtimedwait.c @@ -67,10 +67,8 @@ do_sigtimedwait (const sigset_t *set, siginfo_t *info, /* Return any pending signal or wait for one for the given time. */ int -__sigtimedwait (set, info, timeout) - const sigset_t *set; - siginfo_t *info; - const struct timespec *timeout; +__sigtimedwait (const sigset_t *set, siginfo_t *info, + const struct timespec *timeout) { if (SINGLE_THREAD_P) return do_sigtimedwait (set, info, timeout); diff --git a/sysdeps/unix/sysv/linux/sigwait.c b/sysdeps/unix/sysv/linux/sigwait.c index c21550b..26c3241 100644 --- a/sysdeps/unix/sysv/linux/sigwait.c +++ b/sysdeps/unix/sysv/linux/sigwait.c @@ -86,9 +86,7 @@ do_sigwait (const sigset_t *set, int *sig) } int -__sigwait (set, sig) - const sigset_t *set; - int *sig; +__sigwait (const sigset_t *set, int *sig) { if (SINGLE_THREAD_P) return do_sigwait (set, sig); diff --git a/sysdeps/unix/sysv/linux/sigwaitinfo.c b/sysdeps/unix/sysv/linux/sigwaitinfo.c index 9d6c215..fe23c9f 100644 --- a/sysdeps/unix/sysv/linux/sigwaitinfo.c +++ b/sysdeps/unix/sysv/linux/sigwaitinfo.c @@ -68,9 +68,7 @@ do_sigwaitinfo (const sigset_t *set, siginfo_t *info) /* Return any pending signal or wait for one for the given time. */ int -__sigwaitinfo (set, info) - const sigset_t *set; - siginfo_t *info; +__sigwaitinfo (const sigset_t *set, siginfo_t *info) { if (SINGLE_THREAD_P) return do_sigwaitinfo (set, info); diff --git a/sysdeps/unix/sysv/linux/sparc/sparc64/msgrcv.c b/sysdeps/unix/sysv/linux/sparc/sparc64/msgrcv.c index 1f256f5..8928060 100644 --- a/sysdeps/unix/sysv/linux/sparc/sparc64/msgrcv.c +++ b/sysdeps/unix/sysv/linux/sparc/sparc64/msgrcv.c @@ -23,12 +23,8 @@ #include ssize_t -__libc_msgrcv (msqid, msgp, msgsz, msgtyp, msgflg) - int msqid; - void *msgp; - size_t msgsz; - long int msgtyp; - int msgflg; +__libc_msgrcv (int msqid, void *msgp, size_t msgsz, long int msgtyp, + int msgflg) { if (SINGLE_THREAD_P) return INLINE_SYSCALL (ipc, 6, IPCOP_msgrcv, msqid, msgsz, msgflg, -- 1.9.3