diff mbox

Test for profiling support (_mcount/gprof)

Message ID CAMe9rOr_3mW2urQ2xvhpQv_pCu=QOnCeVrADx2TtzRtFcXuBXA@mail.gmail.com
State New, archived
Headers show

Commit Message

H.J. Lu Aug. 17, 2017, 11:57 a.m. UTC
On Thu, Aug 17, 2017 at 12:44 AM, Florian Weimer <fweimer@redhat.com> wrote:
> On 08/16/2017 11:19 PM, H.J. Lu wrote:
>> -pg and -pie are mutually exclusive since they need different crt1.o,
>> gcrrt1.o vs Scrt1.o.  Make -pg overrdies -pie.
>>
>>       * Makeconfig (+link-pie-before-libc): Add CRT-* hook to override
>>       the startup object.
>
> Typo (gcrrt1.o), and the commit message is confusing.  There is no -pg
> involved at the linking stage.
>
> gcrt1.o is deliberately compiled so that it is compatible with PIE, so
> the patch itself is okay.

This is what I checked in.
diff mbox

Patch

diff --git a/Makeconfig b/Makeconfig
index 5f2469116c..b51904b797 100644
--- a/Makeconfig
+++ b/Makeconfig
@@ -409,7 +409,7 @@  ifndef +link-pie
 +link-pie-before-libc = $(CC) -pie -Wl,-O1 -nostdlib -nostartfiles -o $@ \
      $(sysdep-LDFLAGS) $(LDFLAGS) $(LDFLAGS-$(@F)) \
      $(combreloc-LDFLAGS) $(relro-LDFLAGS) $(hashstyle-LDFLAGS) \
-     $(addprefix $(csu-objpfx),S$(start-installed-name)) \
+     $(firstword $(CRT-$(@F)) $(csu-objpfx)S$(start-installed-name)) \
      $(+preinit) $(+prectorS) \
      $(filter-out $(addprefix $(csu-objpfx),start.o \
     S$(start-installed-name))\