From patchwork Mon Dec 11 16:42:48 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "H.J. Lu" X-Patchwork-Id: 24856 Received: (qmail 111200 invoked by alias); 11 Dec 2017 16:42:52 -0000 Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libc-alpha-owner@sourceware.org Delivered-To: mailing list libc-alpha@sourceware.org Received: (qmail 111190 invoked by uid 89); 11 Dec 2017 16:42:52 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-25.4 required=5.0 tests=AWL, BAYES_00, FREEMAIL_FROM, GIT_PATCH_0, GIT_PATCH_1, GIT_PATCH_2, GIT_PATCH_3, RCVD_IN_DNSWL_NONE, SPF_PASS autolearn=ham version=3.3.2 spammy=Everywhere X-HELO: mail-oi0-f54.google.com X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=cll58mqupegA0j88lTlwikodUz/UhkMyHdeEWKV3rCk=; b=GOutlE5XkTRZJ5dZ3OIaKlPQwZq/Ld7WimF+QQaCZn6SYRQGsHp+A0ZPLHeQ0T6AVP 46MYjfgENya71zoETcnAgpLGAyV1Ik8XrSyTr96N2CwJGIxLqYeKsVnSYkvw2+eHhYtt /ISN2rdoa5dazw2GxB4JkLuVz4AzKTQOQcEnnyPx7fdXqIppBsaKT6w/oLK/2V06+/iZ hn3KSKkRgG1I2HRCegab2xunD4o77Eqemvj9Rm5bELJPYoHhBIS3b0QP35YBPumzQSu0 rYBZfLAaR0hEbVw5JP0P1rjC0BJjjDheTgD5boS/wVpxqlh134yrZpGZckG4YpEJ9A1Z EXBg== X-Gm-Message-State: AKGB3mLSDtcJZqax8uUb4x5Okn8cgAMw6eN3dOmwha/2o9HrpIB1Q53L j0k++I8BkNS4fvzk9KEElZYZ/wNpdZVtjF0nETv7HA== X-Google-Smtp-Source: ACJfBostp0BfinvTvp6tNRYUi0YeogvHSj4sowd2agBlAdb4xPjS8bRAZMDlphz6qLyT9NyZJz8a+rqM2k2fkJIpbOk= X-Received: by 10.202.252.67 with SMTP id a64mr792623oii.303.1513010569279; Mon, 11 Dec 2017 08:42:49 -0800 (PST) MIME-Version: 1.0 In-Reply-To: References: <20171211131849.GA35836@intel.com> From: "H.J. Lu" Date: Mon, 11 Dec 2017 08:42:48 -0800 Message-ID: Subject: Re: [PATCH] string: Replace = with += in CFLAGS-tst-xbzero-opt.c To: Andreas Schwab Cc: GNU C Library On Mon, Dec 11, 2017 at 5:39 AM, Andreas Schwab wrote: > On Dez 11 2017, "H.J. Lu" wrote: > >> On Mon, Dec 11, 2017 at 5:32 AM, Andreas Schwab wrote: >>> On Dez 11 2017, "H.J. Lu" wrote: >>> >>>> Replace = with += in CFLAGS-tst-xbzero-opt.c to allow sysdeps Makefile >>>> to define CFLAGS-tst-xbzero-opt.c. >>>> >>>> Any comments? >>>> >>>> H.J. >>>> * string/Makefile (CFLAGS-tst-xbzero-opt.c): Replace = with +=. >>> >>> I think that should be done for all such assignments. >>> >> >> By "all", did you mean CFLAGS-xxx in */Makefile or CFLAGS-xxx in >> string/Makefile? > > Everywhere, if you like to work on that. I am checking in this patch to cover string/Makefile. I will submit a separate patch for */Makefile. From 9f0006a8825b6f1baae948f08cdf01d1e5277e51 Mon Sep 17 00:00:00 2001 From: "H.J. Lu" Date: Mon, 11 Dec 2017 04:18:24 -0800 Subject: [PATCH] string: Replace = with += in CFLAGS-xxx.c Replace = with += in CFLAGS-xxx.c to allow Makefile under sysdeps to define CFLAGS-xx.c. * string/Makefile (CFLAGS-inl-tester.c): Replace = with +=. (CFLAGS-noinl-tester.c): Likewise. (CFLAGS-tst-strlen.c): Likewise. (CFLAGS-stratcliff.c): Likewise. (CFLAGS-test-ffs.c): Likewise. (CFLAGS-tst-inlcall.c): Likewise. (CFLAGS-tst-xbzero-opt.c): Likewise. (CFLAGS-memcpy.c): Likewise. (CFLAGS-wordcopy.c): Likewise. --- string/Makefile | 18 +++++++++--------- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/string/Makefile b/string/Makefile index d7e90a38a5..74ba4f2f76 100644 --- a/string/Makefile +++ b/string/Makefile @@ -69,13 +69,13 @@ endif include ../Rules -CFLAGS-inl-tester.c = -fno-builtin -CFLAGS-noinl-tester.c = -fno-builtin -CFLAGS-tst-strlen.c = -fno-builtin -CFLAGS-stratcliff.c = -fno-builtin -CFLAGS-test-ffs.c = -fno-builtin -CFLAGS-tst-inlcall.c = -fno-builtin -CFLAGS-tst-xbzero-opt.c = -O3 +CFLAGS-inl-tester.c += -fno-builtin +CFLAGS-noinl-tester.c += -fno-builtin +CFLAGS-tst-strlen.c += -fno-builtin +CFLAGS-stratcliff.c += -fno-builtin +CFLAGS-test-ffs.c += -fno-builtin +CFLAGS-tst-inlcall.c += -fno-builtin +CFLAGS-tst-xbzero-opt.c += -O3 # BZ 21006: Resolve all functions but at least explicit_bzero at startup. # Otherwise the test fails on s390x as the memcpy in prepare_test_buffer is # done by loading r4 / r5 with the test_pattern and using store multiple @@ -86,8 +86,8 @@ CFLAGS-tst-xbzero-opt.c = -O3 LDFLAGS-tst-xbzero-opt = -z now # Called during TLS initialization. -CFLAGS-memcpy.c = $(no-stack-protector) -CFLAGS-wordcopy.c = $(no-stack-protector) +CFLAGS-memcpy.c += $(no-stack-protector) +CFLAGS-wordcopy.c += $(no-stack-protector) ifeq ($(run-built-tests),yes) $(objpfx)tst-svc-cmp.out: tst-svc.expect $(objpfx)tst-svc.out -- 2.14.3