From patchwork Tue Jan 4 15:00:40 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "H.J. Lu" X-Patchwork-Id: 49530 Return-Path: X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id B3CE5385842C for ; Tue, 4 Jan 2022 15:01:39 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org B3CE5385842C DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1641308499; bh=HnxWux/dMxZKlBc9FFZl2uLU5WiL4oTWiW3SS9FFMU0=; h=References:In-Reply-To:Date:Subject:To:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=W4hwfVvUeqIBMAQNkVfSecJVJ9G2BaGl1QXb+wumLPHPi6JDud9py1qfpbaFqDuq3 Cz9FBhXSjvWOOlY1SgwD0klwng1m11a5WWJPtITbDwWvtju+SFmRoku/stf5SLuM6m JAA/3jjyHrmu1DVy5wt8iir53QIoTGXYXAxkPLGg= X-Original-To: libc-alpha@sourceware.org Delivered-To: libc-alpha@sourceware.org Received: from mail-pf1-x42f.google.com (mail-pf1-x42f.google.com [IPv6:2607:f8b0:4864:20::42f]) by sourceware.org (Postfix) with ESMTPS id 6782F3858405 for ; Tue, 4 Jan 2022 15:01:17 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 6782F3858405 Received: by mail-pf1-x42f.google.com with SMTP id v13so32450291pfi.3 for ; Tue, 04 Jan 2022 07:01:17 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=HnxWux/dMxZKlBc9FFZl2uLU5WiL4oTWiW3SS9FFMU0=; b=sTmlAOILOUNAxJR9Bmbxc6Or/Y+M5CiU4Y3zDAzozpsU99jW9tfklOTuqxVArF7Riy LAFzD0UfQw5x6ZKGe7JoIoZN0D07DaxMgcKGYiljni8jOwFLx1hCGe1HtvioeM/1hJpN HOLXGyGuB3U2kF9+qYe3v8QI1S+DLvkBnCT2JYFJtrNUp80ZY/FOpfvGluodf6GP5kAz ekIcct29Cl2qnVd8rPMiOTNhvxa0GyWp4IYA4dTXFQXxv5JTgQ1DxINSs4/nLYB0Mbcg dkVPxH7bvWIZYLp7s14bLH8oBiMgb1uzidU9sqT3ML48q5br4bdUMHUSd4BSt7BzRZo9 fFDw== X-Gm-Message-State: AOAM531v2QnVLuhykOHXlMDAKUaJxE1SpL42Tjm9uufU9q1CfUUPG58y VBNyJFon7RX6ZLjVsR7CTpJsONk8vr7wKcMqSLU= X-Google-Smtp-Source: ABdhPJwwBo3n1pGMBBm88Ff5NxsIu3rTNiBKqQ9170vTDlN+Uhd/v+SKOnShC6+gtsrLVKj5ak4CvJ1a8RWHCgbyYfo= X-Received: by 2002:a63:6116:: with SMTP id v22mr45193034pgb.381.1641308476255; Tue, 04 Jan 2022 07:01:16 -0800 (PST) MIME-Version: 1.0 References: <20220103233243.2031364-1-hjl.tools@gmail.com> <87zgob3nh1.fsf@igel.home> <87tuej3702.fsf@igel.home> <87r19nftzb.fsf@oldenburg.str.redhat.com> In-Reply-To: <87r19nftzb.fsf@oldenburg.str.redhat.com> Date: Tue, 4 Jan 2022 07:00:40 -0800 Message-ID: Subject: [PATCH] elf: Add a comment after trailing backslashes To: Florian Weimer X-Spam-Status: No, score=-3027.5 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: "H.J. Lu via Libc-alpha" From: "H.J. Lu" Reply-To: "H.J. Lu" Cc: "H.J. Lu via Libc-alpha" , Andreas Schwab Errors-To: libc-alpha-bounces+patchwork=sourceware.org@sourceware.org Sender: "Libc-alpha" On Tue, Jan 4, 2022 at 6:36 AM Florian Weimer wrote: > > * Andreas Schwab: > > > On Jan 04 2022, H.J. Lu wrote: > > > >> On Tue, Jan 4, 2022 at 12:38 AM Andreas Schwab wrote: > >>> > >>> On Jan 03 2022, H.J. Lu via Libc-alpha wrote: > >>> > >>> > +tests-cxx = \ > >>> > + tst-dlopen-nodelete-reloc \ > >>> > + tst-nodelete \ > >>> > + tst-unique3 \ > >>> > + tst-unique4 \ > >>> > + > >>> > >>> > + vismod1 \ > >>> > + vismod2 \ > >>> > + vismod3 \ > >>> > + > >>> > >>> > + tst-unique3lib \ > >>> > + tst-unique3lib2 \ > >>> > + tst-unique4lib \ > >>> > + > >>> > +modules-names += \ > >>> > + $(if $(CXX),$(modules-names-cxx)) \ > >>> > + $(modules-execstack-$(have-z-execstack)) \ > >>> > + $(tst-tls-many-dynamic-modules) \ > >>> > + $(tst-tls-many-dynamic-modules-dep) \ > >>> > + $(tst-tls-many-dynamic-modules-dep-bad) \ > >>> > + $(tlsmod17a-modules) \ > >>> > + $(tlsmod18a-modules) \ > >>> > >>> > >>> Trailing backslashes are no good. > >> > >> It was added so that only one line is needed when appending > >> to the list. > > > > The blank lines can easily get lost. > > That's why I use comments, so: > > +modules-names += \ > + $(if $(CXX),$(modules-names-cxx)) \ > + $(modules-execstack-$(have-z-execstack)) \ > + $(tst-tls-many-dynamic-modules) \ > + $(tst-tls-many-dynamic-modules-dep) \ > + $(tst-tls-many-dynamic-modules-dep-bad) \ > + $(tlsmod17a-modules) \ > + $(tlsmod18a-modules) \ > + # modules-names Good suggestion. I am checking in this. Thanks. From f4f70c2895e3d325188a42c10eb7bb4335be6773 Mon Sep 17 00:00:00 2001 From: "H.J. Lu" Date: Tue, 4 Jan 2022 06:58:34 -0800 Subject: [PATCH] elf: Add a comment after trailing backslashes --- elf/Makefile | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/elf/Makefile b/elf/Makefile index 8eb7e6e5d9..b86d116be9 100644 --- a/elf/Makefile +++ b/elf/Makefile @@ -333,6 +333,7 @@ tests-cxx = \ tst-nodelete \ tst-unique3 \ tst-unique4 \ +# tests-cxx tests += $(if $(CXX),$(tests-cxx)) tests-internal += loadtest unload unload2 circleload1 \ @@ -626,6 +627,7 @@ modules-names = \ vismod1 \ vismod2 \ vismod3 \ +# modules-names modules-names-cxx = \ tst-dlopen-nodelete-reloc-mod1 \ @@ -651,6 +653,7 @@ modules-names-cxx = \ tst-unique3lib \ tst-unique3lib2 \ tst-unique4lib \ +# modules-names-cxx modules-names += \ $(if $(CXX),$(modules-names-cxx)) \ @@ -660,6 +663,7 @@ modules-names += \ $(tst-tls-many-dynamic-modules-dep-bad) \ $(tlsmod17a-modules) \ $(tlsmod18a-modules) \ +# modules-names # Most modules build with _ISOMAC defined, but those filtered out # depend on internal headers. -- 2.33.1