From patchwork Wed Oct 4 00:01:31 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: "H.J. Lu" X-Patchwork-Id: 23317 Received: (qmail 65728 invoked by alias); 4 Oct 2017 00:01:41 -0000 Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libc-alpha-owner@sourceware.org Delivered-To: mailing list libc-alpha@sourceware.org Received: (qmail 65671 invoked by uid 89); 4 Oct 2017 00:01:36 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-24.9 required=5.0 tests=AWL, BAYES_00, FREEMAIL_FROM, GIT_PATCH_0, GIT_PATCH_1, GIT_PATCH_2, GIT_PATCH_3, RCVD_IN_DNSWL_NONE, RCVD_IN_SORBS_SPAM, SPF_PASS autolearn=ham version=3.3.2 spammy=HTo:D*br X-HELO: mail-oi0-f66.google.com X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=LRCxATCYbtsoPg1QWqAksz1CLCfs7y9Qlt6Dafm1NTE=; b=uUahy8UYrzeaiP01544FDK59gU0QnI7rZk+FrHgZBA8bXrH/beUlB/hbE8nuCNv3um zaYGuCOEN2oAoOE6ULKuICgweFtZW26W79TAfp4n7Ho9eeOWF+L/ZQiF/cqR2Dbv4K88 Zb2ugZR+2knF9ibEsjBDCZbckuFKBLSQDhFwQg5fPEGxjrQanjM9H1BE47BO9D0UYC3O eg05SnbCWvzab81Dhw2EHCVS9Q3rzQbjpZ22QytMOQJz52XxMTfsZlX/RebuInD73p7D WvILYAXvsi4NJY9VeMlxzyx/OVLQvrQQAdMnYOVJshvijsqxMvQJyd9bYVVIkBvbrQBI 1stg== X-Gm-Message-State: AMCzsaV+E+7kqRTzRgAeQTzzYfrPA39TWMdMRsxIy6AnXzQJwZjfkgIy DUSMLSBF0R5EcNRfg7+9ey9Qdp+nsc3JUgaOFoY= X-Google-Smtp-Source: AOwi7QAOXGWumdO1qng3//TCaYnqsV0ts8Ts3XWXBFgDEUT95kzBM9btqc+WrcBsyF3uRFyjvrsrq6a9X1aaUTngrec= X-Received: by 10.157.10.129 with SMTP id 1mr10164762otq.201.1507075292396; Tue, 03 Oct 2017 17:01:32 -0700 (PDT) MIME-Version: 1.0 In-Reply-To: References: <20171003140307.22359-1-gabriel@inconstante.eti.br> <20171003161028.116fd41a@keller.br.ibm.com> From: "H.J. Lu" Date: Tue, 3 Oct 2017 17:01:31 -0700 Message-ID: Subject: Re: [PATCH] Add C++ versions of iscanonical for ldbl-96 and ldbl-128ibm To: "Gabriel F. T. Gomes" Cc: Joseph Myers , libc-alpha@sourceware.org On 10/3/17, H.J. Lu wrote: > On 10/3/17, Gabriel F. T. Gomes wrote: >> On 03 Oct 2017, Joseph Myers wrote: >> >>>> +/* In C++ mode, __MATH_TG cannot be used, because it relies on >>>> + __builtin_types_compatible_p, which is a C-only builtin. On the >>>> + other hand, overloading provides the means to distinguish between >>>> + the floating-point types. The overloading resolution will match >>>> + the correct parameter (regardless of type qualifiers (i.e.: const >>>> + and volatile). */ >>> >>>(twice in this patch, and once already in math.h) is missing a second >>>close parenthesis to match the first open parenthesis, and should be >>>fixed. >> >> Thanks. Pushed with these changes. >> >> > > On i686 wit GCC 7, I got > > test-math-iscanonical.cc: In function ‘void check_type()’: > test-math-iscanonical.cc:33:11: error: use of an operand of type > ‘bool’ in ‘operator++’ is deprecated [-Werror=deprecated] > errors++; > ^~ > test-math-iscanonical.cc: In instantiation of ‘void check_type() [with > T = float]’: > test-math-iscanonical.cc:39:22: required from here > test-math-iscanonical.cc:33:11: error: use of an operand of type > ‘bool’ in ‘operator++’ is deprecated [-Werror=deprecated] > errors++; > ~~~~~~^~ > I am testing this: diff --git a/math/test-math-iscanonical.cc b/math/test-math-iscanonical.cc index aba68acb4f..8ced7a73b4 100644 --- a/math/test-math-iscanonical.cc +++ b/math/test-math-iscanonical.cc @@ -20,7 +20,7 @@ #include #include -static bool errors; +static int errors; template static void