diff mbox

Remove Roland McGrath et al. from libc.so banner

Message ID CAMe9rOoQWKkzTNFpyPKjV+wUYitzcS0XsnRrNiYoGrn9GvaqqA@mail.gmail.com
State New, archived
Headers show

Commit Message

H.J. Lu Sept. 1, 2017, 4:26 p.m. UTC
On Wed, Jul 26, 2017 at 12:06 PM, Carlos O'Donell <carlos@redhat.com> wrote:
> On 07/26/2017 03:04 PM, H.J. Lu wrote:
>> On Wed, Jul 26, 2017 at 11:50 AM, Dmitry V. Levin <ldv@altlinux.org> wrote:
>>> On Wed, Jul 26, 2017 at 10:24:24AM -0700, H.J. Lu wrote:
>>>> I will check it today if there is no objection.
>>>>
>>>> H.J.
>>>
>>> There might be configure scripts in the wild that rely on the current
>>> format of this banner, so please do not change it before the release.
>>
>> Did you mean that it can never be changed?
>
> I think the point was to avoid the change without giving distributions
> time to catch up during a development cycle. For example in Fedora we
> would catch this in Rawhide. So make the change as early as possible
> when 2.27 opens.
>

This is what I am going to check in:

* csu/version.c (banner): Remove "by Roland McGrath et al.".
* nptl/Banner: Remove "by Ulrich Drepper et al.".

Comments

Carlos O'Donell Sept. 1, 2017, 4:35 p.m. UTC | #1
On 09/01/2017 11:26 AM, H.J. Lu wrote:
> On Wed, Jul 26, 2017 at 12:06 PM, Carlos O'Donell <carlos@redhat.com> wrote:
>> On 07/26/2017 03:04 PM, H.J. Lu wrote:
>>> On Wed, Jul 26, 2017 at 11:50 AM, Dmitry V. Levin <ldv@altlinux.org> wrote:
>>>> On Wed, Jul 26, 2017 at 10:24:24AM -0700, H.J. Lu wrote:
>>>>> I will check it today if there is no objection.
>>>>>
>>>>> H.J.
>>>>
>>>> There might be configure scripts in the wild that rely on the current
>>>> format of this banner, so please do not change it before the release.
>>>
>>> Did you mean that it can never be changed?
>>
>> I think the point was to avoid the change without giving distributions
>> time to catch up during a development cycle. For example in Fedora we
>> would catch this in Rawhide. So make the change as early as possible
>> when 2.27 opens.
>>
> 
> This is what I am going to check in:
> 
> * csu/version.c (banner): Remove "by Roland McGrath et al.".
> * nptl/Banner: Remove "by Ulrich Drepper et al.".
> 
> 

Looks good to me.
Joseph Myers Sept. 1, 2017, 4:41 p.m. UTC | #2
On Fri, 1 Sep 2017, H.J. Lu wrote:

> This is what I am going to check in:
> 
> * csu/version.c (banner): Remove "by Roland McGrath et al.".
> * nptl/Banner: Remove "by Ulrich Drepper et al.".

Please see what I said about being sure to update contrib.texi when 
removing such credits.  I think NPTL merits adding to Ulrich Drepper's 
entry in contrib.texi (but given that, the nptl/Banner file could be 
removed completely).

I think crypt/Banner can be removed (the credit is already in 
contrib.texi).  The reference to a BIND version in contrib.texi should 
probably be updated when removing resolv/Banner.  More credits in 
contrib.texi are needed to remove soft-fp/Banner.  (libidn/Banner serves 
the purpose of indicating whether the last remaining add-on is configured 
in, so I don't suggest removing it until the add-on mechanism is also 
removed and libidn is built unconditionally - however, the corresponding 
credit could be added to contrib.texi now.)
diff mbox

Patch

From fbaa05c6642d9cc64f28037de18aed62a578502a Mon Sep 17 00:00:00 2001
From: "H.J. Lu" <hjl.tools@gmail.com>
Date: Wed, 26 Jul 2017 10:21:31 -0700
Subject: [PATCH] Remove Roland McGrath/Ulrich Drepper et al. from DSO banner

	* csu/version.c (banner): Remove "by Roland McGrath et al.".
	* nptl/Banner: Remove "by Ulrich Drepper et al.".
---
 csu/version.c | 2 +-
 nptl/Banner   | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/csu/version.c b/csu/version.c
index e0d884dbf3..f3992ab6c8 100644
--- a/csu/version.c
+++ b/csu/version.c
@@ -24,7 +24,7 @@  static const char __libc_release[] = RELEASE;
 static const char __libc_version[] = VERSION;
 
 static const char banner[] =
-"GNU C Library "PKGVERSION RELEASE" release version "VERSION", by Roland McGrath et al.\n\
+"GNU C Library "PKGVERSION RELEASE" release version "VERSION".\n\
 Copyright (C) 2017 Free Software Foundation, Inc.\n\
 This is free software; see the source for copying conditions.\n\
 There is NO warranty; not even for MERCHANTABILITY or FITNESS FOR A\n\
diff --git a/nptl/Banner b/nptl/Banner
index 7c1487e7b6..8c88d52fdf 100644
--- a/nptl/Banner
+++ b/nptl/Banner
@@ -1 +1 @@ 
-Native POSIX Threads Library by Ulrich Drepper et al
+Native POSIX Threads Library
-- 
2.13.5