From patchwork Wed Feb 17 21:04:47 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andrew Senkevich X-Patchwork-Id: 10885 Received: (qmail 28593 invoked by alias); 17 Feb 2016 21:05:22 -0000 Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libc-alpha-owner@sourceware.org Delivered-To: mailing list libc-alpha@sourceware.org Received: (qmail 28538 invoked by uid 89); 17 Feb 2016 21:05:21 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.8 required=5.0 tests=AWL, BAYES_00, FREEMAIL_FROM, RCVD_IN_DNSWL_LOW, SPF_PASS autolearn=ham version=3.3.2 spammy=20160218, 2016-02-18, hongjiu.lu@intel.com, hongjiuluintelcom X-HELO: mail-lb0-f180.google.com X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc:content-type; bh=Vk6Y3afANi3Dm1eAmIhkoz8mef6imR2c8y199s6gcNM=; b=mhQynH+b98TegikjcA7pqV3PHjVw42iLhUP7DiFgBJFjdbS/votDdp/HMHJI9RWykU jocf2JbibRGZIuNBmjGOaSScgS3aLigs3ycAIvlPI3NZ83s+VXT1iQuNJjbXXJ7dbwP9 b/6UU3Aq9HSHK83REMJBMoA2APYVit8wbs+FWaQvGS/boihzJMmzaX+SFlF2ehdpfJT7 NGpmYnnxbpMwJR+3yNl2U0Au2xKsENbgkW1/WlNz1fhTrSv7KchaaljZa9ExU6iM8RIy wu6KeGcwdxHiMebb7qtEDTN95SYxZA+lS7Pyba7lX6hi9mnAaz0erdfSQZTVWfUHewlI JooA== X-Gm-Message-State: AG10YOSRSaulaVY05BARSPqbha15eB82vGvChDfpT3sEFMm585Vpqsn+tlKbzgTMfyaxhJLSNvxR9ZpcPBY1OQ== X-Received: by 10.112.161.225 with SMTP id xv1mr1679913lbb.127.1455743117521; Wed, 17 Feb 2016 13:05:17 -0800 (PST) MIME-Version: 1.0 In-Reply-To: References: From: Andrew Senkevich Date: Thu, 18 Feb 2016 00:04:47 +0300 Message-ID: Subject: Re: [PATCH] BZ #19590: Fixed build of shared objects that use libmvec.so functions To: "H.J. Lu" Cc: Joseph Myers , libc-alpha 2016-02-17 23:06 GMT+03:00 H.J. Lu : > On Wed, Feb 17, 2016 at 11:30 AM, Andrew Senkevich > wrote: >> 2016-02-17 21:44 GMT+03:00 Joseph Myers : >>> On Wed, 17 Feb 2016, Andrew Senkevich wrote: >>> >>>> Is attached version finally Ok for trunk? >>> >>> Please resubmit, with the coding style issues fixed and tests moved to >>> test-skeleton.c unless there's a reason they can't use it, after the >>> freeze is over. This is much too risky to consider during the freeze, and >>> would need to wait a while on master before any backports could be >>> considered (e.g. the new tests could break the testsuite build in some >>> configurations for unforeseen reasons). >> >> May be separate fix and tests to commit fix earlier? >> > > This is a good idea. Please submit a fix-only patch. 2016-02-18 Andrew Senkevich H.J. Lu [BZ #19590] * sysdeps/x86_64/fpu/svml_finite_alias.S (ALIAS_IMPL): Use PIC relocation. Ok to commit? --- WBR, Andrew diff --git a/sysdeps/x86_64/fpu/svml_finite_alias.S b/sysdeps/x86_64/fpu/svml_finite_alias.S index 0062fe4..2dcfc37 100644 --- a/sysdeps/x86_64/fpu/svml_finite_alias.S +++ b/sysdeps/x86_64/fpu/svml_finite_alias.S @@ -23,8 +23,7 @@ #define ALIAS_IMPL(alias, target) \ ENTRY (alias); \ - call target; \ - ret; \ + jmp *target@GOTPCREL(%rip); \ END (alias) .text