From patchwork Tue Feb 17 01:07:15 2015
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
X-Patchwork-Submitter: Paul Pluzhnikov <ppluzhnikov@gmail.com>
X-Patchwork-Id: 5101
Received: (qmail 13743 invoked by alias); 17 Feb 2015 01:07:51 -0000
Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <libc-alpha.sourceware.org>
List-Unsubscribe: <mailto:libc-alpha-unsubscribe-##L=##H@sourceware.org>
List-Subscribe: <mailto:libc-alpha-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/libc-alpha/>
List-Post: <mailto:libc-alpha@sourceware.org>
List-Help: <mailto:libc-alpha-help@sourceware.org>,
	<http://sourceware.org/ml/#faqs>
Sender: libc-alpha-owner@sourceware.org
Delivered-To: mailing list libc-alpha@sourceware.org
Received: (qmail 13723 invoked by uid 89); 17 Feb 2015 01:07:50 -0000
Authentication-Results: sourceware.org; auth=none
X-Virus-Found: No
X-Spam-SWARE-Status: No, score=0.6 required=5.0 tests=AWL, BAYES_00,
	FREEMAIL_FROM, KAM_FROM_URIBL_PCCC, RCVD_IN_DNSWL_LOW,
	SPF_PASS, T_RP_MATCHES_RCVD autolearn=no version=3.3.2
X-HELO: mail-vc0-f176.google.com
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
	d=1e100.net; s=20130820;
	h=x-gm-message-state:mime-version:sender:from:date:message-id:subject
	:to:content-type;
	bh=4k0HfztKr9/8EwMRqULzzD8yylJkYmlQdI00/t6frVk=;
	b=KFqYbjRtADAJYUS7+MxVrmgzJGUEBahihNFFkGcQcU+dgNs0HjzXl7JrtjBBIh6aDo
	u68+Cg/sv8cZN0r+RVSYX4YbD7mp39rzorYG2Gt4r1tcyGHQagBS18w4f8GocNMvj9iZ
	uNhcP2Dhes8YIBSJOSATtqXWOJotzqr5M5523JE9E1SDrm9Gev/mZ+AhnkJkwddu94GE
	ipoY3+TQhv53mMmI6LARxohOpXPACl2v810GDLIZzuBR/lFqzbzI4kKbTnpZdzrRKOzu
	HRPurfe7vmvP71xCCUdeNt+J07rt+p9CrnMX4bqEHkF4sPOjjneLsBc27XWWPw/uEXIe
	KYDQ==
X-Gm-Message-State: 
 ALoCoQm+LthsdOR7ic7AcA95c/jERT86MU8o2/Tb4UDwpraSh8oqBG23qAVEycFxYRSd7gnMRJuU
X-Received: by 10.52.73.40 with SMTP id i8mr14955492vdv.56.1424135267124;
	Mon, 16 Feb 2015 17:07:47 -0800 (PST)
MIME-Version: 1.0
From: Paul Pluzhnikov <ppluzhnikov@gmail.com>
Date: Mon, 16 Feb 2015 17:07:15 -0800
Message-ID: 
 <CALoOobNy2mS=YFF63Hjz_+ewDPtjRa+Jyo_tofUM+vVkrS3bYA@mail.gmail.com>
Subject: [patch] Fix failure to cleanup input-only stream buffers in
	preparation for BZ#16734 fix
To: GLIBC Devel <libc-alpha@sourceware.org>

Greetings,

In preparation for BZ#16734 fix, I've build libc with (not intended to commit):

 # include <fcntl.h>
... etc.

This results in 3 mtrace failures:

FAIL: misc/tst-error1-mem
FAIL: posix/bug-regex31-mem
FAIL: posix/tst-fnmatch-mem

The last two of them are because input-only FILE streams need the same
buffer cleanup as writable streams.

Attached patch fixes these two failures.


2015-02-16  Paul Pluzhnikov  <ppluzhnikov@google.com>

        * libio/genops.c (_IO_unbuffer_write): Cleanup read-only
streams as well.

diff --git a/libio/libioP.h b/libio/libioP.h
index d8604ca..d1699de 100644
--- a/libio/libioP.h
+++ b/libio/libioP.h
@@ -719,7 +719,7 @@ extern _IO_off64_t _IO_seekpos_unlocked (_IO_FILE
*, _IO_off64_t, int)
 # endif
 #endif

-#if _G_HAVE_MMAP
+#if _G_HAVE_MMAP && 0

 # include <unistd.h>