diff mbox

Delete references to --without-tls

Message ID CALoOobMvTX7TbqjNuKE++_g4Nx+Ay_YTqggDs8HQ9D5Mb2njeg@mail.gmail.com
State New, archived
Headers

Commit Message

Paul Pluzhnikov June 4, 2016, 7:58 p.m. UTC 
  Greetings,

This is on the rather obvious side. The --with{out}-tls was removed in
83cd14204 in 2011, but the manual and INSTALL haven't been updated to
match.


2016-06-04  Paul Pluzhnikov  <ppluzhnikov@google.com>

        * INSTALL: Remove mention of --without-tls
        * manual/install.texi: Likewise

Comments

Florian Weimer June 5, 2016, 3:10 p.m. UTC | #1 
On 06/04/2016 09:58 PM, Paul Pluzhnikov wrote:
> Greetings,
>
> This is on the rather obvious side. The --with{out}-tls was removed in
> 83cd14204 in 2011, but the manual and INSTALL haven't been updated to
> match.
>
>
> 2016-06-04  Paul Pluzhnikov  <ppluzhnikov@google.com>
>
>         * INSTALL: Remove mention of --without-tls
>         * manual/install.texi: Likewise

Change looks okay.  The ChangeLog should probably say “INSTALL: 
Regenerate.” because INSTALL is generated from the manual, I think.

Thanks,
Florian
Carlos O'Donell June 6, 2016, 9:08 p.m. UTC | #2 
On 06/05/2016 11:10 AM, Florian Weimer wrote:
> On 06/04/2016 09:58 PM, Paul Pluzhnikov wrote:
>> Greetings,
>>
>> This is on the rather obvious side. The --with{out}-tls was removed in
>> 83cd14204 in 2011, but the manual and INSTALL haven't been updated to
>> match.
>>
>>
>> 2016-06-04  Paul Pluzhnikov  <ppluzhnikov@google.com>
>>
>>         * INSTALL: Remove mention of --without-tls
>>         * manual/install.texi: Likewise
> 
> Change looks okay. The ChangeLog should probably say “INSTALL:
> Regenerate.” because INSTALL is generated from the manual, I think.
 
Correct.

https://sourceware.org/glibc/wiki/Regeneration

INSTALL is generated by makeinfo; run make INSTALL to regenerate it. Currently we use texinfo version 6.0.
diff mbox

Patch

diff --git a/INSTALL b/INSTALL
index 31e256d..ec3445f 100644
--- a/INSTALL
+++ b/INSTALL
@@ -116,12 +116,6 @@  will be used, and CFLAGS sets optimization options for the compiler.
      program linked statically with the NSS libraries cannot be
      dynamically reconfigured to use a different name database.
 
-'--without-tls'
-     By default the C library is built with support for thread-local
-     storage if the used tools support it.  By using '--without-tls'
-     this can be prevented though there generally is no reason since it
-     creates compatibility problems.
-
 '--enable-hardcoded-path-in-tests'
      By default, dynamic tests are linked to run with the installed C
      library.  This option hardcodes the newly built C library path in
diff --git a/manual/install.texi b/manual/install.texi
index 95021b4..79ee45f 100644
--- a/manual/install.texi
+++ b/manual/install.texi
@@ -146,12 +146,6 @@  This is not recommended because it defeats the purpose of NSS; a program
 linked statically with the NSS libraries cannot be dynamically
 reconfigured to use a different name database.
 
-@item --without-tls
-By default the C library is built with support for thread-local storage
-if the used tools support it.  By using @samp{--without-tls} this can be
-prevented though there generally is no reason since it creates
-compatibility problems.
-
 @item --enable-hardcoded-path-in-tests
 By default, dynamic tests are linked to run with the installed C library.
 This option hardcodes the newly built C library path in dynamic tests