From patchwork Thu Jan 30 12:53:18 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Wilco Dijkstra X-Patchwork-Id: 37620 Received: (qmail 122734 invoked by alias); 30 Jan 2020 12:53:32 -0000 Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libc-alpha-owner@sourceware.org Delivered-To: mailing list libc-alpha@sourceware.org Received: (qmail 122716 invoked by uid 89); 30 Jan 2020 12:53:31 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-20.2 required=5.0 tests=AWL, BAYES_00, GIT_PATCH_0, GIT_PATCH_1, GIT_PATCH_2, GIT_PATCH_3, RCVD_IN_DNSWL_NONE, SPF_HELO_PASS, SPF_PASS, UNPARSEABLE_RELAY autolearn=ham version=3.3.1 spammy= X-HELO: EUR03-VE1-obe.outbound.protection.outlook.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=mF+NQQqRzSDW6VdDoLcLsAg4fgA0LsD8JEGiYC8arfw=; b=0xlr9Fagzn5vJG6t8CH85oiNRTOydVyEJSUgpc+f7eVf4Q17kEbyLWkMFfrDminAhfxo82vEtcc7xOiuOpy21ZcQZUXIoABWE60e7kcSpk6EQdttFXDramDdGE/L7Z9NcctLNI62ckPRZWS1FzFtJ7VOE7uCKlCQUw9b+tAwKYU= Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; sourceware.org; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; sourceware.org; dmarc=bestguesspass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; X-CheckRecipientChecked: true X-CR-MTA-CID: fb9e488f1ec48a5f X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=FR5xtdT9o+WnA/Un96Ss6Ja3lLQM24QxPDnfKv009fjeTnj1pPT2gCM5dSWPbkJbEt/u+h5/G26ZONL3J2v3Tm/X1Dkk8eji/8+bkaiyT1mmWDRagNzstwrncVzuOD0W/PE/nJS1Db/Egy3UCZdBTaie+OmZEqy/YOfxGZLahwsbta3zf8uC1z+GNQvWNj1SxRFiZicmCodyA5i3mV25GjymeKPfXICkO3zQpu1t0hKAgd/Gr+fheUdDe4WhPXYNWhKoIDRFYBprY3/L+BmolwxNZbBe/LalBEm2j5yzJimRzd3+YFGzDr1/JoprvLhueks4wvG8IK3wAdFmVBdVxQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=mF+NQQqRzSDW6VdDoLcLsAg4fgA0LsD8JEGiYC8arfw=; b=kndCafefq+5du1f+dFB90efO1ILLFhzV4HGjtYBmrwkvMzQKJDRAev4Is7EdZKuXoUJyuyhWzSuZ1Q24oSDLFEEeAiTN8w7Riq2X8hDeyB0+dNzDGJCRWu1uTb1a3zBA9rz7/GcgLPDWOQLo3xKyRq3WGERNbn0jEHSpkRoaN2SDrXVOvPa5wqJQV/5IVpy9B3R37WblhdpzgLnivBrRJ/CoQWd1nPmV0FwNX6+Zm+HiQvdM08Bzv91eZrLqHITyQ2+aayuJgyq23PlesiDqzVMOv3LuY/33KlmG3Iosdx4n2t3/iQNK8RNapDsGQVw35r1QkqVqfc0qXQMqoLXgvw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=mF+NQQqRzSDW6VdDoLcLsAg4fgA0LsD8JEGiYC8arfw=; b=0xlr9Fagzn5vJG6t8CH85oiNRTOydVyEJSUgpc+f7eVf4Q17kEbyLWkMFfrDminAhfxo82vEtcc7xOiuOpy21ZcQZUXIoABWE60e7kcSpk6EQdttFXDramDdGE/L7Z9NcctLNI62ckPRZWS1FzFtJ7VOE7uCKlCQUw9b+tAwKYU= From: Wilco Dijkstra To: 'GNU C Library' Subject: PATCH] Fix comment about rounding in sin/cos Date: Thu, 30 Jan 2020 12:53:18 +0000 Message-ID: Authentication-Results-Original: spf=none (sender IP is ) smtp.mailfrom=Wilco.Dijkstra@arm.com; x-checkrecipientrouted: true x-ms-oob-tlc-oobclassifiers: OLM:883;OLM:883; X-Forefront-Antispam-Report-Untrusted: SFV:NSPM; SFS:(10009020)(4636009)(376002)(366004)(396003)(136003)(346002)(39860400002)(189003)(199004)(76116006)(186003)(66476007)(66556008)(7696005)(81166006)(81156014)(8676002)(5660300002)(6506007)(26005)(64756008)(66946007)(66446008)(478600001)(33656002)(71200400001)(316002)(86362001)(55016002)(2906002)(9686003)(6916009)(8936002)(966005)(52536014); DIR:OUT; SFP:1101; SCL:1; SRVR:AM5PR0801MB2050; H:AM5PR0801MB2035.eurprd08.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; received-spf: None (protection.outlook.com: arm.com does not designate permitted sender hosts) X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: VzQ9hx/6J0oSG1C8IBdxtUyW+935eXuoEnB48hdBq9roH0qKCpuBmvd/KthRlXGnjjSVvOfP1beugMrkhQn+iS9f8ExjSqFOdy5gWCZmHWCVHbiwJcB1gwDrXKTInqPX3ue77CM2BhNMwi9nBqtho3RYvM4LDyxu90GCq4hIHWkoM2s+VyXZNNH6oPnYzIUkzHZfaXDjLwkaYBPKafSRKi4j2G4/wcrnJoBu5OWsMiK60NQWiTvRoQqrP8BUwlg8GLTPIsa/mBDi+hbpHDjvT2VyFfSwn5GSBzt8LUbfeqaw6zLiK7AbhygmC6OvOT1Eg4Ux4tCR9mZa3ywsdAag3KesddQ4nleUs0a15PUUiW0ZvvfAOgjq8qaPicbTGVq/uREKrhuTalo4sF0JZStaDVNG9fLFVZPVBD+VDlB4bvY97HjuqZUa8yFIgtHPKAqtiSuqFJVx2dNugp/gYsN+vyNHl8LhtZL9zK0ZYaAs44Br4/67ckawMC7do5i5Es5rng4WmM8J6QskS1ucD0ZEUA== x-ms-exchange-antispam-messagedata: vkB66ZftuQQ5djUJEHGWlhYcp8wm9KAWW3WVX1RBnT+uMYAyxPs685sGhrk8T2vuj9fUuSuw03L/A7SYQCUPi9JYuq2j0Rr9efz238+SZu+QQ7u84283RRpV4J8IwnhGPR4DC2SMx2dGK7LSuobomw== x-ms-exchange-transport-forked: True MIME-Version: 1.0 Original-Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=Wilco.Dijkstra@arm.com; Return-Path: Wilco.Dijkstra@arm.com X-MS-Exchange-Transport-CrossTenantHeadersStripped: AM5EUR03FT006.eop-EUR03.prod.protection.outlook.com X-MS-Office365-Filtering-Correlation-Id-Prvs: 4919ecd2-c497-4f17-e7f2-08d7a5836163 Hi, As reported in https://www.sourceware.org/ml/libc-alpha/2020-01/msg00629.html the sin/cos functions don't support correct rounding, but still have an old comment claiming so. Hence: Remove a comment claiming that sin/cos round correctly. diff --git a/sysdeps/ieee754/dbl-64/s_sin.c b/sysdeps/ieee754/dbl-64/s_sin.c index 97bb5cba2ff97ebd83d4b54b038e175820908ab9..64f81912a125e6382061d0853a8e1b12109128ff 100644 --- a/sysdeps/ieee754/dbl-64/s_sin.c +++ b/sysdeps/ieee754/dbl-64/s_sin.c @@ -192,8 +192,8 @@ do_sincos (double a, double da, int4 n) /*******************************************************************/ -/* An ultimate sin routine. Given an IEEE double machine number x */ -/* it computes the correctly rounded (to nearest) value of sin(x) */ +/* An ultimate sin routine. Given an IEEE double machine number x */ +/* it computes the rounded value of sin(x). */ /*******************************************************************/ #ifndef IN_SINCOS double @@ -256,8 +256,8 @@ __sin (double x) /*******************************************************************/ -/* An ultimate cos routine. Given an IEEE double machine number x */ -/* it computes the correctly rounded (to nearest) value of cos(x) */ +/* An ultimate cos routine. Given an IEEE double machine number x */ +/* it computes the rounded value of cos(x). */ /*******************************************************************/ double