PATCH] Fix comment about rounding in sin/cos

Message ID AM5PR0801MB20351F0E82B9E6585B426DE383040@AM5PR0801MB2035.eurprd08.prod.outlook.com
State Committed
Commit 814309f0c226fc1f2c4eb6a042d74df6f496db23
Headers

Commit Message

Wilco Dijkstra Jan. 30, 2020, 12:53 p.m. UTC
  Hi,

As reported in https://www.sourceware.org/ml/libc-alpha/2020-01/msg00629.html
the sin/cos functions don't support correct rounding, but still have an old comment
claiming so. Hence:

Remove a comment claiming that sin/cos round correctly.
--
  

Comments

Siddhesh Poyarekar Jan. 30, 2020, 2:39 p.m. UTC | #1
On 30/01/20 6:23 pm, Wilco Dijkstra wrote:
> Hi,
> 
> As reported in https://www.sourceware.org/ml/libc-alpha/2020-01/msg00629.html
> the sin/cos functions don't support correct rounding, but still have an old comment
> claiming so. Hence:
> 
> Remove a comment claiming that sin/cos round correctly.

OK for master if you commit it by today, else on Monday after 2.32 release.

Siddhesh
  

Patch

diff --git a/sysdeps/ieee754/dbl-64/s_sin.c b/sysdeps/ieee754/dbl-64/s_sin.c
index 97bb5cba2ff97ebd83d4b54b038e175820908ab9..64f81912a125e6382061d0853a8e1b12109128ff 100644
--- a/sysdeps/ieee754/dbl-64/s_sin.c
+++ b/sysdeps/ieee754/dbl-64/s_sin.c
@@ -192,8 +192,8 @@  do_sincos (double a, double da, int4 n)
 
 
 /*******************************************************************/
-/* An ultimate sin routine. Given an IEEE double machine number x   */
-/* it computes the correctly rounded (to nearest) value of sin(x)  */
+/* An ultimate sin routine. Given an IEEE double machine number x  */
+/* it computes the rounded value of sin(x).			   */
 /*******************************************************************/
 #ifndef IN_SINCOS
 double
@@ -256,8 +256,8 @@  __sin (double x)
 
 
 /*******************************************************************/
-/* An ultimate cos routine. Given an IEEE double machine number x   */
-/* it computes the correctly rounded (to nearest) value of cos(x)  */
+/* An ultimate cos routine. Given an IEEE double machine number x  */
+/* it computes the rounded value of cos(x).			   */
 /*******************************************************************/
 
 double