From patchwork Wed Dec 21 13:35:53 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Florian Weimer X-Patchwork-Id: 18610 Received: (qmail 110116 invoked by alias); 21 Dec 2016 13:36:07 -0000 Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libc-alpha-owner@sourceware.org Delivered-To: mailing list libc-alpha@sourceware.org Received: (qmail 110061 invoked by uid 89); 21 Dec 2016 13:36:06 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-5.0 required=5.0 tests=BAYES_00, RP_MATCHES_RCVD, SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=alcock, 2016-12-21 X-HELO: mx1.redhat.com Subject: Re: [PATCH 14/15] tst-quad1pie, tst-quad2pie: compile with -fPIE To: Nix , libc-alpha@sourceware.org References: <20161219111528.14969-1-nix@esperi.org.uk> <20161219111528.14969-15-nix@esperi.org.uk> From: Florian Weimer Message-ID: <9de96df6-c531-50d1-879e-d6a82f272a8f@redhat.com> Date: Wed, 21 Dec 2016 14:35:53 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.5.1 MIME-Version: 1.0 In-Reply-To: <20161219111528.14969-15-nix@esperi.org.uk> On 12/19/2016 12:15 PM, Nix wrote: > From: Nick Alcock > > With stack protection enabled, these files have external symbol > references for the first time, so the fact that they are not compiled > with -fPIE and are then linked into a -pie binary starts to hurt. > > v10: New. > > * sysdeps/x86_64/Makefile (CFLAGS-tst-quad1pie.c): Add PIE-ccflag. > (CFLAGS-tst-quad2pie.c): Likewise. This is what I committed. Thanks, Florian x86_64: tst-quad1pie, tst-quad2pie: compile with -fPIE [BZ #7065] With stack protection enabled, these files have external symbol references for the first time, so the fact that they are not compiled with -fPIE and are then linked into a -pie binary starts to hurt. 2016-12-21 Nick Alcock [BZ #7065] * sysdeps/x86_64/Makefile [$(subdir) = elf] (CFLAGS-tst-quad1pie.c, CFLAGS-tst-quad2pie.c): Add $(PIE-ccflag). diff --git a/sysdeps/x86_64/Makefile b/sysdeps/x86_64/Makefile index 6d99284..5f25893 100644 --- a/sysdeps/x86_64/Makefile +++ b/sysdeps/x86_64/Makefile @@ -49,6 +49,9 @@ extra-test-objs += tst-quadmod1pie.o tst-quadmod2pie.o $(objpfx)tst-quad1pie: $(objpfx)tst-quadmod1pie.o $(objpfx)tst-quad2pie: $(objpfx)tst-quadmod2pie.o +CFLAGS-tst-quad1pie.c = $(PIE-ccflag) +CFLAGS-tst-quad2pie.c = $(PIE-ccflag) + tests += tst-audit3 tst-audit4 tst-audit5 tst-audit6 tst-audit7 tst-audit10 test-extras += tst-audit4-aux tst-audit10-aux extra-test-objs += tst-audit4-aux.o tst-audit10-aux.o