From patchwork Tue Dec 11 01:19:08 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Carlos O'Donell X-Patchwork-Id: 30617 Received: (qmail 110750 invoked by alias); 11 Dec 2018 01:19:15 -0000 Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libc-alpha-owner@sourceware.org Delivered-To: mailing list libc-alpha@sourceware.org Received: (qmail 110727 invoked by uid 89); 11 Dec 2018 01:19:14 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-26.9 required=5.0 tests=BAYES_00, GIT_PATCH_0, GIT_PATCH_1, GIT_PATCH_2, GIT_PATCH_3, RCVD_IN_DNSWL_NONE autolearn=ham version=3.3.2 spammy=sk:constru, opportunity X-HELO: mail-qk1-f194.google.com Return-Path: To: GNU C Library From: Carlos O'Donell Subject: [PATCH] localedef: Add verbose messages for failure paths. Openpgp: preference=signencrypt Message-ID: <9ce1738a-1830-67d8-cad8-b8bec4963f03@redhat.com> Date: Mon, 10 Dec 2018 20:19:08 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.3.0 MIME-Version: 1.0 During testing of localedef running in a minimal container there were several error cases which were hard to diagnose since they appeared as strerror (errno) values printed by the higher level functions. This change adds three new verbose messages for potential failure paths. The new messages give the user the opportunity to use -v and display additional information about why localedef might be failing. I found these messages useful myself while writing a localedef container test for --no-hard-links. Signed-off-by: Carlos O'Donell --- ChangeLog | 5 +++++ locale/programs/localedef.c | 30 ++++++++++++++++++++++-------- 2 files changed, 27 insertions(+), 8 deletions(-) diff --git a/ChangeLog b/ChangeLog index 8d2494e054..0fd6dfc224 100644 --- a/ChangeLog +++ b/ChangeLog @@ -1,3 +1,8 @@ +2018-12-10 Carlos O'Donell + + * locale/programs/localedef.c (construct_output_path): Use + record_verbose to print verbose output in three failure modes. + 2018-12-10 Joseph Myers * scripts/gen-as-const.py (main): Handle --python option. diff --git a/locale/programs/localedef.c b/locale/programs/localedef.c index 6c4936be6b..10c08231fe 100644 --- a/locale/programs/localedef.c +++ b/locale/programs/localedef.c @@ -526,7 +526,11 @@ construct_output_path (char *path) (int) (startp - path), path, normal, endp, '\0'); if (n < 0) - return NULL; + { + record_verbose (stderr, + _("failed to allocate space for compiled locale path")); + return NULL; + } endp = result + n - 1; } @@ -546,13 +550,23 @@ construct_output_path (char *path) errno = 0; if (no_archive && euidaccess (result, W_OK) == -1) - /* Perhaps the directory does not exist now. Try to create it. */ - if (errno == ENOENT) - { - errno = 0; - if (mkdir (result, 0777) < 0) - return NULL; - } + { + /* Perhaps the directory does not exist now. Try to create it. */ + if (errno == ENOENT) + { + errno = 0; + if (mkdir (result, 0777) < 0) + { + record_verbose (stderr, + _("cannot create output path \"%s\": %s"), + result, strerror (errno)); + return NULL; + } + } + else + record_verbose (stderr, _("no write permission to output path: %s"), + strerror (errno)); + } *endp++ = '/'; *endp = '\0';