[3/4] sunrpc: Do not export getrpcport by default
Commit Message
This function looks like an NSS function, but is actually a wrapper
around pmap_getport, so it should only be exported with
--enable-obsolete-rpc.
---
sunrpc/getrpcport.c | 5 +++++
1 file changed, 5 insertions(+)
Comments
On Mon, Jul 6, 2020 at 12:06 PM Florian Weimer via Libc-alpha
<libc-alpha@sourceware.org> wrote:
>
> This function looks like an NSS function, but is actually a wrapper
> around pmap_getport, so it should only be exported with
> --enable-obsolete-rpc.
> ---
> sunrpc/getrpcport.c | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/sunrpc/getrpcport.c b/sunrpc/getrpcport.c
> index 7d4b23865f..5dd635735c 100644
> --- a/sunrpc/getrpcport.c
> +++ b/sunrpc/getrpcport.c
> @@ -66,3 +66,8 @@ getrpcport (const char *host, u_long prognum, u_long versnum, u_int proto)
> return 0;
> return pmap_getport (&addr, prognum, versnum, proto);
> }
> +#ifdef SHARED
> +# ifndef EXPORT_RPC_SYMBOLS
> +compat_symbol (libc, getrpcport, getrpcport, GLIBC_2_0);
> +# endif
> +#endif
> --
> 2.25.4
>
>
LGTM.
Thanks.
@@ -66,3 +66,8 @@ getrpcport (const char *host, u_long prognum, u_long versnum, u_int proto)
return 0;
return pmap_getport (&addr, prognum, versnum, proto);
}
+#ifdef SHARED
+# ifndef EXPORT_RPC_SYMBOLS
+compat_symbol (libc, getrpcport, getrpcport, GLIBC_2_0);
+# endif
+#endif