math: $(libm-tests-compat) can be regular tests

Message ID 87h7lqkirc.fsf@oldenburg.str.redhat.com
State Committed
Commit 07db3f552376bce3bcbf785ec67ea03a7f82017a
Headers
Series math: $(libm-tests-compat) can be regular tests |

Commit Message

Florian Weimer March 4, 2021, 4:04 p.m. UTC
  tests-internal is no longer needed because compat_symbol_reference
now works in regular tests.

---
 math/Makefile | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)
  

Comments

Adhemerval Zanella March 8, 2021, 2:06 p.m. UTC | #1
On 04/03/2021 13:04, Florian Weimer via Libc-alpha wrote:
> tests-internal is no longer needed because compat_symbol_reference
> now works in regular tests.

LGTM, thanks.

Reviewed-by: Adhemerval Zanella  <adhemerval.zanella@linaro.org>

> 
> ---
>  math/Makefile | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/math/Makefile b/math/Makefile
> index 687aa5d510..2978abf526 100644
> --- a/math/Makefile
> +++ b/math/Makefile
> @@ -325,8 +325,7 @@ libm-tests-for-type = $(foreach f,$(libm-test-funcs-all),\
>  
>  libm-tests.o = $(addsuffix .o,$(libm-tests))
>  
> -tests += $(filter-out $(libm-tests-compat),$(libm-tests))
> -tests-internal += $(libm-tests-compat)
> +tests += $(libm-tests)
>  generated += $(addsuffix .c,$(libm-tests)) \
>  	     $(foreach t,$(test-types),libm-test-support-$(t).c)
>  
>
  

Patch

diff --git a/math/Makefile b/math/Makefile
index 687aa5d510..2978abf526 100644
--- a/math/Makefile
+++ b/math/Makefile
@@ -325,8 +325,7 @@  libm-tests-for-type = $(foreach f,$(libm-test-funcs-all),\
 
 libm-tests.o = $(addsuffix .o,$(libm-tests))
 
-tests += $(filter-out $(libm-tests-compat),$(libm-tests))
-tests-internal += $(libm-tests-compat)
+tests += $(libm-tests)
 generated += $(addsuffix .c,$(libm-tests)) \
 	     $(foreach t,$(test-types),libm-test-support-$(t).c)