From patchwork Thu Mar 14 12:05:19 2019
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
X-Patchwork-Submitter: Florian Weimer <fweimer@redhat.com>
X-Patchwork-Id: 31850
Received: (qmail 29985 invoked by alias); 14 Mar 2019 12:05:28 -0000
Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <libc-alpha.sourceware.org>
List-Unsubscribe: <mailto:libc-alpha-unsubscribe-##L=##H@sourceware.org>
List-Subscribe: <mailto:libc-alpha-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/libc-alpha/>
List-Post: <mailto:libc-alpha@sourceware.org>
List-Help: <mailto:libc-alpha-help@sourceware.org>,
	<http://sourceware.org/ml/#faqs>
Sender: libc-alpha-owner@sourceware.org
Delivered-To: mailing list libc-alpha@sourceware.org
Received: (qmail 29974 invoked by uid 89); 14 Mar 2019 12:05:27 -0000
Authentication-Results: sourceware.org; auth=none
X-Spam-SWARE-Status: No, score=-19.0 required=5.0 tests=AWL, BAYES_00,
	GIT_PATCH_0, GIT_PATCH_1, GIT_PATCH_2, GIT_PATCH_3,
	SPF_HELO_PASS autolearn=ham version=3.3.1 spammy=1416
X-HELO: mx1.redhat.com
From: Florian Weimer <fweimer@redhat.com>
To: Carlos O'Donell <carlos@redhat.com>
Cc: Zack Weinberg <zackw@panix.com>,
	GNU C Library <libc-alpha@sourceware.org>
Subject: Re: [PATCH] Remove obsolete,
	never-implemented XSI STREAMS declarations
References: <87zhqi626s.fsf@oldenburg2.str.redhat.com>
	<CAKCAbMgBcxYLOo8jrBejr9UH1WDjcpw610o5qscCqnLcdvJr6Q@mail.gmail.com>
	<874l8q4hor.fsf@oldenburg2.str.redhat.com>
	<1f520688-5a78-782b-d3be-044991db0976@redhat.com>
Date: Thu, 14 Mar 2019 13:05:19 +0100
In-Reply-To: <1f520688-5a78-782b-d3be-044991db0976@redhat.com> (Carlos
	O'Donell's message of "Wed, 13 Mar 2019 17:47:40 -0400")
Message-ID: <87ftrp7jb4.fsf@oldenburg2.str.redhat.com>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux)
MIME-Version: 1.0

* Carlos O'Donell:

> Reviewed-by: Carlos O'Donell <carlos@rehdat.com>

My pre-push testing revealed that my previous testing had been
insufficient, and I had to make the changes below.

(Hurd does not have any other GLIBC_2.30 reference, which is why had to
add the section to posix/Versions.)

Does your Reviewed-by: still stand?

Thanks,
Florian
Reviewed-by: Carlos O'Donell <carlos@redhat.com>

diff --git a/ChangeLog b/ChangeLog
index cf62a1a1c8..1688c47781 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,4 +1,4 @@
-2019-02-26  Florian Weimer  <fweimer@redhat.com>
+2019-03-14  Florian Weimer  <fweimer@redhat.com>
 
 	Remove obsolete, never-implemented XSI STREAMS declarations.
 	* manual/terminal.texi (Allocation): Remove portability note and
@@ -13,6 +13,9 @@
 	(conformtest-headers-POSIX2008): Likewise.
 	* posix/compat-streams.c: New file.
 	* posix/Makefile (routines): Add it.
+	* posix/Versions (GLIBC_2.1): Add fattach, fdetach, getmsg,
+	getpmsg, isastream, putmsg, putpmsg.
+	(GLIBC_2.30): New section.
 	* bits/stropts.h: Remove file.
 	* bits/xtitypes.h: Likewise.
 	* conform/data/stropts.h-data: Likewise.
diff --git a/posix/Versions b/posix/Versions
index ad693ae9a7..7d06a6d0c0 100644
--- a/posix/Versions
+++ b/posix/Versions
@@ -80,6 +80,10 @@ libc {
     # w*
     waitid; wordexp; wordfree;
   }
+  GLIBC_2.1 {
+    # Compat symbols for the obsolete, unimplemented XSI streams extension.
+    fattach; fdetach; getmsg; getpmsg; isastream; putmsg; putpmsg;
+  }
   GLIBC_2.1.2 {
     # functions used in other libraries
     __vfork;
@@ -141,6 +145,8 @@ libc {
     posix_spawn_file_actions_addchdir_np;
     posix_spawn_file_actions_addfchdir_np;
   }
+  GLIBC_2.30 {
+  }
   GLIBC_PRIVATE {
     __libc_fork; __libc_pread; __libc_pwrite;
     __nanosleep_nocancel; __pause_nocancel;