diff mbox series

build-many-glibcs.py: Use make -O for more consistent log output

Message ID 87eehc9f4n.fsf@oldenburg.str.redhat.com
State Committed
Commit 418f5783d987ed13fee217d8aad47b8b23b28a87
Headers show
Series build-many-glibcs.py: Use make -O for more consistent log output | expand

Commit Message

Florian Weimer Feb. 19, 2021, 4:49 p.m. UTC
The -O option avoids interleaving (e.g.) compiler error messages
with other build messages, and makes attribute of messages to
commands easier.

According to my tests, the impact on build time is within the noise.

---
 scripts/build-many-glibcs.py | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Carlos O'Donell Feb. 19, 2021, 9:14 p.m. UTC | #1
On 2/19/21 11:49 AM, Florian Weimer via Libc-alpha wrote:
> The -O option avoids interleaving (e.g.) compiler error messages
> with other build messages, and makes attribute of messages to
> commands easier.
> 
> According to my tests, the impact on build time is within the noise.
> 
> ---
>  scripts/build-many-glibcs.py | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/scripts/build-many-glibcs.py b/scripts/build-many-glibcs.py
> index 071f338cbb..8d97320f6d 100755
> --- a/scripts/build-many-glibcs.py
> +++ b/scripts/build-many-glibcs.py
> @@ -670,7 +670,7 @@ class Context(object):
>  
>      def do_build(self):
>          """Do the actual build."""
> -        cmd = ['make', '-j%d' % self.parallelism]
> +        cmd = ['make', '-O', '-j%d' % self.parallelism]
>          subprocess.run(cmd, cwd=self.builddir, check=True)
>  
>      def build_host_libraries(self):
> 

LGTM. Defaults to deinterlacing the output from the entire recipe (target).

Reviewed-by: Carlos O'Donell <carlos@redhat.com>
diff mbox series

Patch

diff --git a/scripts/build-many-glibcs.py b/scripts/build-many-glibcs.py
index 071f338cbb..8d97320f6d 100755
--- a/scripts/build-many-glibcs.py
+++ b/scripts/build-many-glibcs.py
@@ -670,7 +670,7 @@  class Context(object):
 
     def do_build(self):
         """Do the actual build."""
-        cmd = ['make', '-j%d' % self.parallelism]
+        cmd = ['make', '-O', '-j%d' % self.parallelism]
         subprocess.run(cmd, cwd=self.builddir, check=True)
 
     def build_host_libraries(self):