From patchwork Sat Sep 7 10:06:09 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Paul Eggert X-Patchwork-Id: 34440 Received: (qmail 89149 invoked by alias); 7 Sep 2019 10:06:20 -0000 Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libc-alpha-owner@sourceware.org Delivered-To: mailing list libc-alpha@sourceware.org Received: (qmail 89140 invoked by uid 89); 7 Sep 2019 10:06:20 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-16.7 required=5.0 tests=AWL, BAYES_00, GIT_PATCH_0, GIT_PATCH_1, GIT_PATCH_2, GIT_PATCH_3, KAM_SHORT, SPF_PASS autolearn=ham version=3.3.1 spammy=HX-Languages-Length:2947, refused X-HELO: zimbra.cs.ucla.edu Subject: Re: [PATCH] Prefer https: for GNU and FSF URLs To: Joseph Myers Cc: GNU C Library References: <18cce39e-4a5a-27d8-a1ca-5ec45973088e@cs.ucla.edu> From: Paul Eggert Message-ID: <712eae41-cc8d-fe80-da06-249c9a2b7cff@cs.ucla.edu> Date: Sat, 7 Sep 2019 03:06:09 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.8.0 MIME-Version: 1.0 In-Reply-To: On 9/22/17 4:47 AM, Joseph Myers wrote: > This command looks like it would modify some generated files, rather than > modifying their sources and regenerating. Thanks for mentioning that. I finally got around to fixing the issues you mentioned, and installed the adjusted patch into the glibc master. As the patch is 5.6 MB I won't attach it here. I ran into a problem, though: the remote on sourceware.org refused to patch three of the files, giving messages like this: # remote: *** error: sysdeps/powerpc/powerpc64/ppc-mcount.S: trailing lines or like this: # remote: *** error: sysdeps/sparc/sparc64/multiarch/memcpy-ultra3.S: last line does not end in newline I'm attaching a patch for the three files that the remote refused to fix. I assume that to install this patch I would need to fix the pre-commit hooks on the sourceware.org side, but I don't see how to go about this in ; am I looking in the wrong place? From fd91cced29fa417347318a2816426e3168f6ea72 Mon Sep 17 00:00:00 2001 From: Paul Eggert Date: Sat, 7 Sep 2019 02:54:48 -0700 Subject: [PATCH] Fix three GNU license URLs. --- sysdeps/powerpc/powerpc64/ppc-mcount.S | 2 +- sysdeps/sparc/sparc64/multiarch/memcpy-ultra3.S | 2 +- sysdeps/unix/sysv/linux/s390/s390-64/syscall.S | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/sysdeps/powerpc/powerpc64/ppc-mcount.S b/sysdeps/powerpc/powerpc64/ppc-mcount.S index fb301a77be..bcf0b035d1 100644 --- a/sysdeps/powerpc/powerpc64/ppc-mcount.S +++ b/sysdeps/powerpc/powerpc64/ppc-mcount.S @@ -14,7 +14,7 @@ You should have received a copy of the GNU Lesser General Public License along with the GNU C Library; if not, see - . */ + . */ #include /* We don't need to save the parameter-passing registers as gcc takes diff --git a/sysdeps/sparc/sparc64/multiarch/memcpy-ultra3.S b/sysdeps/sparc/sparc64/multiarch/memcpy-ultra3.S index 17f5f26391..fda80c2f0f 100644 --- a/sysdeps/sparc/sparc64/multiarch/memcpy-ultra3.S +++ b/sysdeps/sparc/sparc64/multiarch/memcpy-ultra3.S @@ -16,7 +16,7 @@ You should have received a copy of the GNU Lesser General Public License along with the GNU C Library; if not, see - . */ + . */ #include diff --git a/sysdeps/unix/sysv/linux/s390/s390-64/syscall.S b/sysdeps/unix/sysv/linux/s390/s390-64/syscall.S index b51aa2fc50..ca8b1afdc8 100644 --- a/sysdeps/unix/sysv/linux/s390/s390-64/syscall.S +++ b/sysdeps/unix/sysv/linux/s390/s390-64/syscall.S @@ -14,7 +14,7 @@ You should have received a copy of the GNU Lesser General Public License along with the GNU C Library; if not, see - . */ + . */ #include -- 2.21.0