From patchwork Thu Jun 27 07:33:48 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: =?utf-8?b?5q+b5pmX?= X-Patchwork-Id: 33446 Received: (qmail 89951 invoked by alias); 27 Jun 2019 07:35:16 -0000 Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libc-alpha-owner@sourceware.org Delivered-To: mailing list libc-alpha@sourceware.org Received: (qmail 89933 invoked by uid 89); 27 Jun 2019 07:35:16 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-20.6 required=5.0 tests=AWL, BAYES_00, GIT_PATCH_0, GIT_PATCH_1, GIT_PATCH_2, GIT_PATCH_3, KAM_LOTSOFHASH, UNPARSEABLE_RELAY autolearn=ham version=3.3.1 spammy=HX-Languages-Length:2149 X-HELO: smtp2200-217.mail.aliyun.com X-Alimail-AntiSpam: AC=CONTINUE; BC=0.07747325|-1; CH=green; DM=CONTINUE|CONTINUE|true|0.283218-0.0100639-0.706718; FP=0|0|0|0|0|-1|-1|-1; HT=e02c03307; MF=han_mao@c-sky.com; NM=1; PH=DS; RN=5; RT=5; SR=0; TI=SMTPD_---.EqjVHHm_1561620911; From: Mao Han To: libc-alpha@sourceware.org Cc: Mao Han , Florian Weimer , David Newall , Vincent Chen Subject: [RFC 1/1] testcase fail while using cross-test-ssh wrapper Date: Thu, 27 Jun 2019 15:33:48 +0800 Message-Id: <6067f3ff4ac4b7e991405f216e928e62f4780c8b.1561620739.git.han_mao@c-sky.com> I did a regression test yesterday, and found tst-locale-locpath.sh and tst-rtld-preload.sh failed due to some script problem. The ssh wrapper is invoked twice on these testcase, seems some of the arguments are not pass correctly for cross test. tst-locale-locpath.sh test cmd: /home/vmh/workspace/buildroot2/buildroot/output/build/glibc-02d8b5ab1c89bcef2627d2b621bfb35b573852c2/scripts/cross-test-ssh.sh --timeoutfactor 6000 10.0.2.17 /home/vmh/workspace/buildroot2/buildroot/output/build/glibc-02d8b5ab1c89bcef2627d2b621bfb35b573852c2/scripts/cross-test-ssh.sh --timeoutfactor 6000 10.0.2.17 env LC_ALL=invalid-locale LOCPATH=does-not-exist /home/vmh/workspace/buildroot2/buildroot/output/build/glibc-02d8b5ab1c89bcef2627d2b621bfb35b573852c2/build/elf/ld.so --library-path /home/vmh/workspace/buildroot2/buildroot/output/build/glibc-02d8b5ab1c89bcef2627d2b621bfb35b573852c2/build/ /home/vmh/workspace/buildroot2/buildroot/output/build/glibc-02d8b5ab1c89bcef2627d2b621bfb35b573852c2/build/locale/locale Cc: Florian Weimer Cc: David Newall Cc: Vincent Chen --- elf/tst-rtld-preload.sh | 2 +- locale/tst-locale-locpath.sh | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/elf/tst-rtld-preload.sh b/elf/tst-rtld-preload.sh index f0c0ca1..0fe9e4f 100755 --- a/elf/tst-rtld-preload.sh +++ b/elf/tst-rtld-preload.sh @@ -31,7 +31,7 @@ echo "# [${test_wrapper}] [$rtld] [--library-path] [$library_path]" \ "[--preload] [$preload] [$test_program]" ${test_wrapper_env} \ ${run_program_env} \ -${test_wrapper} $rtld --library-path "$library_path" \ +$rtld --library-path "$library_path" \ --preload "$preload" $test_program 2>&1 && rc=0 || rc=$? echo "# exit status $rc" diff --git a/locale/tst-locale-locpath.sh b/locale/tst-locale-locpath.sh index b83de90..1281e9c 100644 --- a/locale/tst-locale-locpath.sh +++ b/locale/tst-locale-locpath.sh @@ -20,8 +20,8 @@ set -ex common_objpfx=$1 -test_wrapper_env=$2 -run_program_env=$3 +test_wrapper_env=$3 +run_program_env= LIBPATH="$common_objpfx"