From patchwork Wed Dec 10 23:13:20 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Steve Ellcey X-Patchwork-Id: 4166 Received: (qmail 12497 invoked by alias); 10 Dec 2014 23:13:29 -0000 Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libc-alpha-owner@sourceware.org Delivered-To: mailing list libc-alpha@sourceware.org Received: (qmail 12487 invoked by uid 89); 10 Dec 2014 23:13:28 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.0 required=5.0 tests=AWL, BAYES_00, SPF_PASS, T_RP_MATCHES_RCVD autolearn=ham version=3.3.2 X-HELO: mailapp01.imgtec.com From: "Steve Ellcey " Date: Wed, 10 Dec 2014 15:13:20 -0800 To: Subject: [Patch, MIPS] Fix warning from malloc/malloc.c User-Agent: Heirloom mailx 12.5 6/20/10 MIME-Version: 1.0 Message-ID: <5b13bf9e-b30c-4405-b2aa-cfa2b3e4c618@BAMAIL02.ba.imgtec.org> Here is a fix for another warning (now error) found in my MIPS build. malloc.c: In function '__posix_memalign': malloc.c:4976:50: error: logical not is only applied to the left hand side of comparison [-Werror=logical-not-parentheses] || !powerof2 (alignment / sizeof (void *)) != 0 ^ cc1: all warnings being treated as errors The fix is to remove the '!= 0' comparision since it is redundant. OK to checkin? Steve Ellcey sellcey@imgtec.com 2014-12-10 Steve Ellcey * malloc/malloc.c: Fix powerof2 check. diff --git a/malloc/malloc.c b/malloc/malloc.c index 6bfb859..cb91b97 100644 --- a/malloc/malloc.c +++ b/malloc/malloc.c @@ -4973,7 +4973,7 @@ __posix_memalign (void **memptr, size_t alignment, size_t size) /* Test whether the SIZE argument is valid. It must be a power of two multiple of sizeof (void *). */ if (alignment % sizeof (void *) != 0 - || !powerof2 (alignment / sizeof (void *)) != 0 + || !powerof2 (alignment / sizeof (void *)) || alignment == 0) return EINVAL;