From patchwork Tue Apr 8 21:11:07 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Carlos O'Donell X-Patchwork-Id: 435 Return-Path: X-Original-To: siddhesh@wilcox.dreamhost.com Delivered-To: siddhesh@wilcox.dreamhost.com Received: from homiemail-mx21.g.dreamhost.com (peon2454.g.dreamhost.com [208.113.200.127]) by wilcox.dreamhost.com (Postfix) with ESMTP id 638F1360078 for ; Tue, 8 Apr 2014 14:11:15 -0700 (PDT) Received: by homiemail-mx21.g.dreamhost.com (Postfix, from userid 14307373) id 103A1105881B; Tue, 8 Apr 2014 14:11:14 -0700 (PDT) X-Original-To: glibc@patchwork.siddhesh.in Delivered-To: x14307373@homiemail-mx21.g.dreamhost.com Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by homiemail-mx21.g.dreamhost.com (Postfix) with ESMTPS id CB34A104E803 for ; Tue, 8 Apr 2014 14:11:14 -0700 (PDT) DomainKey-Signature: a=rsa-sha1; c=nofws; d=sourceware.org; h=list-id :list-unsubscribe:list-subscribe:list-archive:list-post :list-help:sender:message-id:date:from:mime-version:to:cc :subject:content-type:content-transfer-encoding; q=dns; s= default; b=VWXmb2SHruqVgEs5uPknDwYNc7omScEIK76uRSfl37DELAvMtzJ2e M3/wGpprcF8i1F1ExBpivoX3EqhHFHHhev5GH2ooxjFmgy7eTOiiedeLI84GwtVI EmyZgiNNUae+i3Tt3yHO1+smc1jHC2ewezmMZwXbr0rX47kstZKO8Y= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=sourceware.org; h=list-id :list-unsubscribe:list-subscribe:list-archive:list-post :list-help:sender:message-id:date:from:mime-version:to:cc :subject:content-type:content-transfer-encoding; s=default; bh=/ bBXdncZONPzxC/IHabQxrwLVQg=; b=pcrj5WEO9t50XN5FqZXwtpiNKg0HeIaAj t2sHJ8dB7mHVWqiWJ1nV11lAHssmPbBLXMibn3FIFjcWiEKVZZE23taSjtEhBbe8 vCdKoRbH1aBka1oY6KSkFWJzhDl0O6Y3iZbpODzExppjsfodxSmm5jKbP3oe27Hs K7qvv+LIAs= Received: (qmail 26110 invoked by alias); 8 Apr 2014 21:11:12 -0000 Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libc-alpha-owner@sourceware.org Delivered-To: mailing list libc-alpha@sourceware.org Received: (qmail 26097 invoked by uid 89); 8 Apr 2014 21:11:11 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.9 required=5.0 tests=AWL, BAYES_00, RP_MATCHES_RCVD, SPF_HELO_PASS, SPF_PASS autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Message-ID: <534465EB.5020204@redhat.com> Date: Tue, 08 Apr 2014 17:11:07 -0400 From: "Carlos O'Donell" User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.3.0 MIME-Version: 1.0 To: GNU C Library CC: Patsy Franklin Subject: [COMMITTED] Fix manual/ipc.texi safety notes. X-DH-Original-To: glibc@patchwork.siddhesh.in Fix a check-safety.sh warning that had caught the use of asucorrupt{} as the reason sem_close was AC-unsafe. That's not correct, the function is AC-unsafe because of aculock{} from the call to lll_lock* (leaks locks). Fixed thusly, and this fixes the check-safety.sh warning for the manual. 2014-04-08 Carlos O'Donell * manual/ipc.texi (sem_close): AC-unsafe because of aculock. --- Cheers, Carlos. diff --git a/manual/ipc.texi b/manual/ipc.texi index afedcbe..081b98f 100644 --- a/manual/ipc.texi +++ b/manual/ipc.texi @@ -68,9 +68,9 @@ by @theglibc{}. @end deftypefun @deftypefun int sem_close (sem_t *@var{sem}); -@safety{@prelim{}@mtsafe{}@asunsafe{@asulock{}}@acunsafe{@asucorrupt{}}} +@safety{@prelim{}@mtsafe{}@asunsafe{@asulock{}}@acunsafe{@aculock{}}} @c lll_lock asulock aculock -@c twalk asucorrupt +@c twalk mtsrace{:root} @c @c We are AS-unsafe because we take a non-recursive lock. @c We are AC-unsafe because several internal data structures