Define _STRING_ARCH_unaligned unconditionally

Message ID 53331005.1080804@linux.vnet.ibm.com
State Rejected
Headers

Commit Message

Adhemerval Zanella Netto March 26, 2014, 5:36 p.m. UTC
  This is a respin on my initial try to remove the undefined _STRING_ARCH_unaligned
from PPC64 builds, but now extended to all arch that do not define it.  This patch
defines _STRING_ARCH_unaligned to 0, mimicking old undefined behavior.

--

	* bits/string.h (_STRING_ARCH_unaligned): Define it to 0.

---
  

Comments

Joseph Myers March 26, 2014, 5:42 p.m. UTC | #1
On Wed, 26 Mar 2014, Adhemerval Zanella wrote:

> This is a respin on my initial try to remove the undefined _STRING_ARCH_unaligned
> from PPC64 builds, but now extended to all arch that do not define it.  This patch
> defines _STRING_ARCH_unaligned to 0, mimicking old undefined behavior.
> 
> --
> 
> 	* bits/string.h (_STRING_ARCH_unaligned): Define it to 0.

I see various files in the source tree with #ifdef / #ifndef / "defined" 
conditionals on _STRING_ARCH_unaligned.  I don't think those are correct 
with it defined to 0, so I think you need to change all of those are part 
of the patch introducing the possibility that it might be defined to 0.

crypt/sha256.c
iconv/gconv_simple.c
iconv/loop.c
iconv/skeleton.c
nscd/nscd_gethst_r.c
nscd/nscd_getserv_r.c
nscd/nscd_helper.c
resolv/res_send.c
  

Patch

diff --git a/bits/string.h b/bits/string.h
index f8630d2..42516d4 100644
--- a/bits/string.h
+++ b/bits/string.h
@@ -8,5 +8,6 @@ 
 #ifndef _BITS_STRING_H
 #define _BITS_STRING_H	1
 
+#define _STRING_ARCH_unaligned   0
 
 #endif /* bits/string.h */