From patchwork Mon Oct 31 20:50:15 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Carlos O'Donell X-Patchwork-Id: 17045 Received: (qmail 14356 invoked by alias); 31 Oct 2016 20:50:20 -0000 Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libc-alpha-owner@sourceware.org Delivered-To: mailing list libc-alpha@sourceware.org Received: (qmail 14341 invoked by uid 89); 31 Oct 2016 20:50:19 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.4 required=5.0 tests=AWL, BAYES_00, RCVD_IN_DNSWL_NONE, RCVD_IN_SORBS_SPAM autolearn=no version=3.3.2 spammy= X-HELO: mail-yw0-f175.google.com X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:subject:to:references:cc:from:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding; bh=HZ7UQjQN8HdPtyUO+AI0ERsl2FHpIxmDgdDWqN/xtIk=; b=NEmTKVQJHdipu0m5BSaliP3jWcZzbYpOGEUk/7WzLmAhLLKCk6kOBH8sdGgF81xF1r c/zSfgxKOnjlC96Wvt8drMbBZdQFngOmugvDhd/BvJPIIpkwQikthYOxq69w6oCyNnLP OkSoU4o0JjWNCZ1bS3Kul+KB659nMkKf2BAwjR7feNk+BbYEJCFi+57zaWJ5WlN5SL// Yk3wmqvqJKmyBYMnI+UPTGSRiNalrel6LgbW3p7q5VopNpSYcUZlo9381b+tMoO7ZcxO sYfzzTzV85an9sd8KPmGOi2/ar3E0Ny+7dcIPUnt/Gd2qa9mvSARP1b20ZgdyPGYv6ZA MT2w== X-Gm-Message-State: ABUngvdLvxXtyaw1dmsY3NjUWDO5OitB7LNKFPu5dnl1CcYnEd+MNZNPG9Iu7HQQaFEzxuJz X-Received: by 10.107.187.66 with SMTP id l63mr12058713iof.234.1477947016628; Mon, 31 Oct 2016 13:50:16 -0700 (PDT) Subject: Re: [PATCH v3] Fix -Os related build and test failures. To: Steve Ellcey References: <1477939106.2891.37.camel@caviumnetworks.com> <1477943809.2891.39.camel@caviumnetworks.com> Cc: GNU C Library From: Carlos O'Donell Message-ID: <5238d7ae-3e33-741b-3e96-61aa0d85f45b@redhat.com> Date: Mon, 31 Oct 2016 16:50:15 -0400 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0 MIME-Version: 1.0 In-Reply-To: <1477943809.2891.39.camel@caviumnetworks.com> On 10/31/2016 03:56 PM, Steve Ellcey wrote: > On Mon, 2016-10-31 at 15:50 -0400, Carlos O'Donell wrote: >> >> I have fix and I'm just testing it again on x86_64. >> >> Thank you for your patience :-) >> >> Cheers, >> Carlos. > > Sounds good. FYI: I ran into this problem with nptl_db/thread_dbP.h, > in addition to the files I mentioned. I think those are the only > instances of this problem. > > Steve Ellcey > This should fix it. Sorry for the lack of non-x86/x86_64 testing. Like I said I'll set about setting up more crosses like the kernel people do. commit bb5badf17087099dd9140f812778f7a8615b2111 Author: Carlos O'Donell Date: Mon Oct 31 16:46:57 2016 -0400 Bug 20729: Include libc-internal.h where required. The original fix for bug 20729 failed to include libc-internal.h in the files that needed them and this caused build failures on machines that don't implicitly include this header. This commit fixes that by following the consensus rule that a header, if needed, should always be directly included. --- Cheers, Carlos. diff --git a/locale/weight.h b/locale/weight.h index 1f61f01..19b8e4a 100644 --- a/locale/weight.h +++ b/locale/weight.h @@ -19,6 +19,8 @@ #ifndef _WEIGHT_H_ #define _WEIGHT_H_ 1 +#include + /* Find index of weight. */ static inline int32_t __attribute__ ((always_inline)) findidx (const int32_t *table, diff --git a/locale/weightwc.h b/locale/weightwc.h index e42ce13..ae18965 100644 --- a/locale/weightwc.h +++ b/locale/weightwc.h @@ -19,6 +19,8 @@ #ifndef _WEIGHTWC_H_ #define _WEIGHTWC_H_ 1 +#include + /* Find index of weight. */ static inline int32_t __attribute__ ((always_inline)) findidx (const int32_t *table, diff --git a/nptl_db/thread_dbP.h b/nptl_db/thread_dbP.h index b53f1c1..f448547 100644 --- a/nptl_db/thread_dbP.h +++ b/nptl_db/thread_dbP.h @@ -30,6 +30,7 @@ #include "../nptl/pthreadP.h" /* This is for *_BITMASK only. */ #include #include +#include /* Indeces for the symbol names. */ enum